pbstark / corla18 Goto Github PK

If I change the candidates = line in https://github.com/pbstark/CORLA18/blob/master/code/suite_toolkit.ipynb to have a number of candidates less than or equal to num_winners (by default 2):

• check_valid_vote_counts doesn't complain, but then
• I get a somewhat-cryptic error when calling check_overvote_rates:

ValueError: max() arg is an empty sequence

Dropping into ipython, I see that

In [1]: margins_a.values()
Out[1]: odict_values([])

In [2]: margins_a
Out[2]: OrderedDict()

Maybe not high-priority as those races won't need rigorous audits 😄 but confused me for a bit while doing some randomized testing, and I could imagine a misconfigured num_winners triggering this also.

As suggested elsewhere by Ron Rivest. Makes more sense.