Coder Social home page Coder Social logo

pau101 / wings Goto Github PK

View Code? Open in Web Editor NEW
25.0 8.0 29.0 1.35 MB

A Forge mod for Minecraft: Java Edition which adds wings for aerial travel.

Home Page: https://www.curseforge.com/minecraft/mc-mods/wings

License: MIT License

Java 88.45% JavaScript 11.55%
minecraft-mod minecraft wings

wings's Introduction

Wings

GitHub

Wings is a Forge mod for Minecraft: Java Edition which introduces an assortment of avian and insectoid wings for aerial travel.

wings's People

Contributors

albertosaurio65 avatar imeisa avatar kazuya79 avatar laike-endaril avatar pau101 avatar smolinacadena avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

wings's Issues

Potential issue with B3M (Time-Speed Mod)

B3M (Time-speed mod) should be the only mod in the pack I'm using that alters sun angles at all, but even with that mod's options turned off I get this crash upon loading a world with Wings installed.

Description: Exception in server tick loop

java.lang.NullPointerException
    at net.minecraft.world.World.getCelestialAngle(World.java:1540)
    at net.minecraft.world.World.getSunBrightnessFactor(World.java:1448)
    at net.minecraft.world.WorldProvider.getSunBrightnessFactor(WorldProvider.java:447)
    at net.minecraft.world.World.calculateSkylightSubtracted(World.java:1434)
    at net.minecraft.world.World.calculateInitialSkylight(World.java:2529)
    at net.minecraft.world.WorldServer.<init>(WorldServer.java:121)
    at net.optifine.override.WorldServerOF.<init>(WorldServerOF.java:27)
    at net.minecraft.server.integrated.IntegratedServer.loadAllWorlds(IntegratedServer.java:94)
    at net.minecraft.server.integrated.IntegratedServer.init(IntegratedServer.java:209)
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:486)
    at java.lang.Thread.run(Unknown Source)

Ores config is ignored (wings-1.1.3-1.12.2)

The settings for amethyst and fairy dust ores are being ignored with Wings 1.1.3 (MC 1.12.2).

It could be related to this commit: 046395d

If the file doesn't exist, ores.cfg is created, but as follows:

# Configuration file

amethyst {
}


fairy_dust {
}

Thanks for all your amazing work!

[Suggestion] A config option for 1st person animations

When flying with certain items, It looks weird having the second arm pop up. It would be nice to have a config to disable it for when mods have items with animations using two arms like Vic's Modern Warfare or the item hangs off the left side like Slashblade. Would that be possible?

Wings-related server crash?

Getting this crash with wings installed, when removing the mod the server loads up fine. Seems like its related to a mixin issue? The client loads up okay, its seems to just be a server issue. Might be related to iLexiconn/LLibrary#117

This is what the server spat out:
https://pastebin.com/TUvXWfML

This is what the log file says:
https://pastebin.com/Fz79az4S

Versions:
Minecraft 1.12.2
Forge 14.23.5.2796
LLibrary 1.7.17
Wings 1.1.2

Thanks for any insight you could offer as to what's happening!

hunger drain when flying with wings is a bit too fast

Just as the title, natural regeneration most quickly drains hunger, but wing-flying is the second.

There's no config options to change hunger drain per tick when flying.

It should may only a little faster than vanilla running/spriting, but not as fast as current "wings" version.

wings-1.1.6-1.12.2

Wings with Llibrary 1.7.17

This mod does not appear to be compatible with version 1.7.17 of llibrary on a forge server (it does work client side). If you do use the most up to date versions of these mods, your server will crash depending on what other mods are present (the list is quite long). Unfortunately, version 1.7.17 of llibrary is needed for any more up-to-date versions of forge. I hope this can be resolved soon.

I can get a lot more specific if needed, but the issue is VERY easy to recreate.

Suggestion and bug

Suggestion:

  • A bar of energy instead of consuming food to force the player to land.

  • An attack on the ground that repels the enemies without any damage with a flutter animation and may be another that attracts them.

  • take velocity on downhill.

  • on the ground a key to block the projectile like arrow with the wings or to reduce the damage and the cknockback.


Bug:

  • Disable sneaking on the fly because it creates a visual bug (only without Mo'Bends)
  • The Mending enchantment does not work when the wings are in the Baubles slot.

If you need help with the energy bar for example I have already made one for mana with a skill tree.

And finally I love your mod and I wait for the next.

Sincerely a French fan.

Exiting Flight Does Not Check For Space

Current version: 1.1.2 for Minecraft 1.12.2

Flight can be exited in a spot where the player doesn't actually have room to stand.

screenshot

Further more, this lack of space validation seems to cause the player bounding box to not update correctly too. Exiting flight below this block retained the flight bounding box.

screenshot1

Emerging from the blockspace restores the bounding box correctly.

screenshot2

Incompatibility with Galacticraft

If I have Galacticraft in it then what happens in the screenshot is shown when I take it out then does not happen then it's all normal

  • Forge Version = 1.12.2-forge1.12.2-14.23.5.2838

  • Wings Version = wings-1.1.4-1.12.2

  • Galacticraft Version = Core + Planets + MicdoodleCore

  • Core Version = GalacticraftCore-1.12.2-4.0.2.210

  • Planets Version = Galacticraft-Planets-1.12.2-4.0.2.210

  • MicdoodleCore Version = MicdoodleCore-1.12.2-4.0.2.210
    Results

  • mit Galacticraft = Player unter Cursor
    2019-05-31_12 27 24

  • ohne Galacticraft = Player befindet sich im Cursor
    2019-05-31_12 51 16

Player won't go into flying animation?

Not quite sure if this is a bug, or if I'm doing something wrong. Hey, it could even be a mod causing it to break, though I'm not really sure which outta my mods would be causing it...

As the title states, when I go into game and press R to start flying, the wings flap (and look beautiful, by the way) but my player just stays in a standing. It looks almost like a weird momentum-based creative flight. Otherwise the wings work completely fine, it's just my character model that doesn't go into that amazing flying animation that I saw in both your screenshots and in videos.

Am I missing a mod that allows me to do that? Or would a mod be conflicting? I can link my mod list if needed. I just would love for the animations to work correctly because this is a really nice and pretty flying mod to use.

[Suggestion] Option To Only Allow Flight In-Air

Currently, the hotkey can be used to trigger flight regardless of the environment. To me, this feels odd, as it allows you to lean forward and enter flight whilst, sat in a pool of water, or stood in a confined space with no room to physically move. To counteract this behaviour, an option could be added to require the player to be in the air (so out of liquid, and either jumping or falling). This solution isn't perfect, and I'd be happy to discuss other ways to combat this "issue".

Current version: 1.1.2 for Minecraft 1.12.2

[Suggestion]Wings consume minerals to repair themselves

While I am playing this mod (fantastic one among numerous flight mods), I found several slightly unreasonable things:

  1. Fairy dusts and amethysts are literally useless besides making wings (which consumes just a few of them), and those minerals just began piling up in the chests.
  2. Wings are very durable (even the easy ones last for a long long time).
  3. Flight drains hunger at a horrible rate.

So I consider it reasonable to decrease the wings' durability and the rate of exhaustion. Instead, the wings use those minerals to repair themselves automatically. I think this might make the mod have a better experience (just personal ideas).

Possible solutions:

I tried to fork it by myself, but encountered some issues about imports (failed at the beginning) due to the lack of java knowledge.
:(
But I think adding something like "search minerals in player's inventory if item damage is too high" in the item class which is triggered on update will work.

Update: (Checked some other issues and your replies)
Even not adjusting the rate of exhaustion (just make the wings less OP by letting them consume minerals during flight) is also good!

Update again: (Checked even earlier issues and understood the reason behind these questions)
Maybe this alteration can be put into config? Just to provide some welfare for miners. (The exhaustion mechanic seems to prefer farmers?)

Hope the mod will become better and better!

[Suggestion] Forge Functionality

Hello Wings devs.
I recommend that you switch to "recommended" forge compatibility because going to latest almost always ruins modpacks. Latest is very buggy.
Thanks!

[Suggestion] Config for Flight Speed

Would it be feasible to allow config setting flight speeds within a range? I am asking to see if we can lower the flight speed a bit for server lag issues.

Bug/Crash Wings seems to crash repetitively on single player and mostly servers.

Bug/Crash Wings seems to crash repetitively on single player and mostly servers.

I loaded up my world I made and suddenly the game starts crashing on me I played for a few hours yesterday no problem now it sometimes crashes on loading wings mod.

Some players of my modpack also have the same problem here are some crash logs all pointing to the same problem. of some mobends_wings part.

Wings 1.1.5 for Minecraft 1.12.2
MC 1.12.2
Forge 14.23.5.2838

https://pastebin.com/MXm76WCV
https://pastebin.com/GPuTviCX
https://pastebin.com/ymux3ma1
https://pastebin.com/21t46DUn
https://pastebin.com/FVzvEy6v
https://pastebin.com/FB3D2XN3

[Suggestion] Drinkable Bat Blood

Allow bat blood to be consumed by the player, possibly applying minor effects such as 10 seconds of weakness and 10 seconds of strength.

Seconding this, it would be nice to see support for Tough As Nails, restoring a small amount of hydration (possible 1/4th of what purified water restores?)

Current version: 1.1.2 for Minecraft 1.12.2

Suggestion [Feature] Drained EXP instead of Hunger

Love the the mod, much more enjoyable than elytra. It draining hunger on use is a good mechanic to tie it to for balance reasons. Personally using it myself, hunger becomes a lot less hard to manage later on when you acquire wings, so it feels less like an inconvenience using a powerful endgame item. Possible suggestion for an optional config, drain experience slowly when using it? That way it feels like a luxury to use it such as flying off cliffs or avoiding death, but not at a too fast rate that it becomes annoying to get exp. I suppose its not impossible to an option to change how fast/slow it decays like you did with hunger in the config. There's no real use of levels in minecraft except enchanting, so it would give the incentive to keep collecting exp above lvl 30 to stockpile a lot of time for using your wings, giving itself its own resource to manage at a slight detriment of the player.

If you don't like the scope of the idea, or it isn't worth time implementing it, then thanks for reading either way!

Suggestion

While holding shift when flying will make your character fly forward towards the horizons, this would help to navigate the lands by looking down without actually going down, as currently it is hard to look the lands below you as you have to fly down and fly back up again.

Animation Glitches when Flying not in 1st POV

2019-09-28_14 29 04
2019-09-28_14 36 15

Glitches when not in 1st POV and wings in Bauble chest slot:

  • TAN water bar has background darkened

  • When flying, no wings are present and you fly upside-down. You do, however, do the pose with the arms.

If you press R for controlled descent or just walk around, and not in 1st POV, everything but the TAN water bar is normal.

When in 1st POV, everything is fine (TAN water bar included). I haven't tested on a server with friends so don't know if it does animate properly but otherwise everything works fine.

I tried updating the library, Baubles, and Forge.

I'm new to modpacks so I'm embarrassed about how probably really messy this first modpack is and I don't even realize it.

I don't have mo'bends installed.

bug with thaumcraft armor

forge:14.23.5.2776
mods:
default
issue
2018-11-27_11 26 57
2018-11-27_11 27 21
2018-11-27_11 27 26
2018-11-27_11 27 46
Wings works fine with botania/astral sorcery's armors,but not thaumcraft's.

Initial suggestions for balancing.

Most beautiful and smooth flight animations I have ever seen, well done!

Good flight mechanics, but still needs balancing.
My initial suggestions:

  1. Vastly increase the default durability of wings and make flight consume a little extra hunger.
  2. Make players take severe damage from running into walls and things, just like with the elytra.

Crash When installed with Mod "ElecCore"

When I install this mod, it's library(LLibrary), and Eleccore together, the game crashed while initializing.
When I only install LLibrary and Eleccore, the game does not crash.
There seems to be a bug existing in mod Eleccore, but I still post this here so that you might have a chance of finding out what's going wrong and fix it.
(It seems that the conflict happens when the mod Eleccore is trying to register to FML)
The mod ElecCore is at this link: https://github.com/Elecs-Mods/ElecCore

The attachments are the crash report and the latest log.
latest.log
crash-2018-09-14_05.28.49-client.txt

Suggestion

It would be very appreciated if you could also have earlier versions of the mod (such as 1.7.10) because not that many mods are updated and i bet everyone would love to use it in their earlier version modpacks.Thanks

Fly key binding is not saved

wings-1.0.2-1.12.2.jar

Use controls menu to change Wings "Fly" key binding from R to some other key (eg: F)
Restart Minecraft
"Fly" is again bound to default R key

Expected: "Fly" is bound to F per user selection.

PLS HELP, Wings not rendering

Its highly unlikely you will be able to help me figure this out but it would be much appreciated.
with galaticraft installed wings no longer render and it is only the case when metamorph is installed. I have been doing some testing and running several different instances with mcedit and regular minecraft. Each have only these exact mods installed. I have been trying different versions and mod setups and config settings to no avail. $ reward if someone can help me figure this out (=.

minecraft version 1.12.2
metamorph version 1.18
mclib version 1.0.3
wings version 1.15
Galacticraft version:
GalacticraftCore-1.12.2-4.0.2.237
Galacticraft-Planets-1.12.2-4.0.2.237
MicdoodleCore-1.12.2-4.0.2.237
forge version: 14.23.5.2846

Little suggestions

  • The position of the arms: configurable. '-'

    • The default mode as currently, arm extended.
    • Animated mode: by default the arms are along the body, slightly apart, and are stretched forward if sprinting in flight.
  • A hover position.
    When we are flying, if we slow down by 100%, we hover, the character is standing in the air, the wings are orienting to place slightly higher. Arms and legs slightly apart.

  • Sounds for flapping wings, configurable on / off.

  • Tricks :D double tap a direction to roll in the air.

  • A keybind to flap wings like an emote ^^

Valkyrien Warfare incompatibility

After careful testing, i discovered that Wings and Valkyrien Warfare cause a pre-loading crash. There is no crash report, the game window doesn't open and this shows up on the latest log:

12:28:20 mixin main Mixin prepare failed preparing entity.MixinEntityIntrinsic in mixins.valkyrienwarfare.json: org.spongepowered.asm.mixin.transformer.throwables.MixinTargetAlreadyLoadedException Critical problem: mixins.valkyrienwarfare.json:entity.MixinEntityIntrinsic target net.minecraft.entity.Entity was already transformed.
org.spongepowered.asm.mixin.transformer.throwables.MixinTargetAlreadyLoadedException: Critical problem: mixins.valkyrienwarfare.json:entity.MixinEntityIntrinsic target net.minecraft.entity.Entity was already transformed.
at org.spongepowered.asm.mixin.transformer.MixinInfo.readTargets(MixinInfo.java:885)
at org.spongepowered.asm.mixin.transformer.MixinInfo.readTargetClasses(MixinInfo.java:856)
(...)

below goes the full log.
latest.log

i've also warned the creator of Valkyrien Warfare of this issue.

Problem with spongeforge

Hi ^^
Super mod, I am in total admiration +.+
but.. little problem..
Here is what happens when the mod is used on a server forge 2705, with the sponge currently recommended. ( spongeforge-1.12.2-2705-7.1.0-BETA-3361 )

latest.log

This doesn't happen when there isn't the Sponge, but I need it.. so.. solution ?

Suggestion: Some Options/Config Settings and Mod compats.

I really like this mod!
The animations are nice and the execution is pretty bug free as far as I tested. And I am glad it’s a way better flight system than simply giving creative flight or hovering jetpacks.

Seeing as you stated “suggestions are appreciated” I tough I could give a few ideas and feedback.

I have a variety of ideas you could try adding if they are to your liking and they are within your abilities. Most of them would be Config options so people can adjust the way they want to use the wings in their play style or Modpack. Making this Beautiful mod also highly configurable!

I saw that you are already able to adjust things like hunger drain for landing or during flight separately and even to set the durability to unbreakable so I thought you would be able to ad such options to the configs.

Feedback on current System and improvement ideas:

Maybe adding an option to double jump to start the flight Mode would be nice since in many packs there are many key bindings that are already taken and since Double tap on spacebar is mostly used for flight type things it also mostly left free for it. R default is for example used for many sorting mods or so of course you are already able to adjust the key binding in the config so it is adjustable but adding the double tap option as well would be nice, especially with the next idea I have.

Adding a jump start! Currently the player when pressing the fly button starts to lay down flat on the ground until the wings unfold and he starts lifting up into the sky. This is kinda funny looking it would make more sense to first having the motion be slowly lifting upwards or having a Jump build in to the lift of animation so the player doesn’t go papermode down to the ground starting his flight like a penguin sliding on his belly (penguins can’t fly I know it’s not the best example XD)
I tested it by setting the key bind to spacebar and it works nice you get a nice liftoff animation as well instead of suddenly falling flat to the ground but sadly it overwrites your jump as it trigger instantly the flight if you had to double tap it you could still jump normally and have flight on demand.

The fluttery animation of the Fairy/Pixy type wings in comparison with the Big Bulky Wings seems a bit lacking. Also they seem to hover a bit too far away from the Player model in 3rd person view. Maybe making the Wing model of these have at least one pixel more thickness moving the render a tiny bit closer to the back of the player and adding colored particles to them would make them be more appreciated by Fairy loving people. The Particles could be little slime drippings for the slime wings or Colored Dust trails for the other ones. The Big Bulky wings are already god as they are they have a very fluid animation and using them gives great immersion of flight they don’t need any particles added or so.

It would also be nice to see the sneaking in flight make it a fast gliding forward instead of a buggy sneaking animation XD

Config Settings:

  1. Adding in explanation lines to the config files so that above each setting a small line is that explains what it does like “setting durability to 0 makes the Wings Unbreakable” or “setting this value to 0.001 means it adds X amounts of hunger exhaustion per tick” and so on. I could only find out what the settings did when editing the config in game (as a Modpack maker I am more used to adjusting stuff directly in the config files as many mods don’t even have in game changeable settings so this would be a nice thing to ad).

  2. An Option to change the bauble Slot they are placed in (not affecting the render so they don’t actually move upwards on the body XD) This option would enable it to for example allow wing slot to be adjusted for Modpacks for example having a backpack in the back slot and being able to equip the wings as a charm. (don’t know how rendering this would work if there was something like a backpack rendered as well but the backpack was just an example there are so many things that are forced to use specific bauble slots and I think being able to adjust is always nice)

  3. A simple config option to Prevent Combat when in flight mode for some people who want to balance flight as a travel and flight as a combat mechanic.

  4. A config option to make flight a time based system like say you can set how many ticks/seconds you are allowed to fly until you are forced to land starting a separate timer that says you can’t fly until your wings aren’t exhausted anymore (basically making them recharge a multipliable amount of the time they spend in flight). (Would be a good system for modpacks that use spice of life or other mods that make hunger work strangely) --- This could also open up the option to add a penalty for taking damage during flight basically reducing the remaining flight time by a settable amount!

  5. Or as a separate idea to the number 3. A timer that lets you fly without draining hunger and once its run out you drastically starve or even take direct dmg (still with the same recharge timer so you can’t just land for one second to reset said timer) etc.

Mod compatibility:

  1. Compatibility with the Botania Mod: The Botania Mod has some pretty nice wings they may give creative flight but have a different resource system namely Mana and a Flight bar timer. I wanted to ask if it’s possible that when botania is installed the Wings can also fly with Mana instead of hunger. This way people could adjust the crafting recipes to fit the mods together and make them an option, or if it’s possible to overwrite the Botania Creative flight Flügeltiara to use the same flight mechanic and animation as yours (by overwriting the model or so)?

PS: If you made it to this point you either skipped it all or you actually read trough this wall of text! Anyway thx for listening if you did read, and I hope some ideas are to your liking!

GZ
SirAron

JEI Dependency

Hello o/

Would you consider making JEI a soft dependency? I don't think leaving out JEI would cause issues.
In addition, Wings does not accept the latest JEI version.

No Textures?

Okay when im using the wings it flies obviously but theres no textures?

2018-10-28_10 59 38

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.