patrikholcak / react-touchbar-electron Goto Github PK

🚨 The automated release from the master branch failed. 🚨

I recommend you give this issue a high priority, so other packages depending on you could benefit from your bug fixes and new features.

You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can resolve this 💪.

Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.

Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the master branch. You can also manually restart the failed CI job that runs semantic-release.

If you are not sure how to resolve this, here is some links that can help you:

• Usage documentation
• Frequently Asked Questions
• Support channels

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.

No npm token specified.

An npm token must be created and set in the NPM_TOKEN environment variable on your CI environment.

Please make sure to create an npm token and to set it in the NPM_TOKEN environment variable on your CI environment. The token must allow to publish to the registry https://registry.npmjs.org/.

Good luck with your project ✨

Your semantic-release bot 📦🚀

I now found out, that nodeIntegration: true can be disabled by using a preload script:

const { ipcRenderer, contextBridge } = require("electron");

const electron = {
  ipcRenderer: {
    send(channel, ...args) {
      ipcRenderer.send(channel, ...args);
    },
    on(channel, listener) {
      ipcRenderer.on(channel, listener);
      return this;
    },
    removeListener(channel, listener) {
      ipcRenderer.removeListener(channel, listener);
      return this;
    },
  },
};

contextBridge.exposeInMainWorld("require", (name) => {
  if (name === "electron") {
    return electron;
  }
});

The only things that are left now are the following three things:

1. the touchbar could eventually be undefined, so I suggest the following fix in:

   react-touchbar-electron/src/decorate-window.ts

   Line 207 in 2b05716

   const item = touchBarInstances[payload.parent].items.find(

   ipcMain.on(IpcEvent.updateitem, (_event, payload: UpdatePayload) => {
   -   const item = touchBarInstances[payload.parent].items.find(
   +   const item = touchBarInstances[payload.parent]?.items.find(
       (item) => item.id === payload.id
   );

   

2. The library could not be imported via webpack due to the following error, so I suggest changing the tsconfig.json to the following:
   

   {
     "compilerOptions": {
     "outDir": "dist",
     "moduleResolution": "node",
   -  "target": "ESNext",
   +  "target": "ES2019",
     "jsx": "react",
     "lib": ["dom", "dom.iterable", "esnext"],
     "skipLibCheck": false,
     "strict": true,
     "forceConsistentCasingInFileNames": true,
       "declaration": true
     },
     "include": ["./src"]
   }

3. Add a option to completely disable the ipc communication instead of mocking it, so this could be also used in the browser without any annoying console debug messages.