Comments (5)
It looks like the detection of the Python version is not present in the code anymore.
In addition, by using a Python package, setup.cfg
enforces Python >= 3.6
We could close this issue.
from buildh.
Done in 6bc8c68! Question to @HubLot and @pierrepo, in this line I use the Exception UserWarning. Do you think it is the most appropriate?
from buildh.
UserWarning
seems OK to me.
But i'll advise to check strickly for Python >= 3.6 since f-string are a really nice feature.
from buildh.
Seems good to me too.
But do you have a reason to restrict to Python >= 3.7 (or even 3.6) ? 3.5 is still maintained for a year for example (https://devguide.python.org/#branchstatus)
By the way, @patrickfuchs you removed the '#' in the first line of the script so it doesn't work anymore :D :
Line 1 in 6bc8c68
from buildh.
Thanks guys for your answer 😄 ! For the version, it looks like 3.6 could be a good compromise, this could allow us to use f-strings indeed. Thanks also @HubLot for reporting the mistake on line 1, I was too tired yeasterday evening 😉.
from buildh.
Related Issues (20)
- Test: new release and automatic package deployment HOT 11
- Update documentation regarding -v option
- Automate archiving in Software Heritage upon release
- Update MDAnalysis to 1.1.1 HOT 10
- Restrict BuildH for Python >= 3.6 and <= 3.8 HOT 3
- Doc no longer compiles
- [Request] Add documentation for building from source with minimal dependencies HOT 4
- Fixing box dimensions and trajectory output with Hs HOT 4
- Which three things? (docs) HOT 2
- Contributing credit? HOT 2
- Which OSs are supported? HOT 3
- Minor wording or grammar nitpicks with paper HOT 2
- Improvements on API documentation HOT 2
- Python versions and dependencies. HOT 3
- Test and update to MDAnalysis 2.0.0 HOT 7
- Update swh link to the new version 1.6.0
- CH3 groups HOT 8
- Beta hydrogens in PS HOT 2
- Missing carbon atoms HOT 5
- Latex formulas are not rendered correctly on readthedoc HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from buildh.