particular / particulartemplates

dotnet-new templates for the Particular Service Platform

dotnet new templates for NServiceBus.

Documentation

• NServiceBus Windows Service
• ServiceControl Transport Adapter Windows Service
• NServiceBus Docker Container

Testing locally

After building the project, the templates can be installed using the following:

dotnet new -u ParticularTemplates
dotnet new -i <path to project>\nugets\ParticularTemplates.<version>.nupkg

particulartemplates's Issues

Report CI status back to pull requests

Currently, not happening. E.g. the build for #4 is failing.

/cc @Particular/host-maintainers @Particular/deployment-maintainers

Use Microsoft-provided template package validation when available

Describe the suggested improvement

The documentation for Authoring Tools mentions a package Microsoft.TemplateEngine.Authoring.Tasks that currently can only be used for localization of strings in a template, but in the future should include a Validate task for validating template packages.

See Authoring tools: templates & template packages validation.

We already build the templates and run approval tests on the template output, but once these tools are available it may provide ways to validate that the ide.host.json and dotnetcli.host.json files that are currently hard to test.

Additional Context

No response

Dependabot couldn't reach https://www.myget.org/F/particular/api/v3/index.json as it timed out

Dependabot couldn't reach https://www.myget.org/F/particular/api/v3/index.json as it timed out.

Is https://www.myget.org/F/particular/api/v3/index.json accessible over the internet? If it is then this may be a transitory issue and can be ignored - Dependabot will close it on its next successful update run.

View the update logs.

Update the templates to latest .NET and latest NSB

Describe the suggested improvement

At the moment, the templates target .NET 4.7.2 and RC's of NServiceBus. So we need two things:

• Update the templates to the latest of Core and .NET
• Update our processes to make sure the templates don't fall through the cracks when we update NServiceBus and .NET in the future

Call to Host.Stop could lead to a `NullReferenceException`

https://github.com/Particular/dotnetTemplates/blob/e16ef9ced20b895a5b2a357801a33d57b0b68b93/src/Templates/NServiceBusWindowsService/Host.cs#L64

The above referenced line could lead to a null reference exception inside the .NET code that is taking care of the await. The used ?. operator could return null which will cause the issue.

My proposed solution would be to replace this line with
await (this.endpoint?.Stop() ?? Task.CompletedTask);
I'm assuming that Task.CompletedTask is available in the lowest supported version for the dotnet new templates.

I'm happy to provide the pull request to solve this, if the proposed solution is in your interest

Windows Service via NServiceBus.Extensions.Hosting/BackgroundService

Is it supported to use NServiceBus.Extension.Hosting/BackgroundService for a windows service endpoint? Is there any special reason that the dotnet templates aren't using these?

Thanks