Coder Social home page Coder Social logo

Comments (8)

kennylavender avatar kennylavender commented on July 18, 2024 2

@ericelliott I am sure it will lol, Il create some unit tests to make sure it works & keeps working 👍

from react-feature-toggles.

kennylavender avatar kennylavender commented on July 18, 2024 1

@GodOfGrandeur thanks for the reminder, just created #211

from react-feature-toggles.

ericelliott avatar ericelliott commented on July 18, 2024

I suppose we could use this, instead:

// Tiny, recursive autocurry
const curry = (
  f, arr = []
) => (...args) => (
  a => a.length === f.length ?
    f(...a) :
    curry(f, a)
)([...arr, ...args]);

But importing from lodash/fp/curry should not cause that kind of bloat. That's worth investigating deeper, and (if true) reporting to Lodash.

What are you using to bundle?

from react-feature-toggles.

GodOfGrandeur avatar GodOfGrandeur commented on July 18, 2024

There's lots of blog posts about how lodash has massive bundle sizes. I'm not sure whats happening in this case but think the curry module is just badly packaged. I've attached a screenshot with it added to a standard create-react-app and source-map-explorer package added do the analysing.

Update: Seems to a issue with using the /fp/ version of the packages specifically.

image

from react-feature-toggles.

kennylavender avatar kennylavender commented on July 18, 2024

I like the idea of using our own curry function so that we can avoid adding webpack/rollup. Looks like we are only using lodash in that one spot as well, so we can also remove lodash as a dependency.

from react-feature-toggles.

ericelliott avatar ericelliott commented on July 18, 2024

@kennylavender LGTM. Does my autocurry spell work? It's very tiny. =)

from react-feature-toggles.

GodOfGrandeur avatar GodOfGrandeur commented on July 18, 2024

@kennylavender thanks for looking at this, have you been able to get anywhere with this yet?

from react-feature-toggles.

kennylavender avatar kennylavender commented on July 18, 2024

Published version 2.1.1 after #211

Bundle phobia now works:
https://bundlephobia.com/result?p=@paralleldrive/[email protected]

Size back down to 3.1kb from 47.36kb 👍

from react-feature-toggles.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.