Comments (5)
This code works for me:
const StyledDiv = () => <div>Works!</div>;
const ComponentOrNull = configureFeature(() => null)('demo')(StyledDiv);
export const Copyright = () => (
<FeatureToggles features={[]}>
<ComponentOrNull />
</FeatureToggles>
);
The only difference is the definition of StyledDiv
. Looks like the problem is that styled.div
is not returning a component?
from react-feature-toggles.
@ericelliott thanks for your reply!
First of all the problem must be somewhere between styled-components
and feature toggles. StyledDiv
returns a component as we definitely expect. Please try out styled-components
and then if you don't get this warning I will create a reproducible repo. Thanks a lot!
from react-feature-toggles.
Hello @karolisgrinkevicius,
I tried adjusting the Feature components propTypes to see if adding a node or element type might remove the warning, but neither of those removed the warning. Interestingly PropTypes.object does get rid of the warning but we don't want to accept just any object so I think its best we avoid making that change.
I dug a bit deeper and it seems that styled-components returns a forwardRef object, but the prop-types package doesnt have a type that works for forwardRefs at the moment, here is the related issue: facebook/prop-types#200
Looks like React mentions that forwardRefs are a breaking change of types: https://reactjs.org/docs/forwarding-refs.html#note-for-component-library-maintainers
from react-feature-toggles.
Hi @kennylavender. Thanks for your response. So we just have to wait while prop-types
problems are being fixed?
from react-feature-toggles.
Your welcome. Yup, if/when they push a solution we can look into it again. Closing for now.
from react-feature-toggles.
Related Issues (20)
- Update createRouteMiddlware HOT 1
- Use feature-toggles package HOT 1
- Move unit tests right next to the file its testing.
- Relocate integration tests
- New Examples
- Feature Typing Issue
- Fix typings
- Feature Toggle UI HOT 2
- Carry over `ft` query param while navigating HOT 1
- Document that there is no route change watcher. HOT 1
- getCurrentActiveFeatureNames is a valid method? HOT 2
- Need to update dependencies HOT 1
- Create next example
- Create next specific code HOT 1
- Massive Bundle Size HOT 8
- Action Required: Fix Renovate Configuration
- How to write tests for components using Feature HOT 1
- Typing error for typescript HOT 2
- Dependency Dashboard
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-feature-toggles.