paradoxxxzero / atom-rainbow-delimiters Goto Github PK

Characters immediately adjacent to a rainbow element often require multiple mouse clicks in order to move the cursor adjacent to a rainbow element.

Observed behavior:

• Clicking next to a rainbow element is often "ignored" the first 1-3 attempts.
• Clicking next to a rainbow highlighted element can be ignored indefinitely.
• Drag selecting next to an element is often ignored (Even if cursor is already there.)
• Navigating cursor with the keyboard always works.
• Disabling rainbow elements immediately fixes the issues.

Atom    : 1.22.0
Electron: 1.6.15
Chrome  : 56.0.2924.87
Node    : 7.4.0

When I'm using it, there is a small white pixels around the delimiters

Like this!

It can be more visible depending on the fonts

After updating to atom 1.21, parentheses and brackets are no longer highlighted. Everything still works in version 1.20. It's almost like the colored brackets and parentheses are 'behind' a set of gray ones. I attached a screenshot of a set of zoomed in parentheses from version 1.21.

This one just started showing up for me
[Enter steps to reproduce:]

1. ...
2. ...

Atom: 1.36.1 x64
Electron: 2.0.18
OS: Mac OS X 10.14.5
Thrown From: rainbow-delimiters package 2.1.2

Stack Trace

Uncaught Error: Cannot decorate a destroyed marker

At /Applications/Atom.app/Contents/Resources/app/static/<embedded>:11

Error: Cannot decorate a destroyed marker
    at DecorationManager.decorateMarker (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:11:519078)
    at TextEditor.decorateMarker (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:11:27540)
    at RainbowDelimitersView.add (/packages/rainbow-delimiters/lib/rainbow-delimiters-view.js:21:12)
    at /packages/rainbow-delimiters/lib/rainbow-delimiters.js:86:19
    at TextBuffer.scanInRange (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:11:494333)
    at TextBuffer.backwardsScanInRange (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:11:494525)
    at TextEditor.backwardsScanInBufferRange (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:11:41013)
    at Object._highlight (/packages/rainbow-delimiters/lib/rainbow-delimiters.js:65:12)
    at /packages/rainbow-delimiters/lib/rainbow-delimiters.js:49:42

Commands

Non-Core Packages

aligner 1.2.4 
aligner-javascript 1.3.0 
atom-beautify 0.33.4 
atom-yamljson 0.2.4 
auto-update-packages 1.0.1 
ayu-mirage-atom-syntax 1.1.0 
birds-syntax 0.2.1 
busy-signal 2.0.1 
colorful-dark-syntax 0.4.1 
cream-soda-ui 0.2.2 
docblockr 0.13.7 
double-tag 1.7.0 
earthsung-syntax-atom 2.0.0 
emmet 2.4.3 
emmet-snippets-compatibility-but-less-extreme 1.1.0 
fancy-bracket-matcher 2.1.0 
file-icons 2.1.32 
gruvbox-dark-ui 1.1.0 
gruvbox-plus-syntax 1.3.1 
html-wrapper 0.2.0 
indent-guide-improved 1.4.13 
intentions 1.1.5 
line-number-color 0.2.0 
linter 2.3.0 
linter-htmlhint 1.6.1 
linter-js-yaml 1.4.6 
linter-jshint 3.1.16 
linter-ui-default 1.7.1 
markdown-to-html 0.5.0 
mesa-syntax 0.4.2 
minimap 4.29.9 
minimap-lens 0.2.0 
minimap-pigments 0.2.2 
misc-text-util 0.2.0 
multi-cursor 2.1.5 
pear-dark-syntax 1.0.9 
pigments 0.40.2 
predawn-syntax 1.0.4 
pubster-syntax 3.0.2 
r-darcula-syntax 0.2.0 
rain-syntax 2.1.2 
rainbow-delimiters 2.1.2 
red-wavy-underline 0.3.3 
rocket-dark-syntax 1.0.0 
slime 2.4.0 
xers-syntax 1.1.0 
xers-ui 1.2.0 

Hi,

If my text-cursor is placed such that some delimiter is coloured, then I cannot click the text there to move the text-cursor to that position. The effected area is small, but large enough to be slightly annoying.
For example, if "(([{" is nicely rainbow-highlighted, I cannot put my text-cursor in between any of the delimiters but must press outside of the highlighted area ( for "(([{sa" I can press between "s" and "a", but not closer to the delimiters) and move in with keyboard keys.

This has been tested on atom installed via debian's and gentoo's package manager.

I have noticed an issue where the rainbow delimiters remain visible when text is scrolled off the sides of the gutter. Like so

I have forked the repo and if I come up with a solution I will make a PR. But for now I figured to create an issue documenting this

[Enter steps to reproduce:]

1. Install package
2. Error will be shown after install and each subsequent editor restart.

Seems like themes have to implement a syntax-variables.less. My thought is that this might not be a typical variable that themes have to implement? None of mine have it at least, but I really have no idea which ones are typical/ required :-)

Atom: 1.14.0 x64
Electron: 1.3.13
OS: Mac OS X 10.11.6
Thrown From: rainbow-delimiters package 1.2.0

Stack Trace

Failed to load the rainbow-delimiters package

At variable @syntax-accent is undefined in /Users/ross/.atom/packages/rainbow-delimiters/styles/rainbow-delimiters.less:19:0

LessError: variable @syntax-accent is undefined
  at /packages/rainbow-delimiters/styles/rainbow-delimiters.less:19:0

Commands

Non-Core Packages

blame 0.10.2 
browser-refresh 0.9.0 
dash 1.7.0 
editorconfig 2.2.0 
fonts 2.0.0 
language-elixir 0.16.0 
language-haml 0.24.1 
language-r 0.4.1 
linter 1.11.21 
linter-coffeelint 1.2.1 
linter-eslint 8.1.0 
linter-rubocop 0.5.3 
markdown-toc 0.4.2 
material 2.2.0 
open-in-browser 0.4.7 
rails-snippets 2.11.0 
rails-transporter 1.6.5 
railscast-theme 0.3.0 
rainbow-delimiters 1.2.0 
react 0.16.2 
sort-lines 0.14.0 
tasks 2.6.6 
vim-mode 0.66.0 

I'm not sure whether this is an issue with the vim-mode-plus package or rainbow-delimiters, but when using both packages the cursor moves really slowly when selecting text in visual mode.

To reproduce:

1. install vim-mode-plus and rainbow-delimiters
2. put the cursor somewhere and press v to go into select mode
3. move the cursor left or right by holding down the arrow keys or h and l keys.

Thanks for this awesome package, it's really a nice way to display paren matching.