paolobrasolin / setup-texlive-action Goto Github PK

Not sure why one would need them, but it should be easily doable:

• installation-path is already customizable,
• appending the binary path to the system path should be turned off in case of multiple installations in order to avoid conflicts,
• the binary path should be an output to facilitate calling executables from specific installations.

This should be done ASAP as it's already mentioned in

Is there an existing issue for this?

• I have searched the existing issues

Original problem

The cache-key is generated by profile-path and packages-path.
When these are not changed the texlive version is fixed.

On a long term this can break texlive (tlmgr) with the following error

tlmgr itself needs to be updated.
Please do this via either
  tlmgr update --self
or by getting the latest updater for Unix-ish systems:
  https://mirror.ctan.org/systems/texlive/tlnet/update-tlmgr-latest.sh
and/or Windows systems:
  https://mirror.ctan.org/systems/texlive/tlnet/update-tlmgr-latest.exe
Then continue with other updates as usual.
===============================================================================
tlmgr: Terminating; please see warning above!
tlmgr: package repository https://ctan.mirrors.hoobly.com/systems/texlive/tlnet (verified)

Proposed solution

The cache-key should consider the version or hash of the texlive installer.
As not updating will break the github action it's not needed to have this configurable.

Alternatives considered

One could generate the hash keys in the repos itself and pass it to this action or deactivate caching completely.
I think we should prevent people from deactivationg caches so I think this should be a package feature.

Additional context

No response

Is there an existing issue for this?

• I have searched the existing issues

Current behaviour

It seems that all lines in the package files are being installed, raising errors on commented ones.

Expected behaviour

Comments should be skipped.

Steps to reproduce

No response

Additional context

Apparently I forgot a grep flag anche the pattern is being used literally.