paolobarbolini / libraw-rs Goto Github PK

Hello!

I've recently tried to implement the Colordata struct (corresponding to libraw_colordata_t), and I had what I would call a "good idea".

Right now we form the Sizes struct (our libraw_image_sizes_t) by copying all of the structs members individually. That's a lot of typing. What I ended up doing was removing sizes.rs, replacing it's pub use in lib.rs with pub use libraw_sys::libraw_image_sizes_t as Sizes; and forming it in rawimage.rs by cloning the struct, unsafe { (*self.processor.inner).sizes }.clone().

I think this is a sane way to not have to type out all the colordata members, but maybe there's some giant issue I'm missing.

Do you think this is okay to do? All the tests passed and my project that uses libraw-rs worked perfectly fine.

(I can make a PR with relevant changes if my blabbering above didn't make much sense.)

Currently compiling on Windows (at least on CI) fails.

This is not a priority for me, since I'm not using this on Windows. I also don't have a Windows machine, so it's not that easy for me to look into, but it would be great to support all platforms.

By commenting out these likes

When working on this locally remember to clone submodules too

https://www.libraw.org/docs/API-datastruct.html#libraw_thumbnail_t

I've implemented functionality for this in my own fork (though it wouldn't be possible to merge it directly, since I've updated to the latest version of libraw for CR3 support), but the implementation could be reviewed.

https://www.libraw.org/docs/API-datastruct.html#libraw_imgother_t

Here, I think the impl would expose a number of getter methods, including for libraw_gps_info_t - possibly, in a more descriptive fashion than libraw does by default (gps timestamp might be hour, min, sec):

  typedef struct
  {
    float latitude[3];     /* Deg,min,sec */
    float longitude[3];    /* Deg,min,sec */
    float gpstimestamp[3]; /* Deg,min,sec */
    float altitude;
    char  altref, latref, longref, gpsstatus;
    char  gpsparsed;
  } libraw_gps_info_t;

I would be happy to implement this functionality as well, but wanted to ask if it would be useful to provide support for Rust libraries for timestamps or similar fields.