Comments (5)
Thanks for the report. Although I can reproduce this issue I don't have a full picture of the way it should be fixed.
So if you have instance of non-static class - you get it via AdviceArgumentSource.Instance
But What is supposed to be returned in case of static class? Null? Exception?
typeof(non-static-class) would a bit inconsistent here. wouldn't it?
Any thoughts ?
from aspect-injector.
I think in static case Instance must return null, not Exception. But in this case too little information about static method. So in my opinion there is two options:
1. Add new AdviceArgumentSource property, e.g. TargetMethod, with MathodBase (or MethodInfo) type. If aspect marked with InjectionTargets.Method (and may be InjectionTargets.Constructor) - fill this property. In another InjectionTargets - this property is null.
2. Replace AdviceArgumentSource.TargetName to AdviceArgumentSource.MemberInfo with MemberInfo type. In aspect body MemberInfo can be casted to Methodinfo or PropertyInfo according InjectionTargets. Removed TargetName can be getted from MemberInfo.
from aspect-injector.
The point is that retrieving MemberInfo has huge performance impact because of runtime reflection. And TargetName is well known in compile time. May be we could leave both TargetName and TargetMember. So in case of property TargetName would be "SomeProperty" and TargetMember would be memberinfo of set_SomeProperty.
Though there is one requirement - stick with portable subset of .net
from aspect-injector.
Fixed in 0.9.44.
I made it return null when member is static and instance is requested.
I also added new AdviceArgumentSource.Type so can access target type now. I guess you can handle retrieving member-infos with AdviceArgumentSource.Type + AdviceArgumentSource.TargetName for now.
I'll also create an improvement issue on backlog about something like AdviceArgumentSource.TargetMember. I hope we will find a way to make it fast and efficient.
from aspect-injector.
Very big thanks!!! Now this project completely satisfied my requirements )
from aspect-injector.
Related Issues (20)
- Aspect Injector processing has failed (v2.8.0), Mono.Cecil.Cil.SymbolsNotFoundException HOT 9
- Multiple Same Validator Aspect On MethodFeature Can Not Wroking HOT 2
- System.NotSupportedException Mac M1 Mono HOT 3
- Feature: Provide debug symbols with NuGet package HOT 2
- Feature: Replace object[0] to Array.Empty<object> HOT 1
- Feature: Can cache Argument(Source.*) any input argument by static field? HOT 1
- Lack of M1 support when rosetta isn't installed HOT 14
- Unsupported language/version ? HOT 1
- Feature: Why `GetInstance` method for Factory should be static? HOT 3
- Local variables in sync methods are not visible in the VS debugger HOT 13
- Feature: Attribute Multicasting HOT 1
- [2.8.2][macOS] error AI_FAIL: Aspect Injector processing has failed HOT 27
- In a Advice method with Kind.Before and Target.Constructor, accessing mixed-in properties injected into a class containing an explicit constructor causes NullReferenceError. HOT 4
- Feature: Make `[assembly: Attribute]` work with virtual methods that don't have an override HOT 2
- Feature: Clean Cache
- error AI_ERR0: Processing failure: System.ObjectDisposedException: Cannot access a closed file.
- Failed to resolve assembly: 'mscorlib, Version=4.0.0.0
- AspectInjector|2.8.1 : error AI_ERR0: Processing failure: System.NotSupportedException: Arg_NotSupportedException
- Feature: Extend Universal attributes to support async aspects HOT 6
- System.InvalidOperationException: Aspect doesn't have global singleton injected
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aspect-injector.