Coder Social home page Coder Social logo

Comments (6)

fcastells avatar fcastells commented on July 18, 2024 1

Hi, I'm already using this on my project actually (by copying the code for now). My use case is as follows: I have a test suite using Playwright for front-end testing. Each test is divided into steps. What I wanted is to automatically take a screenshot after each step, so I created an aspect that implements OnAfter and OnException, gets the instance, gets the page object from it and then needs to call await page.ScreenshotAsync(). Initially, I did page.ScreenshotAsync().GetAwaiter().GetResult(), but that's not the right way of doing it.

I agree with you that having only the async versions is the right way, but I didn't want to make a breaking change. This is up to you, but maybe you could mark the synchronous versions as obsolete and remove them in a future update, to give time to people to migrate the code.

from aspect-injector.

pamidur avatar pamidur commented on July 18, 2024

Hi, I've seen your PR. It passes all the tests, but before I merge it. Could you please give me an example on how do you like to use those methods?

I'm just not sure if having two set of methods there is justified. Maybe one set of methods (async only) is enough.

from aspect-injector.

pamidur avatar pamidur commented on July 18, 2024

Thank you for clarification. I'll need yet another day to digest this PR.

from aspect-injector.

fcastells avatar fcastells commented on July 18, 2024

No worries. Let me know if you need further clarification or changes.

from aspect-injector.

fcastells avatar fcastells commented on July 18, 2024

Following up on this. Let me know if I can clarify or improve anything. Thanks.

from aspect-injector.

kyro95 avatar kyro95 commented on July 18, 2024

Hi there, when the merge of the code is gonna issue? I need async aspects as well

from aspect-injector.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.