Comments (6)
Hi, I'm already using this on my project actually (by copying the code for now). My use case is as follows: I have a test suite using Playwright for front-end testing. Each test is divided into steps. What I wanted is to automatically take a screenshot after each step, so I created an aspect that implements OnAfter and OnException, gets the instance, gets the page object from it and then needs to call await page.ScreenshotAsync()
. Initially, I did page.ScreenshotAsync().GetAwaiter().GetResult()
, but that's not the right way of doing it.
I agree with you that having only the async versions is the right way, but I didn't want to make a breaking change. This is up to you, but maybe you could mark the synchronous versions as obsolete and remove them in a future update, to give time to people to migrate the code.
from aspect-injector.
Hi, I've seen your PR. It passes all the tests, but before I merge it. Could you please give me an example on how do you like to use those methods?
I'm just not sure if having two set of methods there is justified. Maybe one set of methods (async only) is enough.
from aspect-injector.
Thank you for clarification. I'll need yet another day to digest this PR.
from aspect-injector.
No worries. Let me know if you need further clarification or changes.
from aspect-injector.
Following up on this. Let me know if I can clarify or improve anything. Thanks.
from aspect-injector.
Hi there, when the merge of the code is gonna issue? I need async aspects as well
from aspect-injector.
Related Issues (20)
- Aspect Injector processing has failed (v2.8.0), Mono.Cecil.Cil.SymbolsNotFoundException HOT 9
- Multiple Same Validator Aspect On MethodFeature Can Not Wroking HOT 2
- System.NotSupportedException Mac M1 Mono HOT 3
- Feature: Provide debug symbols with NuGet package HOT 2
- Feature: Replace object[0] to Array.Empty<object> HOT 1
- Feature: Can cache Argument(Source.*) any input argument by static field? HOT 1
- Lack of M1 support when rosetta isn't installed HOT 14
- Unsupported language/version ? HOT 1
- Feature: Why `GetInstance` method for Factory should be static? HOT 3
- Local variables in sync methods are not visible in the VS debugger HOT 13
- Feature: Attribute Multicasting HOT 1
- [2.8.2][macOS] error AI_FAIL: Aspect Injector processing has failed HOT 27
- In a Advice method with Kind.Before and Target.Constructor, accessing mixed-in properties injected into a class containing an explicit constructor causes NullReferenceError. HOT 4
- Feature: Make `[assembly: Attribute]` work with virtual methods that don't have an override HOT 2
- Feature: Clean Cache
- error AI_ERR0: Processing failure: System.ObjectDisposedException: Cannot access a closed file.
- Failed to resolve assembly: 'mscorlib, Version=4.0.0.0
- AspectInjector|2.8.1 : error AI_ERR0: Processing failure: System.NotSupportedException: Arg_NotSupportedException
- System.InvalidOperationException: Aspect doesn't have global singleton injected
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aspect-injector.