Support of Argument(Source) in ctor or AspectFactoryAttribute of aspect about aspect-injector

[deresh-andrew]

P.S. This is very nice project, I'm really fond of it. Free PostSharp alternative) I don't get why there are so many neutral or negative comments on http://habrahabr.ru/post/246469/

[YuriyIvon]

Thank you for the feedback!

As for the "instance" source - it should work everywhere. In our tests we have the following:

    internal class AdviceInjectionBeforeTests_BeforeConstructorAspect
    {
        [Advice(InjectionPoints.Before, InjectionTargets.Constructor)]
        public void BeforeConstructor([AdviceArgument(AdviceArgumentSource.Instance)] object instance)
        {
            if (instance != null)
                Checker.Passed = true;
        }
    }

If you have any issues with passing the instance to a constructor - please give as a code sample, we will check.

[pamidur]

Yuriy, I guess that Andrew meant that if we have a advice per instance there is no point to pass that instance every time injected method called. He suggests to have a ability to get the instance in advice's constructor. Which could be done by changing AspectFactoryAttribute or allowing ArgumentSource in advice's constructor.

[deresh-andrew]

Thanks for yours replies. @pamidur - that is exactly my point. If Aspect is applied to the property (in case of INPC), not class, [Advice(InjectionPoints.Before, InjectionTargets.Constructor)] is not called. As an alternative I can suggest call [Advice(InjectionPoints.Before, InjectionTargets.Constructor)] when non-class aspect (e.g. InjectionTargets.Setter) is applied.
Sample class when [Advice(InjectionPoints.Before, InjectionTargets.Constructor)] is not called.

    public class MyClass : INotifyPropertyChanged
    {
        [Aspect(typeof(NotifyPropertyChangedAspect))]
        public string Name { get; set; }

        public event PropertyChangedEventHandler PropertyChanged;

        [NotifyPropertyChangedInvocator]
        protected virtual void OnPropertyChanged(string propertyName)
        {
            var handler = PropertyChanged;
            if (handler != null)
                handler(this, new PropertyChangedEventArgs(propertyName));
        }
    }

[pamidur]

We could support ArgumentSource.Instance and ArgumentSource.TargetArguments in advice's constructor. Will it work with DI ?

We also could always inject InjectionTargets.Constructor? Will it make all architecture inconsistent?

Option c) - Implement InjectionTargets.Init which will always be injected into for such scenario

[pamidur]

I think we can support

public enum AspectArgumentSource
{
        Instance,
        Type,
}