Comments (6)
P.S. This is very nice project, I'm really fond of it. Free PostSharp alternative) I don't get why there are so many neutral or negative comments on http://habrahabr.ru/post/246469/
from aspect-injector.
Thank you for the feedback!
As for the "instance" source - it should work everywhere. In our tests we have the following:
internal class AdviceInjectionBeforeTests_BeforeConstructorAspect
{
[Advice(InjectionPoints.Before, InjectionTargets.Constructor)]
public void BeforeConstructor([AdviceArgument(AdviceArgumentSource.Instance)] object instance)
{
if (instance != null)
Checker.Passed = true;
}
}
If you have any issues with passing the instance to a constructor - please give as a code sample, we will check.
from aspect-injector.
Yuriy, I guess that Andrew meant that if we have a advice per instance there is no point to pass that instance every time injected method called. He suggests to have a ability to get the instance in advice's constructor. Which could be done by changing AspectFactoryAttribute or allowing ArgumentSource in advice's constructor.
from aspect-injector.
Thanks for yours replies. @pamidur - that is exactly my point. If Aspect is applied to the property (in case of INPC), not class, [Advice(InjectionPoints.Before, InjectionTargets.Constructor)] is not called. As an alternative I can suggest call [Advice(InjectionPoints.Before, InjectionTargets.Constructor)] when non-class aspect (e.g. InjectionTargets.Setter) is applied.
Sample class when [Advice(InjectionPoints.Before, InjectionTargets.Constructor)] is not called.
public class MyClass : INotifyPropertyChanged
{
[Aspect(typeof(NotifyPropertyChangedAspect))]
public string Name { get; set; }
public event PropertyChangedEventHandler PropertyChanged;
[NotifyPropertyChangedInvocator]
protected virtual void OnPropertyChanged(string propertyName)
{
var handler = PropertyChanged;
if (handler != null)
handler(this, new PropertyChangedEventArgs(propertyName));
}
}
from aspect-injector.
We could support ArgumentSource.Instance and ArgumentSource.TargetArguments in advice's constructor. Will it work with DI ?
We also could always inject InjectionTargets.Constructor? Will it make all architecture inconsistent?
Option c) - Implement InjectionTargets.Init which will always be injected into for such scenario
from aspect-injector.
I think we can support
public enum AspectArgumentSource
{
Instance,
Type,
}
from aspect-injector.
Related Issues (20)
- Aspect Injector processing has failed (v2.8.0), Mono.Cecil.Cil.SymbolsNotFoundException HOT 9
- Multiple Same Validator Aspect On MethodFeature Can Not Wroking HOT 2
- System.NotSupportedException Mac M1 Mono HOT 3
- Feature: Provide debug symbols with NuGet package HOT 2
- Feature: Replace object[0] to Array.Empty<object> HOT 1
- Feature: Can cache Argument(Source.*) any input argument by static field? HOT 1
- Lack of M1 support when rosetta isn't installed HOT 14
- Unsupported language/version ? HOT 1
- Feature: Why `GetInstance` method for Factory should be static? HOT 3
- Local variables in sync methods are not visible in the VS debugger HOT 13
- Feature: Attribute Multicasting HOT 1
- [2.8.2][macOS] error AI_FAIL: Aspect Injector processing has failed HOT 27
- In a Advice method with Kind.Before and Target.Constructor, accessing mixed-in properties injected into a class containing an explicit constructor causes NullReferenceError. HOT 4
- Feature: Make `[assembly: Attribute]` work with virtual methods that don't have an override HOT 2
- Feature: Clean Cache
- error AI_ERR0: Processing failure: System.ObjectDisposedException: Cannot access a closed file.
- Failed to resolve assembly: 'mscorlib, Version=4.0.0.0
- AspectInjector|2.8.1 : error AI_ERR0: Processing failure: System.NotSupportedException: Arg_NotSupportedException
- Feature: Extend Universal attributes to support async aspects HOT 6
- System.InvalidOperationException: Aspect doesn't have global singleton injected
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aspect-injector.