palinek / nm-tray Goto Github PK

View Code? Open in Web Editor NEW

53.0 53.0 18.0 351 KB

NetworkManager tray icon -> simple front end (nm-applet)

License: GNU General Public License v2.0

CMake 1.96% C++ 97.42% C 0.62%

nm-tray's People

Contributors

Stargazers

Watchers

Forkers

pmattern zballina zjes t-kelly-trailtech jubalh comradekingu dragondjf shlyakpavel ito32bit nadiascott iamthesenate1 anylee2021 tsimonq2 j8r naninoni inkstarvon gacheiro

nm-tray's Issues

Unable to connect to openVPN

Expected Behavior

When trying to connect to the added openVPN connection, it immediately fails.

Here's the notification message that pops up:

NetworkManager(nm-tray)
Connection lost
No longer connected to vpn 'my-vpn-conf'

Here's the error message on the terminal:

nm-tray: void NmModelPrivate::onActiveConnectionAdded(const QString&) /org/freedesktop/NetworkManager/ActiveConnection/29  is currently invalid...
nm-tray: void NmModelPrivate::onActiveConnectionRemoved(const QString&) /org/freedesktop/NetworkManager/ActiveConnection/29  is currently invalid...

I'm only unable to connect when using nm-tray. When I use nmcli or nm-applet, I can connect just fine. I also noticed that when I connect through nm-applet, there's an input dialog that asks for keyring password. Whereas with nm-tray, it just immediately fails.

Steps to Reproduce (for bugs)

It always fails.

System Information

Distribution & Version: Fedora 31
Kernel Version: 5.4.12-200.fc31.x86_64
Qt Version: 5.13
Network-Manager Version: 1.20.10-1.fc31
nm-tray Version: 0.4.2
Package version:

Use x-terminal-emulator instead of xterm

Not all distributions (like Lubuntu) want to ship xterm by default. It should refer to x-terminal-emulator instead, so the default terminal can be used.

https://phab.lubuntu.me/D3

Unclear how to disconnect from SSID

When connected to a wireless network, there is no option in the menu to disconnect. Clicking again on the connected SSID disconnects the network, but the resultant notification message says the network has been 'lost', implying that there was a problem or error.

Is clicking on the connected SSID meant to be the correct method to disconnect?

It would be useful to have a separate menu entry labelled 'Disconnect' so that the functionality is obvious. Also, the notification message should say the network has been disconnected, rather than lost.

FTBFS, wrong install destination

CMake Error at cmake_install.cmake:107 (file):
  file called with network path DESTINATION.  This does not make sense when
  using DESTDIR.  Specify local absolute path or remove DESTDIR environment
  variable.

  DESTINATION=

  //etc/xdg/autostart

[Request] VPN menu

As nm-tray is great small piece of software, please keep in mind to add the vpn feature for this eg. start stop preconfigured vpn (as already in gtk version). (thumbsup) #

Add a native Edit Connections menu

Right now, we depend on the GNOME network manager to display the "Edit Connections" menu. This is problematic, because at least on Ubuntu and Debian, this pulls in a fair amount of dependencies.

Could we implement this natively?

French translation issue ?

Hi @palinek ,
I've been translating nm-tray into French this morning, but the related commit isn't showing any translation (yet?). Did I do something wrong maybe or is it the usual workflow?

Is this UB?

nm-tray/src/tray.cpp

Line 244 in 259b866

d->mIconCurrent = static_cast<icons::Icon>(-1);

As far as I understand there is no general way to cast integer to enums. Can this lead to undefined behavior? Should one better change this to one of icons::Icon enum values?

No icon

nm-tray doesn't have any icon it is an empty space in the tray.
The package doesn't install any, I am using the Debian package:

dpkg -L nm-tray
/.
/etc
/etc/xdg
/etc/xdg/autostart
/etc/xdg/autostart/nm-tray-autostart.desktop
/usr
/usr/bin
/usr/bin/nm-tray
/usr/share
/usr/share/applications
/usr/share/applications/nm-tray.desktop
/usr/share/doc
/usr/share/doc/nm-tray
/usr/share/doc/nm-tray/README.md
/usr/share/doc/nm-tray/changelog.Debian.amd64.gz
/usr/share/doc/nm-tray/changelog.Debian.gz
/usr/share/doc/nm-tray/copyright
/usr/share/lintian
/usr/share/lintian/overrides
/usr/share/lintian/overrides/nm-tray

It shows this error when launching it:

nm-tray
QSystemTrayIcon::setVisible: No Icon set

Expected Behavior

Icons show in the tray.

Current Behavior

No icon.

Possible Solution

Fixing missing icons in the dependency?

Steps to Reproduce (for bugs)

Debian with only openbox installed , no task selected.

System Information

Distribution & Version: Debian GNU/Linux 11 (bullseye) x86_64
Kernel Version: 5.10.0-13-amd64
Qt Version: is this qmake-qt5? It isn't installed.
Network-Manager Version: 1.30.0-2
nm-tray Version: 0.4.3-2+b1
Package version: 0.4.3-2+b1

Taskbar or menu icons hard to see when both have different background

Since icons.cpp use symbolic icons for taskbar and menu, when taskbar has a dark background and menu light, icons are hard to see in task bar but does look good in menu.

network-manager from gnome use non symbolic for both, and they end up showing good in task bar but bad in menu, however, when mouse-over the connection they look good (it add a dark background on mouse-over)

In the menu is problematic for wireless signal since the icon show signal strength.

My suggestion would be to use symbolic icons for menu, but non-symbolic for taskbar.

value ‘StaticWep’ not handled in switch

/home/agaida/work/code/pkg-main/nm-tray/snapshot/src/nmmodel.cpp: In member function ‘void NmModel::activateConnection(const QModelIndex&)’:
/home/agaida/work/code/pkg-main/nm-tray/snapshot/src/nmmodel.cpp:1505:28: warning: enumeration value ‘StaticWep’ not handled in switch [-Wswitch]
                     switch (sec_type)

Wireguard support?

Can you please add basic support for wireguard configuration? Eg.: import wireguard config file, start connection, stop connection. Networkmanager already can do this, but there's no GUI yet.

0.4.3 FTBFS

In the development release of Ubuntu with Qt 5.12.4, both the tip of master and 0.4.3 FTBFS:

[ 70%] Building CXX object CMakeFiles/nm-tray.dir/src/connectioninfo.cpp.o
/usr/bin/c++  -DNM_TRAY_VERSION=\"0.4.2\" -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_NO_SIGNALS_SLOTS_KEYWORDS -DQT_WIDGETS_LIB -DTRANSLATION_DIR=\"/usr/share/nm-tray\" -I"/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan/obj-x86_64-linux-gnu" -I"/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan" -I"/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan/obj-x86_64-linux-gnu/nm-tray_autogen/include" -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -isystem /usr/include/KF5/NetworkManagerQt -isystem /usr/include/libnm -isystem /usr/include/libmount -isystem /usr/include/blkid -isystem /usr/include/glib-2.0 -isystem /usr/lib/x86_64-linux-gnu/glib-2.0/include -isystem /usr/include/KF5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/x86_64-linux-gnu/qt5/QtDBus  -g -O2 -fdebug-prefix-map=/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra -O2 -g -DNDEBUG   -fPIC -std=gnu++11 -o CMakeFiles/nm-tray.dir/src/connectioninfo.cpp.o -c "/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan/src/connectioninfo.cpp"
/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan/src/nmmodel.cpp: In member function ‘QVariant NmModel::dataRole(const QModelIndex&) const [with int role = 265]’:
/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan/src/nmmodel.cpp:1041:141: error: invalid use of incomplete type ‘class QMetaEnum’
 1041 |         auto m_enum = NetworkManager::Device::staticMetaObject.enumerator(NetworkManager::Device::staticMetaObject.indexOfEnumerator("Type"));
      |                                                                                                                                             ^
In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/qmetatype.h:50,
                 from /usr/include/x86_64-linux-gnu/qt5/QtCore/qvariant.h:46,
                 from /usr/include/x86_64-linux-gnu/qt5/QtCore/qabstractitemmodel.h:43,
                 from /usr/include/x86_64-linux-gnu/qt5/QtCore/QAbstractItemModel:1,
                 from /<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan/src/nmmodel.h:26,
                 from /<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan/src/nmmodel.cpp:23:
/usr/include/x86_64-linux-gnu/qt5/QtCore/qobjectdefs.h:284:7: note: forward declaration of ‘class QMetaEnum’
  284 | class QMetaEnum;
      |       ^~~~~~~~~
/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan/src/nmmodel.cpp:1046:16: warning: enumeration value ‘Ppp’ not handled in switch [-Wswitch]
 1046 |         switch (dev->type())
      |                ^
/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan/src/nmmodel.cpp:1046:16: warning: enumeration value ‘OvsInterface’ not handled in switch [-Wswitch]
/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan/src/nmmodel.cpp:1046:16: warning: enumeration value ‘OvsPort’ not handled in switch [-Wswitch]
/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan/src/nmmodel.cpp:1046:16: warning: enumeration value ‘OvsBridge’ not handled in switch [-Wswitch]
/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan/src/nmmodel.cpp:1046:16: warning: enumeration value ‘Wpan’ not handled in switch [-Wswitch]
/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan/src/nmmodel.cpp:1046:16: warning: enumeration value ‘Lowpan’ not handled in switch [-Wswitch]
/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan/src/nmmodel.cpp:1046:16: warning: enumeration value ‘WireGuard’ not handled in switch [-Wswitch]
/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan/src/nmmodel.cpp:1046:16: warning: enumeration value ‘WifiP2P’ not handled in switch [-Wswitch]
[ 73%] Building CXX object CMakeFiles/nm-tray.dir/src/nmlist.cpp.o
/usr/bin/c++  -DNM_TRAY_VERSION=\"0.4.2\" -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_NO_SIGNALS_SLOTS_KEYWORDS -DQT_WIDGETS_LIB -DTRANSLATION_DIR=\"/usr/share/nm-tray\" -I"/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan/obj-x86_64-linux-gnu" -I"/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan" -I"/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan/obj-x86_64-linux-gnu/nm-tray_autogen/include" -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -isystem /usr/include/KF5/NetworkManagerQt -isystem /usr/include/libnm -isystem /usr/include/libmount -isystem /usr/include/blkid -isystem /usr/include/glib-2.0 -isystem /usr/lib/x86_64-linux-gnu/glib-2.0/include -isystem /usr/include/KF5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/x86_64-linux-gnu/qt5/QtDBus  -g -O2 -fdebug-prefix-map=/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra -O2 -g -DNDEBUG   -fPIC -std=gnu++11 -o CMakeFiles/nm-tray.dir/src/nmlist.cpp.o -c "/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan/src/nmlist.cpp"
/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan/src/nmmodel.cpp: In member function ‘void NmModel::activateConnection(const QModelIndex&)’:
/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan/src/nmmodel.cpp:1527:28: warning: enumeration value ‘StaticWep’ not handled in switch [-Wswitch]
 1527 |                     switch (sec_type)
      |                            ^
/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan/src/nmmodel.cpp:1527:28: warning: enumeration value ‘DynamicWep’ not handled in switch [-Wswitch]
/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan/src/nmmodel.cpp:1527:28: warning: enumeration value ‘Leap’ not handled in switch [-Wswitch]
/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan/src/nmmodel.cpp:1527:28: warning: enumeration value ‘WpaEap’ not handled in switch [-Wswitch]
/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan/src/nmmodel.cpp:1527:28: warning: enumeration value ‘Wpa2Eap’ not handled in switch [-Wswitch]
[ 76%] Building CXX object CMakeFiles/nm-tray.dir/src/menuview.cpp.o
/usr/bin/c++  -DNM_TRAY_VERSION=\"0.4.2\" -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_NO_SIGNALS_SLOTS_KEYWORDS -DQT_WIDGETS_LIB -DTRANSLATION_DIR=\"/usr/share/nm-tray\" -I"/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan/obj-x86_64-linux-gnu" -I"/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan" -I"/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan/obj-x86_64-linux-gnu/nm-tray_autogen/include" -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -isystem /usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -isystem /usr/include/KF5/NetworkManagerQt -isystem /usr/include/libnm -isystem /usr/include/libmount -isystem /usr/include/blkid -isystem /usr/include/glib-2.0 -isystem /usr/lib/x86_64-linux-gnu/glib-2.0/include -isystem /usr/include/KF5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/x86_64-linux-gnu/qt5/QtDBus  -g -O2 -fdebug-prefix-map=/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra -O2 -g -DNDEBUG   -fPIC -std=gnu++11 -o CMakeFiles/nm-tray.dir/src/menuview.cpp.o -c "/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan/src/menuview.cpp"
make[3]: *** [CMakeFiles/nm-tray.dir/build.make:167: CMakeFiles/nm-tray.dir/src/nmmodel.cpp.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory '/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan/obj-x86_64-linux-gnu'
make[2]: *** [CMakeFiles/Makefile2:108: CMakeFiles/nm-tray.dir/all] Error 2
make[2]: Leaving directory '/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan/obj-x86_64-linux-gnu'
make[1]: *** [Makefile:133: all] Error 2
make[1]: Leaving directory '/<<BUILDDIR>>/nm-tray-0.4.3+git201909300108~eoan/obj-x86_64-linux-gnu'
dh_auto_build: cd obj-x86_64-linux-gnu && make -j4 "INSTALL=install --strip-program=true" returned exit code 2
make: *** [debian/rules:9: build] Error 255
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2

@apt-ghetto reported this in Lubuntu

Static IP, connection working but icon on system tray issue.

I'm on lubuntu 20.04LTS. I set a static ip on my eth card and internet works good, but the icon on tray is like in picture:

Why? Is possible to fix it?

DESTINATION vs DESTDIR

CMake Error at cmake_install.cmake:106 (file):
  file called with network path DESTINATION.  This does not make sense when
  using DESTDIR.  Specify local absolute path or remove DESTDIR environment
  variable.

  DESTINATION=

  //etc/xdg/autostart

Make target install failing in recent VCS checkouts

After successfully compiling nm-tray make target install fails due to some missing file

$ make DESTDIR=/usr/local/peter/Tests/nm-tray/Projekt/installation/ install 
[  6%] Automatic moc and uic for target nm-tray
[  6%] Built target nm-tray_automoc
[100%] Built target nm-tray
Install the project...
-- Install configuration: ""
-- Installing: /usr/local/peter/Tests/nm-tray/Projekt/installation/usr/local/bin/nm-tray
-- Installing: /usr/local/peter/Tests/nm-tray/Projekt/installation/usr/local/share/nm-tray/nm-tray_de.qm
-- Installing: /usr/local/peter/Tests/nm-tray/Projekt/installation/usr/local/share/nm-tray/nm-tray_sk.qm
CMake Error at cmake_install.cmake:68 (file):
  file INSTALL cannot find
    "/usr/local/peter/Tests/nm-tray/Projekt/nm-tray/RESOURCE".


    Makefile:61: recipe for target 'install' failed
    make: *** [install] Error 1

Seen compiling 3f80ec0 on Arch Linux.

Unintuitive disconnect on right click on connections list

Unintuitive clicks on connections list. Right click usually opens menu (if available). Now it just call action – disconnect for example.

Expected Behavior

Allow only left click (ignore right and middle).

Current Behavior

Any mouse button execute an action (connect and disconnect).

Possible Solution

Steps to Reproduce (for bugs)

Open connection link
Right click on connection

Context

Accident disconnections.

System Information

Distribution & Version: Debian testing
Kernel Version: 5.16.0-5-amd64
Qt Version: 5.15.2
Network-Manager Version: 1.36.4
nm-tray Version: 41185e6
Package version: —

No icon in system tray lxqt desktop

I have installed nm-tray-git package but there is no icon in system tray. Does it work with lxqt ?

vpn connection does not ask for password

When connecting to VPN (in my case pptp in lubuntu with the package network-manager-pptp), if the passwd is saved it works w/o problem, and lock icon appear in the systray.
But, if it is required to ask for a password, nm-tray does not ask for it and fail instantly to connect.
I still can connect via command line with:
nmcli con up id VPN_ID --ask
and it works ok with the notifier and the lock, but nm-tray does not ask for password

Distribution & Version: Lubuntu 19.10 eoan
Kernel Version: 5.2
Qt Version: qt5-default/eoan 5.12.4+dfsg-4build1
Network-Manager Version: 1.20.0-1ubuntu1 amd64
nm-tray Version: 0.4.3

Feature request: option to show password while typing

Hey there, it would be great to have an option that allows users to see their password as they type it in the password pop-up window.

Configuring the network is not "user-friendly"

Hi.

For reference, I opened the exact same issue in the lxqt repo (#1643) and in the Ubuntu bug tracker (#1810095).

I just installed Lubuntu 18.10 which comes with lxqt and I love the performances, the beauty and the simplicity of the desktop environment you created.

I would like to install it everywhere and to advise it to my non-techy-Windows-user friends, but I hesitate to do so because there are few things that are not as polished as on other distributions.

One problem, in my opinion, is the configuration of the network. This is the first thing we do after installing an OS, so this is the first interaction of the user with the distribution, and it means so much on his first impression of this new environment.

I made this gif right after installing Lubuntu, while Internet is not yet working.

I wanted to denote a few things:

Clicking on the "Wi-Fi network" does nothing
- I guess it should either not be clickable or open a window information / configuration about the network
Clicking on the network in "Known connection" disconnect me
- Why does it do so while clicking on the same network under "Wi-Fi network" did nothing?
- How can it disconnect me while I'm not even connected?
- What actually changed? The icon stays the same. The network list stays the same.
The "Connection Information" open an empty window
- I suppose it should display a message like "You are not currently connected to any network". Otherwise, the user may think "Is it a bug? Is it loading data info in the background?"
The "Edit connections" open a Shell rather that a graphical window
- I know that this is easily configurable and that there is not even one command line to type, but this would be much more welcoming if configuring the network was made trough a graphical window, and if it just required to type the WPA key in a input box.

I know it may sound like detail and that lxqt is already very easy to use, but I sincerely believe that the graphical interface would benefit a lot for being as user-friendly as possible.

I hope it makes as much sense to you as it makes to me.

System Information

Distribution & Version: Lubuntu 18.10
Kernel: 4.18.0-13-generic
Qt Version: 5.11.1
liblxqt Version: 0.13.0
nm-tray Version: 0.4.1

Fails to compile with qt-5.11.0

Got this error trying to compile from aur.archlinux.org with newest qt-5.11.0-1 from extra (stable) repo

[ 62%] Building CXX object CMakeFiles/nm-tray.dir/src/nmproxy.cpp.o
[ 65%] Building CXX object CMakeFiles/nm-tray.dir/src/connectioninfo.cpp.o
/tmp/yaourt-tmp-nbvcxz/aur-nm-tray-git/src/nm-tray/src/connectioninfo.cpp: In member function ‘void ConnectionInfo::changeTab(const QModelIndex&)’:
/tmp/yaourt-tmp-nbvcxz/aur-nm-tray-git/src/nm-tray/src/connectioninfo.cpp:100:28: error: invalid use of incomplete type ‘class QTabBar’
     ui->tabWidget->tabBar()->setTabText(i, mSorted->data(index, NmModel::NameRole).toString());
                            ^~
In file included from /usr/include/qt/QtWidgets/QTabWidget:1,
                 from /tmp/yaourt-tmp-nbvcxz/aur-nm-tray-git/src/build/nm-tray_autogen/include/ui_connectioninfo.h:16,
                 from /tmp/yaourt-tmp-nbvcxz/aur-nm-tray-git/src/nm-tray/src/connectioninfo.cpp:24:
/usr/include/qt/QtWidgets/qtabwidget.h:51:7: note: forward declaration of ‘class QTabBar’
 class QTabBar;
       ^~~~~~~
/tmp/yaourt-tmp-nbvcxz/aur-nm-tray-git/src/nm-tray/src/connectioninfo.cpp:101:28: error: invalid use of incomplete type ‘class QTabBar’
     ui->tabWidget->tabBar()->setTabIcon(i,  mSorted->data(index, NmModel::IconRole).value<QIcon>());
                            ^~
In file included from /usr/include/qt/QtWidgets/QTabWidget:1,
                 from /tmp/yaourt-tmp-nbvcxz/aur-nm-tray-git/src/build/nm-tray_autogen/include/ui_connectioninfo.h:16,
                 from /tmp/yaourt-tmp-nbvcxz/aur-nm-tray-git/src/nm-tray/src/connectioninfo.cpp:24:
/usr/include/qt/QtWidgets/qtabwidget.h:51:7: note: forward declaration of ‘class QTabBar’
 class QTabBar;
       ^~~~~~~
make[2]: *** [CMakeFiles/nm-tray.dir/build.make:170: CMakeFiles/nm-tray.dir/src/connectioninfo.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:68: CMakeFiles/nm-tray.dir/all] Error 2
make: *** [Makefile:130: all] Error 2

possible not planned fallthrough

/home/agaida/work/code/pkg-main/nm-tray/snapshot/src/nmmodel.cpp:1228:17: warning: this statement may fall through [-Wimplicit-fallthrough=]
                 }
                 ^
/home/agaida/work/code/pkg-main/nm-tray/snapshot/src/nmmodel.cpp:1230:9: note: here
         case ITEM_WIFINET_LEAF:

password length oustide IEEE standard is accepted, silently fails

The IEEE standard for WPA2 in H.4 Suggested pass-phrase-to-PSK mapping (which includes a discussion of security considerations) says:

A pass-phrase is a sequence of between 8 and 63 ASCII-encoded characters. The limit of 63 comes from the desire to distinguish between a pass-phrase and a PSK displayed as 64 hexadecimal characters.

However, nm-tray will accept a password outside of these limits. Other utilities simply will not proceed. This makes a lot more sense because otherwise it seems to silently fail.

Expected Behavior

If a password outside of the stated limits is given, nm-tray does not allow proceeding.

Current Behavior

nm-tray will accept a password of any length and silently fail.

Possible Solution

The code should check the length of the password and keep the OK button greyed out unless it meets the criteria.

Steps to Reproduce (for bugs)

Connect to a new WPA2 access point.
When asked for the password, enter in the correct password and click ok or hit enter.
The icon changes to grey with three white horizontally-aligned dots on top of it, and then a "connection established" notification is raised.
Delete the new WPA2 access point connection.
Connect to a new WPA2 access point.
When asked for the password, enter the wrong password, but of a length between 8 and 63 characters and click ok or hit enter.
The icon changes to grey with three white horizontally-aligned dots on top of it, and then a "connection lost" notification is raised.
Delete the new WPA2 access point connection.
Connect to a new WPA2 access point and click ok or hit enter.
When asked for the password, enter one smaller than 8 or larger than 63 characters.
The icon does not change and no notification is raised.

Context

Other nm front ends do not allow proceeding until the appropriate character length is met.

System Information

Distribution & Version: Lubuntu 20.04
Kernel Version: 5.4.0-9.12
Qt Version: 5.12.5+dfsg-8build1
Network-Manager Version: 1.22.8-1ubuntu1
nm-tray Version: 0.4.3
Package version: 0.4.3-0ubuntu2

No icon in system tray in dwm

no icon is being shown in dwm system tray. nm-tray is trying to access them from /usr/share/pixmaps but no such file there.

New langauge on Weblate copies source to translation

I created a new language on weblate but instead of starting a new blank translation Weblate seems to have copied all the source strings to the translated strings.

If i download the file the translated strings are empty.
But on Weblate the translated strings are not empty for some reason.

Multiple instances of nm-tray on xfce4 Debian bullseye

I was having problems opening windows getting error that limit was reached. Searched and found the following command to list X11 clients:

lsof +c0 /usr/lib/x86_64-linux-gnu/libX11.so.6|cut -d' ' -f1

result was:

pulseaudio
xfce4-session
at-spi-bus-laun
at-spi2-registr
xfwm4
xfsettingsd
xfce4-panel
xfdesktop
panel-7-battery
panel-1-pulseau
panel-16-xfce4-
xfce4-notifyd
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
nm-tray
xfce4-power-man
nm-tray
nm-tray
nm-tray
nm-tray
Thunar
nm-tray
applet.py
ayatana-indicat
parcellite
blueman-applet
xiccd
polkit-gnome-au
nm-applet
blueman-tray
xfce4-terminal
firefox-esr

I had switched off notifications from nm-tray because it was spamming the screen with many notifications. The solution was to uninstall. I didn't seem to have the same problem when using lxde so it might be an xfce bug.

nm-tray 0.4.3-2+b1
network-manager 1.30.0-2
Linux 5.10.0-6-amd64 #1 SMP Debian 5.10.28-1 (2021-04-09) x86_64 GNU/Linux

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

Context

System Information

Distribution & Version:
Kernel Version:
Qt Version:
Network-Manager Version:
nm-tray Version:
Package version:

Context Menu (right click?)

Hey,

I can't figure out why, but I have no right click context menu in your tray icon. I have that main
Active Connections/Wifi/Known Connections. dialog but this comes up on both left and right clicks.

I have other QT5 based tray apps and they all work fine.
Your code appears to have a menu built d->mTrayIcon.setContextMenu(&d->mContextMenu);
but i can't get it to work.

BTW: I'm running, Gentoo w/AwesomeWM

any clues?

greater units for Speed

The "Connection Information" (RMB click on nm-tray displays Speed as 1000000 Kb/s.
It would be nice if it was in greater units (eg. 100Mb/s or 1000Mb/s or 1Gb/s).

No visual feedback to "connecting" state

Hi.
First, thanks for your work.
Wireless connections can be in "connecting" state for quite a long time, and wile getting the authentication nm-tray shows me the same icon of connected networks.

QT error on startup and in ~/.xsession-errors

Expected Behavior

show a human readable/understandable message, if an error ocours, best with hints
avoid writing same error message multiple time

Current Behavior

nm-tray prints following error on startup:
QSystemTrayIcon::setVisible: No Icon set
nm-tray prints more than 10 per second in ~/.xsession-errors
(wrapper-2.0:2799): libsystray-CRITICAL **: 10:06:03.563: sn_item_invalidate: assertion 'XFCE_IS_SN_ITEM (item)' failed
which reults in roughly 100MB per day.

Possible Solution

Errors returned from QT-system should be catched and reported with context of nm-tray.
nm-tray should have an option which reports expected resources (like icons) and dependencies.
use build-in defaults if something is missing (yes, I know, this is a load of work).

Steps to Reproduce (for bugs)

Debugging is hard, as it depends on the used and configured QT.
The QSystemTrayIcon... message can be reproduced as follows (assuming your theme is set to Adwaita, otherwise replace by proper name):

mv /usr/share/icons/Adwaita{,-DISABLED}
nm-tray
mv /usr/share/icons/Adwaita{-DISABLED,}

The error in ~/.xsession-errors is hard to reproduce (no guarantee):

mv /usr/share/icons/Adwaita{,-DISABLED}
kill Xorg # or whatever X-Server is used
start Xorg # and login
nm-tray
mv /usr/share/icons/Adwaita{-DISABLED,}
kill Xorg
start Xorg

Context

Probably installing any or all of following packages (debian names) avoids the problem:

adwaita-icon-theme
paper-icon-theme

The continuous writing of the libsystray-CRITICAL probaly happens in
TrayPrivate::refreshIcon() in tray.cpp

System Information

Distribution & Version: Devuan 4
Kernel Version: 5.10.0-9-amd64
Qt Version: 5
Network-Manager Version: 1.30.0
nm-tray Version: 0.4.2
Package version:

NM_TRAY_VERSION is old

https://github.com/palinek/nm-tray/blob/master/CMakeLists.txt#L6

still at 0.4.2, latest release is 0.5.0

feature request: add adapter info to nm-tray Edit

Add information about the hardware to the Connection information window.
Eg. MEDIATEK Corp. MT7921K (RZ608) Wi-Fi 6E 80MHz

Policy CMP0071 is not set

CMake Warning (dev) in CMakeLists.txt:
  Policy CMP0071 is not set: Let AUTOMOC and AUTOUIC process GENERATED files.
  Run "cmake --help-policy CMP0071" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  For compatibility, CMake is excluding the GENERATED source file(s):

    "/home/agaida/work/code/pkg-main/nm-tray/snapshot/obj-x86_64-linux-gnu/dbus/org.freedesktop.Notifications.h"
    "/home/agaida/work/code/pkg-main/nm-tray/snapshot/obj-x86_64-linux-gnu/dbus/org.freedesktop.Notifications.cpp"

  from processing by AUTOMOC and AUTOUIC.  If any of the files should be
  processed, set CMP0071 to NEW.  If any of the files should not be
  processed, explicitly exclude them by setting the source file property
  SKIP_AUTOGEN:

    set_property(SOURCE file.h PROPERTY SKIP_AUTOGEN ON)

Refresh wifi list button

Expected Behavior

IIt would be nice to have a button to immediately refresh the wifi list of connections.

Current Behavior

At the moment, after powering on my router, I have to wait until nm-tray decides to refresh the list (don't know how often it happens, but surely it's not immediate).

Possible Solution

It would be nice to have a "Refresh list" button in the context menu which automatically refresh the list of available wifi connection.

Autostart desktop file: a "OnlyShowIn" key must be included

desktop-file-validate /home/builder/rpmbuild/BUILDROOT/nm-tray-0.3.0-1.fc27.x86_64/usr/share/applications/nm-tray.desktop
/home/builder/rpmbuild/BUILDROOT/nm-tray-0.3.0-1.fc27.x86_64/usr/share/applications/nm-tray.desktop: hint: value "Network;System;Monitor;Qt;TrayIcon" for key "Categories" in group "Desktop Entry" contains more than one main category; application might appear more than once in the application menu
/home/builder/rpmbuild/BUILDROOT/nm-tray-0.3.0-1.fc27.x86_64/usr/share/applications/nm-tray.desktop: error: value item "TrayIcon" in key "Categories" in group "Desktop Entry" is a reserved category, so a "OnlyShowIn" key must be included

new release

Hi,
do you plan to have a new release soon? With the non-symbolic tray icon? Just wanted to know so we don't have to apply the patch in lubuntu and could only use the release.
Thanks!

Foreground color offers no contrast

I installed lubuntu and nm-tray icon displaying wifi strength has a gray foreground color similar to the background color. Difficult to see wifi level, or the nm-tray icon even (lower right corner on the screen, next to the clock).

Expected Behavior

Change to a constrasting foreground color, for example the blue used elsewhere in lubuntu.

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

Context

System Information

Distribution & Version:
Kernel Version:
Qt Version:
Network-Manager Version:
nm-tray Version:
Package version:

value ‘IpTunnel’ not handled in switch

/home/agaida/work/code/pkg-main/nm-tray/snapshot/src/nmmodel.cpp: In member function ‘QVariant NmModel::dataRole(const QModelIndex&) const [with int role = 265]’:
/home/agaida/work/code/pkg-main/nm-tray/snapshot/src/nmmodel.cpp:1030:16: warning: enumeration value ‘IpTunnel’ not handled in switch [-Wswitch]
         switch (dev->type())

Is this window title okay?

nm-tray/src/nmlist.ui

Line 14 in 68a57d4

<string>Dialog</string>

It is probably unclear what it means and I have no idea how to translate it

FYI: nm-tray is in sid now

https://tracker.debian.org/pkg/nm-tray

Cheers Alf

nm-tray version not updated in CMakeLists.txt

set(NM_TRAY_VERSION "0.3.0")

This should probably say 0.4.0 after the new release.

I'll patch this in Ubuntu.

palinek / nm-tray Goto Github PK

nm-tray's People

Contributors

Stargazers

Watchers

Forkers

nm-tray's Issues

Expected Behavior

Steps to Reproduce (for bugs)

System Information

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

System Information

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

Context

System Information

System Information

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

Context

System Information

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

Context

System Information

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

Context

System Information

Expected Behavior

Current Behavior

Possible Solution

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

Context

System Information

Recommend Projects

Recommend Topics

Recommend Org