pact-foundation / homebrew-pact-ruby-standalone Goto Github PK

brew install fails:

$  brew install pact-ruby-standalone

Error: pact-ruby-standalone: /usr/local/Homebrew/Library/Taps/pact-foundation/homebrew-pact-ruby-standalone/pact-ruby-standalone.rb:12: syntax error, unexpected tIDENTIFIER, expecting end
        puts "# Run "pact-mock-service help [COMMAND]"...
                     ^~~~
/usr/local/Homebrew/Library/Taps/pact-foundation/homebrew-pact-ruby-standalone/pact-ruby-standalone.rb:12: syntax error, unexpected tIDENTIFIER, expecting do or '{' or '('
... "# Run "pact-mock-service help [COMMAND]" (for more see htt...
...                           ^~~~
/usr/local/Homebrew/Library/Taps/pact-foundation/homebrew-pact-ruby-standalone/pact-ruby-standalone.rb:12: syntax error, unexpected tSTRING_BEG, expecting end
...ct-mock-service help [COMMAND]" (for more see https://github...
...                              ^

I opened PR #60 to fix the issue.

• brew cleanup -s
• brew tap pact-foundation/pact-ruby-standalone
  ==> Tapping pact-foundation/pact-ruby-standalone
  Cloning into '/usr/local/Homebrew/Library/Taps/pact-foundation/homebrew-pact-ruby-standalone'...
  Tapped 1 formula (35 files, 32.5KB).
• brew install pact-ruby-standalone
  ==> Installing pact-ruby-standalone from pact-foundation/pact-ruby-standalone
  ==> Downloading https://github.com/pact-foundation/pact-ruby-standalone/releases/download/v1.88.3/pact-1.88.3-osx.tar.gz
  ==> Downloading from https://github-production-release-asset-2e65be.s3.amazonaws.com/92879052/8ab25100-dcfd-11ea-872b-a9608fff5d8a?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=[REDACTED]&X-Amz-Expires=300&X-Amz-Signature=[REDACTED]=host&actor_id=0&repo_id=92879052&response-content-disposition=attachment%3B%20filename%3Dpact-1.88.3-osx.tar.gz&response-content-type=application%2Foctet-stream
  Error: SHA256 mismatch
  Expected: b52cfc7c2e405c26d426f817961d9816c7e57ded
  Actual: 90ad65d18890ffa5020e3c8cec8593f3c88da9ed1454873ba1fc0ce5dcc569fb
  Archive: /Users/vagrant/Library/Caches/Homebrew/downloads/b6141235269079a7b49a9bc536310e25fa56cf2e6dff1bc86d3a1d74f5101a7f--pact-1.88.3-osx.tar.gz

There was some errors in the verification step when new releases are created.

See #83 (comment)

It's failing in CI, with the same error above.

I've changed to the following steps.

      - name: Verify tap (⚠️ experimental ⚠️)
        run: |
          hub checkout version/v${{ github.event.client_payload.version }}
          brew install --verbose --debug pact-ruby-standalone.rb
          brew audit --strict --online pact-ruby-standalone

I am not sure if installing the formula from the file is correct.

Once it is built, it complains that my gems aren't built correctly.

There is also this audit issue appearing in CI

pact-ruby-standalone:
  * 2: col 3: Description is too long. It should be less than 80 characters. The current length is 94.
  * Stable: version 1.91.0 is redundant with version scanned from URL
  * Libraries were compiled with a flat namespace.
    This can cause linker errors due to name collisions, and
    is often due to a bug in detecting the macOS version.
      /opt/homebrew/Cellar/pact-ruby-standalone/1.91.0/lib/ruby/lib/libyaml-0.2.dylib

These weren't seen before, as the brew pull command has been deprecated for a couple of years.

It might be okay to merge the PR to master, but I'd like to test it out after, I was hoping I could build it locally and check it all works.

master linux build failing due to hub command no longer available in the image. believe its been replaced by the gh cli

update to make ci green again, and check out other affected pact-foundation repos

As per the pact-node one https://github.com/pact-foundation/pact-node/blob/master/.github/workflows/update.yml

Should be .../v$version/... (current script missed the v)