packtpublishing / mastering-distributed-tracing Goto Github PK

...I couldn't get the first example from Chapter04 to run. If you curl for for a user that isn't in the database, you get a null pointer at Chapter04/java/src/main/java/exercise1/HelloController:36 because the title is null. Just initialise to "" in Person to fix it.

I was gonna submit a PR but Java 11 decided to stick needles in my eyes. Meh.

In this docker-compose.yml, you heavn't initiate jaeger agent, why collector still can get trace?

/Chapter12/docker-compose.yml

Can I ask in this function why do you choose session window in the flink？It is better than time window？ And how do we identify traceSessionWindow?

private static DataStream<Trace> aggregateSpansToTraces(DataStream<Span> spans) {
    return spans //
            .keyBy((KeySelector<Span, String>) span -> span.traceId)
            .window(ProcessingTimeSessionWindows.withGap(traceSessionWindow))
            .apply(new WindowFunction<Span, Trace, String, TimeWindow>() {
                @Override
                public void apply(String traceId, TimeWindow window, Iterable<Span> spans, Collector<Trace> out)
                        throws Exception {
                    List<Span> spanList = new ArrayList<>();
                    spans.forEach(spanList::add);

                    Trace trace = new Trace();
                    trace.traceId = traceId;
                    trace.spans = spanList;
                    out.collect(trace);
                }
            });
}

Can I ask how does hotrod-original.json be created, what is its function?

Thanks for the great book, jaeger and this repo.
I just finished reading and went through all the examples, I'm coming from NodeJS, and for me it might be very helpful to see working nodejs examples.
As well there are some chapters that only java examples provide (chapter 11 for example).

I would like to contribute examples for nodejs for chapters 4, 11
And add go example for chapter 11,

WDYT?

when i try dep ensure on mac terminal, it showed that
could not find project Gopkg.toml, use dep init to initiate a manifest

Hi, Trying out chapter 11. I hit an issue where port 5000 of the logstash docker container had a conflict with port 5000 used by docker for Mac. I updated the port to 6000, updated logback config files in all the services and seeing the logs in kibana. However figure 11.5 and the related table looks a bit different as shown below.

Is this a new format or some error related to the above change?