ozdemirburak / json-csv Goto Github PK

Hi!
I would like to know if there's a way to set the delimiter to ; (Excel csv).
When I set 'delimiter' => ';', instead of 'delimiter' => ',', in Csv.php, I get false output.
Is there a solution to this?

Edit: In some Windows localizations, a comma is used for the currency decimal, so Windows sets the list separator to ;.

Cheers!

Adding a workflow to this repository would be great.

As an example you can check this commit:

• ozdemirburak/iris@5a523b9

The library is functional and has performed as expected during initial testing with a set of predefined test cases. However, to ensure its robustness, accuracy, and readiness for a broader release, it's essential to subject it to testing with a diverse range of JSON files.

• Convert a variety of JSON files to CSV using this library.
• Use a mix of simple, complex, nested, large, and small JSON files.
• Ensure the testing covers different data types such as strings, numbers, booleans, nulls, arrays, and objects.

This testing will aid in identifying any hidden bugs, edge cases, or performance issues that might not have surfaced during initial testing.

If you find any bugs, feel free to fix them.

Version to check: 0.5.0-alpha

Note: There's no need to ask for assignment, just proceed with testing. Also, feel free to add new tests to the tests folder.

In CSV to JSON, would there be a way to set one of the columns as the object index, instead of having the output json indexed by number? Ie. the example from the readme:

[
  {
    "SepalLength": "5.1",
    "SepalWidth": "3.5",
    "PetalLength": "1.4",
    "PetalWidth": "0.2",
    "Name": "Iris-setosa"
  },
  {
    "SepalLength": "7.0",
    "SepalWidth": "3.2",
    "PetalLength": "4.7",
    "PetalWidth": "1.4",
    "Name": "Iris-versicolor"
  },
  {
    "SepalLength": "6.3",
    "SepalWidth": "3.3",
    "PetalLength": "6.0",
    "PetalWidth": "2.5",
    "Name": "Iris-virginica"
  }
]

to

[
 "Iris-setosa":  {
    "SepalLength": "5.1",
    "SepalWidth": "3.5",
    "PetalLength": "1.4",
    "PetalWidth": "0.2",
    "Name": "Iris-setosa"
  },
 "Iris-versicolor":  {
    "SepalLength": "7.0",
    "SepalWidth": "3.2",
    "PetalLength": "4.7",
    "PetalWidth": "1.4",
    "Name": "Iris-versicolor"
  },
 "Iris-virginica":  {
    "SepalLength": "6.3",
    "SepalWidth": "3.3",
    "PetalLength": "6.0",
    "PetalWidth": "2.5",
    "Name": "Iris-virginica"
  }
]

This would make for easier search in large JSON files so that you don't have to loop through each object and look for the Name, rather loop through each object with key Name.

Currently, the package only supports converting from file inputs.

The package needs a new method like fromString(), where users can convert JSON/CSV strings to CSV/JSV strings without input files.

Currently, the package only supports converting from files, an issue mentioned before in #15.

The package needs a new method like fromString(), where users can convert JSON/CSV strings to CSV/JSV strings without input files.

Currently, it is assumed that each object shares the same properties while converting JSON to CSV. So if one object has a property that the other one does not have, then it becomes a major problem.

So one should implement a better conversion method where it would not fail with objects that do not share the same properties.

Example Input:

[
  {
    "x": 0,
    "y": 1
  },
  {
    "y": 0,
    "z": 0
  }
]

Output: (Wrong)

Expected Output: (True)

If it is production ready, can you please update the tag/version to be 1.0.0?

If it is not production ready, what are your concerns?

Thanks

Currently, when one uses the output of JSON to CSV conversion as an input of CSV to JSON, one does not get the same input provided in the first place.

Example Scenario:

$csv = (new Json('whatever.json'))->convertAndSave('whatever.csv');
$json = (new Csv('whatever.csv'))->convertAndSave('whatever-new.json');
file_get_contents('whatever.json') === file_get_contents('whatever-new.json');

Here are the input and the output files for the example scenario.

Input: whatever.json

[
  {
    "name": {
      "common": "Turkey"
    },
    "latlng": [39, 35]
  }
]

Output: whatever.csv

Output: whatever-2.json

[{"name_common":"Turkey","latlng_0":"39","latlng_1":"35"}]

What is expected is a new method when used converts whatever.csv to whatever.json again instead of whatever-2.json.

As the title says. Restricting the conversion to files seems like an artificial, unnecessary limitation.

Probably this package has some bugs that can be identified with new tests. With taking inspiration from the current tests located in CsvTest.php and JsonTest.php files, you may create or modify some tests with more complex data.

What I mean by complex data is nested data like the below one.

{
  "a": {
    "b": {
      "c": 1,
      "d": {
        "e": [
          {
            "f": 2,
            "g": 3
          }
        ]
      }
    }
  }
}

TLDR: Create new tests to make package fail.

Hey man ! ✋

I used your library for my work to convert some JSON files to CSV but for some of this files, I have an arror message like this :

Do you have a answer to this problem ?

Thank you ^^

The Problem

This library causes apps that utilize it to fail on phpstan level 5...