oxen-io / oxen-encoding

Base 16/32/64 and Bittorrent Encoding/Decoding Header Only Library

oxenc

Base 16/32/64 and Bittorrent Encoding/Decoding Header Only Library

oxen-encoding's Issues

Some TODOs:

• get rid of BSD-style licence from the top of source files (since we are LGPLing this)
• Inline the bt_serialize.cpp functions so that the library can be header-only (it is small enough that it seems worthwhile to not have to add an extra linking dependency for projects).
• Rename "oxenenc" (name directory & namespace) to shorter oxenc

Suggested fixes for `variant.h`

@jagerman Returning to this finally.

1. Sorry, I missed it somehow earlier: we got an unneeded duplicate condition here:

   oxen-encoding/oxenc/variant.h

   Lines 16 to 21 in d6f300d

   	#ifdef __APPLE__
   	#include <AvailabilityMacros.h>
   	#if defined(__APPLE__) && (MAC_OS_X_VERSION_MIN_REQUIRED < 101400)
   	#define BROKEN_APPLE_VARIANT
   	#endif
   	#endif

Should be just:

#ifdef __APPLE__
#include <AvailabilityMacros.h>
#if MAC_OS_X_VERSION_MIN_REQUIRED < 101400
#define BROKEN_APPLE_VARIANT
#endif
#endif

This is non-functional, but the code will be neater.

2. variant.h does not seem to encounter any issues when GCC is used: #16 (comment)
   I have also verified that with oxen-encoding 1.0.8 now.

Should I test something else, or we can make a “broken” fallback conditional on Clang?