oxc-project / javascript-parser-in-rust Goto Github PK

In the tutorial it's suggested to represent Expression as an enum and each expression has it's variant. Inside all variants we are storing a node.

I'm trying to work with use the AST, and it's not easy to access the node field without deconstructing to a variant.

I'm curios what happens if we change the representation to this:

pub struct Expression {
	node: Node,
	expression_kind: ExpressionKind,
}

pub enum ExpressionKind {
    SomeExpression(SomeExpression),
}

Then we can pass this type around in functions and access the node easily.

Does this have negative performance impact or other issues?

Thank you for the wonderful project.
Since discussions haven’t been opened, I am asking this question through an issue.

I know that part of this project has been translated into Japanese, and I would like to create PRs for translating the remaining parts.
What granularity of PRs do you request us?

• Everything all at once
• Each page individually
• Others

I would be grateful if you could tell me the method that would best suit your preferences.

When I set up this project to fix #13, I found that configuration for corepack is not set up.
So, I tried to use the latest version of pnpm (because of pnpm-lock.yaml), and diffs are generated in the file.

I didn't include the diff in #13, but it's appreciated packageManager option is defined in package.json for future developer experience.

See https://github.com/oxc-project/javascript-parser-in-rust/actions/runs/6841174660/job/18601258603?pr=21

ref: https://x.com/boshen_c/status/1723537621572612296?s=20

The comment said that bump will return true if we are at specified Kind, but it didn't return true in the code.

https://github.com/RustMagazine/rustmagazine/blob/main/content/issue-3/javascript-compiler.md

https://boshen.github.io/javascript-parser-in-rust/blog/grammar/#label-statement-is-legit

The following syntax is correct, it returns a labelled statement (not object literal).

const foo = (bar) => ({ baz: quaz });

In fact, it will return object literal.