owncloud / example-files Goto Github PK

Ref owncloud/test-data#8

The currently shipped demo data in ownCloud doesn’t have an explicit license (unlike the data at https://github.com/owncloud/test-data)

Would be cool to clarify the license – and ideally have it be an open license like Creative Commons Attribution or Attribution-ShareAlike. We shouldn’t package and spread copyrighted files.

cc @karlitschek

Since commit 936975e the master QA tarball https://download.owncloud.org/community/owncloud-daily-master-qa.tar.bz2 now has:

/owncloud/core/skeleton/Makefile

In addition to ownCloud Manual.pdf and the Documents and Photos folders.

This is causing unit test fails in the encryption app, e.g. https://drone.owncloud.com/owncloud/encryption/619/153

There were 3 failures:

1) OCA\Encryption\Tests\Command\FixEncryptedVersionTest::testEncryptedVersionZero
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Verifying the content of file /test_enc_version_affected_user1/files/hello.txt\n
+'Verifying the content of file /test_enc_version_affected_user1/files/Makefile\n
+The file /test_enc_version_affected_user1/files/Makefile is: OK\n
+Verifying the content of file /test_enc_version_affected_user1/files/hello.txt\n

/var/www/owncloud/server/apps/encryption/tests/unit/Command/FixEncryptedVersionTest.php:147

2) OCA\Encryption\Tests\Command\FixEncryptedVersionTest::testEncryptedVersionLessThanOriginalValue
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Verifying the content of file /test_enc_version_affected_user1/files/foo.txt\n
+'Verifying the content of file /test_enc_version_affected_user1/files/Makefile\n
+The file /test_enc_version_affected_user1/files/Makefile is: OK\n
+Verifying the content of file /test_enc_version_affected_user1/files/foo.txt\n

/var/www/owncloud/server/apps/encryption/tests/unit/Command/FixEncryptedVersionTest.php:231

3) OCA\Encryption\Tests\Command\FixEncryptedVersionTest::testEncryptedVersionGreaterThanOriginalValue
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Verifying the content of file /test_enc_version_affected_user1/files/foo.txt\n
+'Verifying the content of file /test_enc_version_affected_user1/files/Makefile\n
+The file /test_enc_version_affected_user1/files/Makefile is: OK\n
+Verifying the content of file /test_enc_version_affected_user1/files/foo.txt\n

/var/www/owncloud/server/apps/encryption/tests/unit/Command/FixEncryptedVersionTest.php:316

FAILURES!
Tests: 241, Assertions: 704, Failures: 3.

Generating code coverage report in Clover XML format ... done
Makefile:70: recipe for target 'test-php-unit-dbg' failed
make: *** [test-php-unit-dbg] Error 1 

because when doing a general encryption occ command for a user, there is now the file Makefile to be processed.

There are some issues with the »ownCloudUserManual.pdf« default file we should fix:

• The name »ownCloudUserManual.pdf« can be improved. Should be called »ownCloud Manual.pdf« for better readability.
• It is set with Helvetica for headings and serifs for body text. According to our styles we should use Open Sans everywhere instead.
• There are some horizontal lines throughout the document. These we can just remove as they make everything look old-style. Whitespace is enough to separate.

@karlitschek whom do I need to talk to about this? :) @carlaschroder you maybe because you work on the documentation?

cc @owncloud/designers

https://github.com/owncloud/example-files/blob/master/Learn%20more%20about%20ownCloud/Data%20Protection%20and%20Data%20Secrecy%20in%20ownCloud.pdf

page 2: "admi-nistrators" (random hyphen)

https://github.com/owncloud/example-files/blob/master/Learn%20more%20about%20ownCloud/Introducing%20ownCloud.pdf
page 2: "We are an official ownCloud partner" - that sentence seems strange in the context of a document that is publish with the regular ownCloud release. Someone installing ownCloud themselves from the release tarball is not likely to have or be "an official ownCloud partner".

page 3: "we as a partner" - similar issue - the document has been written as if it is to be published by partners.

page 3: "Google Drtive" (typo)

https://github.com/owncloud/example-files/blob/master/Learn%20more%20about%20ownCloud/Keep%20your%20files%20safe%20with%20ownCloud.pdf
page 2: "exluding"

page 3: "..., if critical data is contained" - I am not sure what this means in the context of the sentence.

page 4: "Ransomware Protection blocks malware from encrypting files and folders" - actually the Ransomware Protection app provides a way to recover from a ransomware attack by allowing controlled recovery of files back to a previous point in time. IMO the text needs updating.

https://github.com/owncloud/example-files/blob/master/Learn%20more%20about%20ownCloud/Share%20files%20efficiently%20in%20your%20company.pdf
page 3, bottom right - "cloud means less control over the storage/..." to the next page - a repeated chunk of text.

page 4: "are saved in data/[user]/versions" - that is not quite technically accurate. But, IMO, this document does not even need to try to specify such technical backend implementation.

And it would be good for some to generally review the wording of the documents.