ovotech / ciris-kubernetes Goto Github PK
View Code? Open in Web Editor NEWKubernetes support for Ciris
License: MIT License
Kubernetes support for Ciris
License: MIT License
Firstly, thanks for the library!
ciris
supports optional and default values (see e.g. ConfigValue#option
,) which returns an empty, or a specified default value, if a ConfigValue contains an error with error.isMissing = true
.
It is not possible to use this functionality in ciris-kubernetes
for values inside a ConfigMap
, because if no value is found for the key then a generic ConfigError.failed
is returned instead of a ConfigError.missing
. Calls to .option
will not recover from the error to an empty value.
The relevant code here:
ciris-kubernetes/src/main/scala/ciris/kubernetes.scala
Lines 71 to 90 in bba154f
I have a use case where I'd like to have an optional config param inside a configmap. If this isn't objectionable, the fix seems pretty straight forward and I'm happy to put in the PR to change to return a ConfigError.missing
here:
ciris-kubernetes/src/main/scala/ciris/kubernetes.scala
Lines 84 to 88 in bba154f
Setup CI so pull requests can be verified before merge
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.