ovidner / djangocms-markdown Goto Github PK

Hi,

I just noticed that opening the editor threw JS errors if the end-user has not manually included jQuery in its page/template. You can reproduce the error by creating a blank project using djangocms-installer.

The error happens at line 22 and 23 of change_form.html:

minHeight: window.parent.$('.cms_modal-frame').height() - 20,
maxHeight: window.parent.$('.cms_modal-frame').height() - 20

It happens because as long as jQuery was not included by the user, window.parent.$is undefined. I suggest using instead the jQuery copy provided by the Django-CMS in the CMSobject, such as:

minHeight: window.parent.CMS.$('.cms_modal-frame').height() - 20,
maxHeight: window.parent.CMS.$('.cms_modal-frame').height() - 20

I tested on my install and it seems to work fine. I'll submit a pull request in a second.

I'm using Django 1.8. When I installed this and run python manage.py migrate, I got this error:

There is no South database module 'south.db.mysql' for your database. Please either choose a supported database, check for SOUTH_DATABASE_ADAPTER[S] settings, or remove South from INSTALLED_APPS.

Apparently, all you need to do to fix it was to uninstall South. When I tried it, it worked!

Maybe setup.py should check which Django version is used before including South as a dependency. Or maybe, this module can just be updated for newer Django versions, leaving older Django versions behind.