overwolf / overwolf-plugins Goto Github PK

View Code? Open in Web Editor NEW

26.0 26.0 32.0 577 KB

A solution with a bunch of Overwolf plugin dlls

HTML 0.67% JavaScript 10.78% C# 88.55%

overwolf-plugins's People

Contributors

Stargazers

Watchers

overwolf-plugins's Issues

ProcessListener API missing in documentation

Relevant API
bd41d55#diff-53c9f00b005f3bb53220013168e3ef64

sample code:

overwolf-plugins/sampleapp/main.js

Lines 143 to 155 in 486a5c9

    
             var processId = 12964; 
        
             plugin.get().listenOnProcess(processId,  function(status, error) { 
        
           			console.log("listen process: ", processId, status, error); 
        
             }) 
        
             // plugin.get().stopListenProcess(processId,  function(status, data) { 
        
           			// console.log("stop listen process: ", processId, status, data); 
        
             // })		  
        
              plugin.get().onOutputDebugString.addListener(function(processId, line) { 
        
               console.log("onOutputDebugString" + processId + ": " + line); 
        
              }); 
        
           });

Changed to processname instead of ID
56f0c8c

/dist dll still on version 1.0.1.3

1.0.1.4 was addded to sample-app but not to dist directory

delete file documentation missing?

relevant commit
331b4c6

Was there a new method added? Not sure what the commit did and if it's just something for the build.

Namespace doesn't match with manifest class

Hi,
it looks like the class in the sample manifest.json files are different than the namespace of the plugins.

Example:

overwolf-plugins/sample_apps/process_manager/manifest.json

Lines 33 to 36 in aba8c86

    
           "process-manager-plugin": { 
        
             "file": "process_manager.dll", 
        
             "class": "com.overwolf.net.ProcessManager" 
        
           }

It says com.overwolf.net.ProcessManager.

But in the plugin, the namespace is com.overwolf.com.overwolf.procmgr.

overwolf-plugins/plugins/process_manager/process_manager.cs

Line 14 in aba8c86

namespace com.overwolf.com.overwolf.procmgr {

The correct namespace would be com.overwolf.net.
Or the manifest class is not correct, which would be com.overwolf.com.overwolf.procmgr.ProcessManager.

The same issue appears in other plugins.
It looks like the DLLs in the samples are from a different version than the plugin folders.

simpleIOPlugin listenOnFile documentation needs update

The updated implementation of the plugin does not work with the callback directly anymore.
Now additionally a handler has to be registered through

plugin.get().onFileListenerChanged.addListener(handler)
plugin.get().onFileListenerChanged.removeListener(handler)

Create directories if they don't exist when calling writeLocalAppDataFile

Just a suggestion, as it would avoid having to make specific calls for directory check and creation every time we use the API

simpleIOPlugin missing documentation for listDirectory

listDirectory is not included in the documentation

overwolf / overwolf-plugins Goto Github PK

overwolf-plugins's People

Contributors

Stargazers

Watchers

Forkers

overwolf-plugins's Issues

ProcessListener API missing in documentation

/dist dll still on version 1.0.1.3

delete file documentation missing?

Namespace doesn't match with manifest class

simpleIOPlugin listenOnFile documentation needs update

Create directories if they don't exist when calling writeLocalAppDataFile

simpleIOPlugin missing documentation for listDirectory

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	var processId = 12964;
	plugin.get().listenOnProcess(processId, function(status, error) {
	console.log("listen process: ", processId, status, error);
	})
	// plugin.get().stopListenProcess(processId, function(status, data) {
	// console.log("stop listen process: ", processId, status, data);
	// })


	plugin.get().onOutputDebugString.addListener(function(processId, line) {
	console.log("onOutputDebugString" + processId + ": " + line);
	});
	});

	"process-manager-plugin": {
	"file": "process_manager.dll",
	"class": "com.overwolf.net.ProcessManager"
	}