ov-studio / vital.network Goto Github PK

Supply a parameter to know since how long the server been running, this could be either tick or date object itself as such indicated below:

socket.onServerDisconnect(function(startedOn, endedOn, estimatedRunTicks) {

})

Add server side support for rest.fetch() just like client API; It would be useful to remotely fetch some host's rest API on current server.

Upon losing and reconnecting the existing client should have the same VID assigned, this would allow to persist the instances safely.

This is probably an edge case, but might be worthwhile considering:

For some hosted code environments (codesandbox, reply.it, etc), one cannot connect to the environment externally, by specifying a port, i.e. the URL pointing to the environment, will connect using the default/main port of the environment.

At present when doing a vNetworkify.connect() from a client, the port is a mandatory argument.

It would be great if this argument could be optional. Then instead of ALWAYS building the socket server url as {{protocol}}://{{hostname}}:{{port}}, it could also allow for {{protocol}}://{{hostname}}.

• CLIENT:

  • Allow multiple connections to different machines on different ports.

• SERVER:

  • Allow multiple http servers on different ports.

Validate hostname prior to creating a server.

The following utility functions would be great to build a management tool for the socket server:

• vNetworkify.fetchSockets(): Retrieve an array of the sockets
• socket.fetchNetworks(): Retrieve an array of the networks for the provided socket instance
• socket.fetchRooms(): Retrieve an array of the rooms for the provided socket instance
• socket.fetchClients(): Retrieve an array of the clients connected to the provided socket instance
• socket.fetchClients(): Retrieve an array of the clients connected to the provided room instance

Support for invoking & fetching REST APIs directly on client side w/o utilizing external libraries

Include events to trap connection errors for sockets on both server and client. It would be great if this could include a reason (similar to socket.io) to allow for different strategies (throw exception, manual reconnection, etc), based on the reason for disconnection.

Add helper functions to get module's version. Forward this version to server when client tries to connect.
POV: User can then utilize which clients should be able to connect or major version changes will automatically be rejected

Native instances such as socket and client should be safe & shouldn't be exposed on functions like socket.onClientConnect & socket.onClientDisconnect as such. Clients can explicitly control otherwise which is not great.

Consideration:

• Make a new reference for socket instances (Using custom classes)
• Whitelist the methods only that client/server should be able to control

Allow clients to auto-reconnect after a break in connection.

This should include:

• Ping/Heartbeats
• Events for: ping, reconnect_attempt, reconnect and reconnect_error (similar to how socket.io implements this)
• Configuration of number reconnection attempts and time between attempts

Destroy socket's (room, network...etc) instances similarly as client manager: https://github.com/ov-studio/vNetworkify/blob/main/src/managers/socket/index.js#L112

How should it be?
https://github.com/ov-studio/vNetworkify/blob/main/src/managers/socket/client.js#L29

• Add support to automatically read sslcert.env during startup incase of existence.
• Based on availability of SSL cert prefer https connection over http.
• Apply same methodology over websocket protocols as well prefer wss over ws.
• Incase if ws is used encode all socket messages (tea encode, perhaps??); Key should be sent to client only once during the initialization of connection as suggested by @Anisa-Nur.

Events such as cSocket.onClientJoinRoom(room, vid) & cSocket.onClientLeaveRoom(room, vid) are essentially needed. Moreover client's room list must be to synced with clients as well.

Possibly there is no need of 3rd party uuid library since Crypto.randomUUID() can be used along w/ our own identifier appended to it etc.