osbuild / maintainer-tools

Release helpers, automation scripts etc

Maintainer Tools

This repository hosts a small collection of tools used by osbuild maintainers.

• node_reservation.sh
• runner-cleanup.sh

maintainer-tools's Issues

release.py: Updating NEWS file fails with SSL error

teg@tgunders-mac osbuild % python3 ../maintainer-tools/release.py 
Info: You are already on a release branch: release-32
Info: Using token from '$GITHUB_TOKEN'
Info: Updating branch 'release-32' to avoid conflicts...

Release:
  Component:     osbuild
  Version:       32
  Base branch:   release-32
GitHub:
  User:          teg
  Token:         True
  Remote:        teg

Step: Update the NEWS.md file [y/s/N] y
Step: Update NEWS.md with pull request summaries for milestone 32 [y/s/N] y
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/urllib/request.py", line 1342, in do_open
    h.request(req.get_method(), req.selector, req.data, headers,
  File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/http/client.py", line 1255, in request
    self._send_request(method, url, body, headers, encode_chunked)
  File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/http/client.py", line 1301, in _send_request
    self.endheaders(body, encode_chunked=encode_chunked)
  File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/http/client.py", line 1250, in endheaders
    self._send_output(message_body, encode_chunked=encode_chunked)
  File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/http/client.py", line 1010, in _send_output
    self.send(msg)
  File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/http/client.py", line 950, in send
    self.connect()
  File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/http/client.py", line 1424, in connect
    self.sock = self._context.wrap_socket(self.sock,
  File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/ssl.py", line 500, in wrap_socket
    return self.sslsocket_class._create(
  File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/ssl.py", line 1040, in _create
    self.do_handshake()
  File "/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/ssl.py", line 1309, in do_handshake
    self._sslobj.do_handshake()
ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1123)

`release.py`: 2 pull requests associated with a commit, but in reality only one is.

While I was doing an osbuild release, I got the following error from release.py:

...
Info: Found 16 commits since v44 in main:
26a250ca6ef4e5abef16826768e19562e4eaf602
ee96b11faf29c1fa52d919ff7b2ab5424daee5a6
d4f275e024f08ba9dd61381825e875d560cd6c35
7a2b8ac10797e42fb53caed09d7bf4ea377e4da7
94e9f62f63ea4402c884e4ce64382601f6e45a8f
e3515caf01c41cdd994cf728b8a53e823fb90067
3d4be5f05900dc4c19081f29e40c57ef46b87182
97202e53b08f62b10f843d7092afae6d00a7ede1
dccbfb591689c4c7e04f2f652bbda741b68f766b
0b8dbd4bc3ea80c66a1981cf7d44f02b2b9a9f96
fe379b631b1cc2e814a67a2961fba032a4cffc85
a9e1070ce2712eee45180ed82c5f16e8510e22bc
0cbd7898c7822d1e6c667f2376bd06fea901a71e
9786d1f0d62bbf1265b9dc03ba599db64143641d
e97f6ef34e6f8efeccae491f55ad12a0167e6015
bf3c80372a26d958d2971786e46df8fe0a6060f1
Fetching PR 1
Fetching PR 2
Fetching PR 3
Fetching PR 4
Fetching PR 5
Fetching PR 6
Fetching PR 7
Fetching PR 8
Fetching PR 9
Fetching PR 10
Fetching PR 11
Fetching PR 12
Info: There are 2 pull requests associated with a9e1070ce2712eee45180ed82c5f16e8510e22bc - skipping...
Info: https://github.com/osbuild/osbuild/pull/940
Info: https://github.com/osbuild/osbuild/pull/941
Fetching PR 13
Fetching PR 14
Fetching PR 15
Fetching PR 16
...

However when I checked the commit osbuild/osbuild@a9e1070 it seems to have only one PR associated with it, the 940.

This may be caused by a different data which were returned by GitHub API, than what is shown in the Web UI, but I didn't investigate it further.

(CC @ochosi )

Please add licensing information

This repository is lacking licensing information. As such, everything included in this repo is "All rights reserved".
Please note that in order to re-license this project you'll legally need ack from all existing contributors.

Add Python script to automate some steps of the release process

Currently the release process (esp. for osbuild and osbuild-composer) is driven by a series of manual steps which - in parts - could be handled by a script/automation.

release.py version bumping is overeager

release-helper: Populate the GitHub release with the changelog

Currently this part is almost empty and only contains "## Changes with ..."
https://github.com/osbuild/maintainer-tools/blob/main/release.py#L343

release.py: instructions for remotes should be clearer

Info: You have more than two 'git remotes' specified, so guessing the correct one will most likely fail.
Please use the --remote argument to set the correct one.

When I tried this, I didn't know what the script meant by the "correct" remote.

release-helper: Print GitHub PR/release hyperlink after creating it

This would make it easier for the foreperson to double-check if everything was created fine.

release.py: warning for multiple remote shouldn't be shown when --remote is given

> ../maintainer-tools/release.py --remote origin
Info: You have more than two 'git remotes' specified, so guessing the correct one will most likely fail.
Please use the --remote argument to set the correct one.
[...]