Coder Social home page Coder Social logo

orangenote / runebook Goto Github PK

View Code? Open in Web Editor NEW
96.0 96.0 66.0 10.83 MB

๐Ÿ“– arcane Rune Pages manager for League of Legends ๐Ÿ“œ

License: MIT License

JavaScript 86.17% HTML 3.16% CSS 10.68%
electron javascript league-of-legends node rune

runebook's People

Contributors

angeldeejay avatar deancherif avatar fdarveau avatar harrebarre avatar jeddunk avatar orangenote avatar paolostyle avatar passzivsurmo avatar secretsoup avatar wabosh avatar zernico avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

runebook's Issues

Portability. Offline Location of Local Pages

Hi, where are the local pages stored on disk. I want to copy the current builds on another pc and im wondering if copying the whole RuneBook folder would do the job. At first i thought the pages were stored in the config.json file but i couldn't find it.

An offline export of all the local pages would be a good feature to have

Final Builds

Is this a planned feature?

Having build orders or a couple of BO with the highest win rate on the app would probably make this app an essential for playing.

Is this something you'd consider doing in the future?

App Window Position with multiple monitors

Hi, i love your app very much, however i encountered a problem that, I have 2 monitors when i am playing i use the app on 2nd monitor, sometime, i need to connect the 2nd screen to my notebook, the app will still launch into the "2nd" monitor's position only with 1 monitor connected, which i can not access.

Dark theme

Hello, little suggestion on the black theme.
This does not change the parameter menu, which creates a high contrast between the application and the option menu.

rename/reorder local pages

It would be great to have a way to rename/reorder local pages inside RuneBook.


P.S. i'm glad for your efforts on this... We desperately need per champion rune page configs, because with so many champions, and so many bans, and autofill, and counter-picking .. 20 rune pages is not enough, and trying to "race enter" a rune page as last pick is really frustrating.

Broken

Apparently new version of runes has come out and app stopped working.

On start. Have a grid off all champions

When loading up you are expecting the user to remember every champion they want to know rune pages for. What if you just wanted to browse random champions, as well as having a default local runepage to use without having to download one, this is especially targeted at players who are new to the game and rune system. When i play i use this, its just a base for each champion runes. Thoughts?

Open external links bug.

The more you move between tabs the more duplicate external links are opened when a hyperlink is clicked.

Auto select

Auto select keeps selected champion i played/picked in a previous lobby. I have to toggle option to change selected champion, should it work like this?

https://a.doko.moe/iriurk.webm (sry for music in the background)

Check patch version for builds

Check patch version before using build, otherwise you might end up with build that isn't possible to make (for example this skarrner build is for patch 7.23 and cannot be used on current patch).
image
image

Ability to clear the current champion

I understand the current logics of the app, however my other suggestion here, the ability to clear the current champion selected would bring you back to the grid of champions to browse.

u.gg tab does not show runes for all champions

Hi there,

For some reason, the U.GG tab does not show runes for all champions. For example, I've attached a screenshots showing that Rune Book cannot display runes for Mordekaiser, but it will display runes for Miss Fortune.

runebook_morde

runebook_mf

Application Window Unresponsive to Windows Shortcuts

The client doesn't seem to react when attempting to move/resize it using [WIN] + [Direction Key]

This has caused a fatal error for me after downsizing from 2 monitors to 1. The Runebook application is still opening on a nonexistent second monitor, and cannot be moved through standard means.

Add item sets

Item sets are clearly out of the scope of the original project. But given the convenience of popping a rune page into the LCU, and the nice third party plugin integration, it would be really convenient to be able to pop an item set build before the game starts as well. This would make the app more into a great one-click place to plan out a game before loading in.

I'm willing to contribute to this or other issues.

Game client anti-cheat changes going live

Will Runebook be hit by this? Can you get a new confirmation that it's ok to use? I've been using for a good time now but after this statements i'm kinda afraid to use it.

Refactor the view layer

I found Riot and Freezer easy to learn. But I have the impression that I'm not using them properly.

So currently the code for the view layer and the way I manage the store are a bit messy and they might need some refactoring or even an entire rewrite, if I consider migrating the view layer to a better framework like Vue or React, as suggested by @BonusPlay.

Still unsure, probably short term refactor, long term rewrite.

Garena support ?

Apparently seems to be disconnected when garena client is open ...

I need help to try and add functionality

Hey,

I was wondering if it's a good idea to perhaps add probuilds.
We could add a button that adds runes from probuilds, and then also includes a link to the page where it got the runes from to quickly check the build :)
Could you tell me where in the code you'd add a new site, and how I'd create a button?
I'll try do it and fork and a pull request if you like the idea.

Kind Regards.

Champion search resets when any player locks in

While searching for a champion to get rune pages for (before locking in), the search is cleared as well as any results whenever any player locks in. Only happens when auto select is enabled.

Please add support for u.gg

U.gg is a pretty new site for getting champion statistics, but they have good data, and apparently collect from a very large set of games. Would be great if they were a source for this app!

[Suggestion] Runes on auto-pilot

So here's a suggestion, there could be an option to disable auto-pilot, what that would do is use the Auto select feature to find which champion you are playing and automatically apply the HW or MF runes (option in the settings) and from what provider the user wants as well (champion.gg, runes LoL etc) the provider would be selectable in the settings as well. Basically you wouldn't have to touch your runes and it'd all be done automatically, any thoughts? Also another little suggestion, if a user enables auto-select, have that be saved so the next time RuneBook is launched auto-select is already enabled rather than having to enable it again.

Hover animations

Add hover animations for runes to display names and their description. Also a description for these
image

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.