openzipkin / zipkin-php-example Goto Github PK

hi, i am using this example , followed your guide, when i input curl http://localhost:8081 in terminal, i got this error blow

<br />
<b>Fatal error</b>:  Uncaught TypeError: Argument 2 passed to Zipkin\Reporters\Http::__construct() must be of the type array, object given, called in /Users/admin/private/zipkin-php-example/functions.php on line 18 and defined in /Users/admin/private/zipkin-php-example/vendor/jcchavezs/zipkin/src/Zipkin/Reporters/Http.php:29
Stack trace:
#0 /Users/admin/private/zipkin-php-example/functions.php(18): Zipkin\Reporters\Http-&gt;__construct(Object(Zipkin\Reporters\Http\CurlFactory), Object(Monolog\Logger))
#1 /Users/admin/private/zipkin-php-example/frontend.php(11): create_tracing('frontend', '127.0.0.1')
#2 {main}
  thrown in <b>/Users/admin/private/zipkin-php-example/vendor/jcchavezs/zipkin/src/Zipkin/Reporters/Http.php</b> on line <b>29</b><br />

i am a java programer，try to build tracing system between java and php， need some help @jcchavezs

• I am javaer,not familar with php(the best language in the world).when run the example, fail in the backend.php Line6
  require_once __DIR__ . '/vendor/autoload.php';
  when run composer install, everything is ok.Do we need to polish up the doc for beginner like me?if so,I can give a PR.

• the traces of this example is too simple,can we do some random calls to make the traces more sophisticated, let users see the zipkin's power?

• if our PHP applications use zipkin,Does zipkin intrude too much into origin PHP codes?e,g

       $span->setKind(Zipkin\Kind\SERVER);
       $span->setName('parse_request');
  

  Does PHP has something like filter,annotation or AOP?

All repositories in the org are moving towards github actions.

Ping @basvanbeek