Coder Social home page Coder Social logo

vertx-http-example's People

Contributors

akoniar avatar alrubinger avatar cescoffier avatar cmoulliard avatar dependabot-preview[bot] avatar dependabot-support avatar dependabot[bot] avatar dipak-pawar avatar edewit avatar gastaldi avatar hemanik avatar rawlingsj avatar rdruss avatar slavokrupa avatar spisiakm avatar

Watchers

 avatar  avatar  avatar

vertx-http-example's Issues

License names mismatch

Hi,
there are a few name mismatches of licenses between licenses.xml and rh_license_list.json :

  • artifact org.hamcrest:hamcrest-core:1.3 has The 2-Clause BSD License license name, but the closest name in rh_license_list.json is BSD 2-clause "Simplified" License
  • same goes for artifact org.hamcrest:hamcrest-library:1.3
  • also dk.brics.automaton:automaton:1.11-8 has the same name problem
  • arifact org.yaml:snakeyaml:1.15 has license name Apache License Version 2.0, but should be Apache Software License 2.0. Also url of the local license (LICENSE.txt) does not exist.

Test script only runs against currently updated master

In looking at the test.sh script, the application gets configured with this line:

oc new-app --template=vertx-http-booster -p SOURCE_REPOSITORY_URL=https://github.com/openshiftio-vertx-boosters/vertx-http-booster

which clones the existing repo from master. This implies that the test script cannot be used for testing changes without having the code checked in and merged. Perhaps it could be modified to accept the organization location which can be changed to your local repo. Then you would only have to check in your changes on your own fork to run the tests.

I may be misunderstanding the purpose of the test, though, so I thought I'd put in the issue to have the discussion.

test fails

I just used the next git tag and created a project with the openshift.io wizard (code is here: https://github.com/jstrachan/demovertx19) and the test fails:

[INFO] --- maven-surefire-plugin:2.19.1:test (default-test) @ demovertx19 ---
[INFO] Surefire report directory: /home/jenkins/workspace/strachan_demovertx19_master-NPNMNXXB7CZ2N3WTGCFB7QXUDHTNKPZKZGT3UDWCENF2SESQOAIA/target/surefire-reports

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running io.openshift.booster.HttpApplicationTest
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
May 22, 2017 2:46:38 PM io.netty.util.internal.MacAddressUtil defaultMachineId
WARNING: Failed to find a usable hardware address from the network interfaces; using random bytes: e5:f6:d8:93:5e:37:e9:09
Server starter on port 8080
Server starter on port 8080
sh-4.2$ exit
exit
Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 241.335 sec <<< FAILURE! - in io.openshift.booster.HttpApplicationTest
callGreetingTest(io.openshift.booster.HttpApplicationTest)  Time elapsed: 121.139 sec  <<< ERROR!
java.util.concurrent.TimeoutException

callGreetingWithParamTest(io.openshift.booster.HttpApplicationTest)  Time elapsed: 120.016 sec  <<< ERROR!
java.util.concurrent.TimeoutException


Results :

Tests in error: 
  HttpApplicationTest.callGreetingTest ? Timeout
  HttpApplicationTest.callGreetingWithParamTest ? Timeout

Tests run: 2, Failures: 0, Errors: 2, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 04:16 min
[INFO] Finished at: 2017-05-22T14:50:38+00:00
[INFO] Final Memory: 37M/497M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on project demovertx19: There are test failures.
[ERROR] 
[ERROR] Please refer to /home/jenkins/workspace/strachan_demovertx19_master-NPNMNXXB7CZ2N3WTGCFB7QXUDHTNKPZKZGT3UDWCENF2SESQOAIA/target/surefire-reports for the individual test results.
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on project demovertx19: There are test failures.

Please refer to /home/jenkins/workspace/strachan_demovertx19_master-NPNMNXXB7CZ2N3WTGCFB7QXUDHTNKPZKZGT3UDWCENF2SESQOAIA/target/surefire-reports for the individual test results.
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
	at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
	at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
	at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
	at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
	at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
	at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
	at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
	at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoFailureException: There are test failures.

Please refer to /home/jenkins/workspace/strachan_demovertx19_master-NPNMNXXB7CZ2N3WTGCFB7QXUDHTNKPZKZGT3UDWCENF2SESQOAIA/target/surefire-reports for the individual test results.
	at org.apache.maven.plugin.surefire.SurefireHelper.reportExecution(SurefireHelper.java:91)
	at org.apache.maven.plugin.surefire.SurefirePlugin.handleSummary(SurefirePlugin.java:320)
	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:892)
	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:755)
	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
	... 20 more
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.