openshift-vertx-examples / vertx-crud-example-redhat Goto Github PK

View Code? Open in Web Editor NEW

1.0 1.0 6.0 378 KB

License: Apache License 2.0

XSLT 4.05% HTML 84.07% Java 9.54% Shell 2.20% TSQL 0.14%

vertx-crud-example-redhat's People

Contributors

Stargazers

Watchers

Forkers

spisiakm ladicek hemanik rdruss penehyba rohankanojia-forks

vertx-crud-example-redhat's Issues

JdbcProductStore - assumes name and stock are always sent

Looking at the code for JdbcProductStore (along with testing curl requests in documentation [1]) it is apparent that the assumption is that both name and stock will always be sent in (either PUT or POST). If stock is not included, then validation breaks. I would have assumed the following behavior:

for Create (POST) if just the name is included, the stock should be defaulted to 0
for Update (PUT) if just the name is included, either the fruit for the id is retrieved and the existing stock is used or just the name is updated for that id.

One question for Update is whether you can PUT just a stock quantity to the specific id. This would have a similar effect to just doing a PUT with name in that just the stock quantity is updated using either a fetch and update or just update strategy.

[1] https://appdev.openshift.io/docs/vertx-runtime.html#mission-crud-vertx section 3.3.6 Create and Update sections

Determine why "my-database" can't be changed in database.yaml

Oddly enough, when all references to my-database in database.yaml are change to anything other than that, the verify Maven target is not successful based on not being able to connect to the database.

Cannot run test.sh more than once without having to delete project first

Rodneys-MacBook-Pro:vertx-crud-booster-redhat rruss$ .openshiftio/test.sh 
imagestream.image.openshift.io "my-database" unchanged
deploymentconfig.apps.openshift.io "my-database" configured
service "my-database" unchanged
template.template.openshift.io "vertx-crud-booster" unchanged
--> Deploying template "myproject/vertx-crud-booster" to project myproject

     vertx-crud-booster
     ---------
     This template creates a Vert.x application intereacting with a database.

     * With parameters:
        * Source URL=https://github.com/openshiftio-vertx-boosters/vertx-crud-booster-redhat
        * Source Branch=master
        * Source Directory=.
        * GitHub Webhook Secret=***secret*** # generated

--> Creating resources ...
    error: imagestreams.image.openshift.io "crud-vertx" already exists
    error: imagestreams.image.openshift.io "runtime-crud-vertx" already exists
    error: buildconfigs.build.openshift.io "crud-vertx" already exists
    error: secrets "my-database-secret" already exists
    error: services "crud-vertx" already exists
    error: deploymentconfigs.apps.openshift.io "crud-vertx" already exists
    error: routes.route.openshift.io "crud-vertx" already exists
--> Failed

[ERROR] testCreatingWithNoPayload(io.openshift.example.OpenShiftIT)  Time elapsed: 5.916 s <<< ERROR!
java.lang.NoClassDefFoundError: org/hamcrest/Matchers
        at io.openshift.example.OpenShiftIT.testCreatingWithNoPayload(OpenShiftIT.java:150)
Caused by: java.lang.ClassNotFoundException: org.hamcrest.Matchers
        at io.openshift.example.OpenShiftIT.testCreatingWithNoPayload(OpenShiftIT.java:150)

openshift-vertx-examples / vertx-crud-example-redhat Goto Github PK

vertx-crud-example-redhat's People

Contributors

Stargazers

Watchers

Forkers

vertx-crud-example-redhat's Issues

JdbcProductStore - assumes name and stock are always sent

Determine why "my-database" can't be changed in database.yaml

Cannot run test.sh more than once without having to delete project first

Doesn't work with versions of fmp after 4.1.0

Update booster to use Rx Java 2

Changes needed to update RestAssured to 4.0.0

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent