The nti.analytics from opennti

nti.analytics's People

Contributors

Watchers

nti.analytics's Issues

Test Failures under PyPy 2.7 but not CPython 2.7

There are two failing tests when run under PyPy. All tests pass under CPython. The failing assertion are in two tests:

https://github.com/NextThought/nti.analytics/blob/master/src/nti/analytics/database/tests/test_resources.py#L166
https://github.com/NextThought/nti.analytics/blob/master/src/nti/analytics/database/tests/test_resources.py#L269

Both failures are similar:

Failure in test test_video_play_speed (nti.analytics.database.tests.test_resources.TestCourseResources)
Traceback (most recent call last):
  File "///pypy2.7-v7.3.1-osx64/lib-python/2.7/unittest/case.py", line 329, in run
    testMethod()
  File "///nti.dataserver-pypy/sources/nti.analytics/src/nti/analytics/database/tests/test_resources.py", line 269, in test_video_play_speed
    assert_that( play_speed.old_play_speed, is_( str( old_play_speed ) ) )
  File "///nti.dataserver-pypy/eggs/PyHamcrest-1.9.0-py2.7.egg/hamcrest/core/assert_that.py", line 43, in assert_that
    _assert_match(actual=arg1, matcher=arg2, reason=arg3)
  File "///nti.dataserver-pypy/eggs/PyHamcrest-1.9.0-py2.7.egg/hamcrest/core/assert_that.py", line 57, in _assert_match
    raise AssertionError(description)
AssertionError: 
Expected: '1'

     but: was <1>

These tests both pass in CPython. I've stepped through our code (up to the point where we go in sqlalchemy) and nothing jumps out at me. Note the tests pass play speed in as an int but in CPython the object we are asserting against the property has become a str and in PyPy it is still an int

Recommend Projects