If You're Typing the Word MCRYPT Into Your PHP Code, You're Doing It Wrong about magento-lts

[Flyingmana]

👍
And yes, there are platforms without openSSL out there, but we can sure add alternates then.

[sreichel]

Reference ... Inchoo/Inchoo_PHP7#98

[inluxc]

This is a nice read about this problem.
https://www.zimuel.it/slides/phpce2017#/

[colinmollenhour]

Just pushed PR for this issue. See #506

[kkrieger85]

Close due to #506

[seansan]

Should this also be changed? https://github.com/OpenMage/magento-lts/blob/1.9.4.x/lib/Zend/Filter/Encrypt.php#L85

[colinmollenhour]

Should this also be changed? https://github.com/OpenMage/magento-lts/blob/1.9.4.x/lib/Zend/Filter/Encrypt.php#L85

Is that code used anywhere? I'd rather remove unused code than try to fix it.

[seansan]

with mcryptcompat all should work #1211

…

On Wed, Sep 30, 2020 at 11:55 PM Colin Mollenhour ***@***.***> wrote: Should this also be changed? https://github.com/OpenMage/magento-lts/blob/1.9.4.x/lib/Zend/Filter/Encrypt.php#L85 Is that code used anywhere? I'd rather remove unused code than try to fix it. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#129 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAE7I22RDWOGTBYJT5T37O3SIOSOVANCNFSM4CUBB27Q> .