Unable to save customer in admin console with DOB set to empty about magento-lts

[fballiano]

Hi, wasn't it fixed by #3374 (which I think was released only in v20)?

[massa-man]

I don't think so. The issues seem different. This is an issue with the core form Date & DateTime filters in Admin (used internally by the EAV from components - such as the customer EAV models - and other forms), while the issue you mentioned seem to be specific to the customer registration form in the frontend which uses three different elements for DD, MM, and YYYY

[kiatng]

Following the steps described, I cannot replicate with ver20.3.0 and PHP8.2.

[massa-man]

I found this old PR #1457 and related bug which is the exact same as I am experiencing. This does not appear to happen on new installations, but it does happen with older/upgraded installations (in my case we migrated to OpenMage 19.5.2 from Magento CE 1.9.4.5, but or original magento installation - and DB - comes from 1.4).

It is clear from the issues reported both in OpenMage as well as Magento2 repos, that this is an issue which impacts quite a few people upgrading, and the fix in my view is quite simple and logical, there is no need to filter a Date when the input is empty, if anything this should also make for better and more performant code.

[fballiano]

does it happen on OM 20.3.0?

[massa-man]

Not sure, I have not upgraded to OM 20.x yet, we are still on 19. It will require quite a bit of work for me to move to OM 20 since we have in-house and community modules that need to be upgraded

[pquerner]

Maybe its the database settings?
Can you show a DESCRIBE of that table?

[sreichel]

See Shardj/zf1-future#402

<?php

require_once('app/Mage.php'); //Path to Magento
umask(0);
Mage::app();

$test = new Zend_Locale_Math_PhpMath();
$test->Sub(0, '');

[massa-man]

Sure, the Customer DOB is stored in magento's EAV model for the customer, in table customer_entity_datetime

mysql> DESCRIBE customer_entity_datetime;
+----------------+-------------------+------+-----+---------------------+----------------+
| Field          | Type              | Null | Key | Default             | Extra          |
+----------------+-------------------+------+-----+---------------------+----------------+
| value_id       | int               | NO   | PRI | NULL                | auto_increment |
| entity_type_id | smallint unsigned | NO   | MUL | 0                   |                |
| attribute_id   | smallint unsigned | NO   | MUL | 0                   |                |
| entity_id      | int unsigned      | NO   | MUL | 0                   |                |
| value          | datetime          | NO   |     | 0000-00-00 00:00:00 |                |
+----------------+-------------------+------+-----+---------------------+----------------+
5 rows in set (0.01 sec)

I see the @sreichel provided a patch in zf1-future to fix this in the parent class Zend_Locale_Math_PhpMath, but that PR has not been merged yet, and even if it does, it might take sometime to be released and then we would need to upgrade OM 19.x to the new version of zf1-future which might have other implications.

I still think the patch I provided should be merged even if this is fixed elsewhere, it makes no sense to me to try and filter a date and/or datetime input doing time consuming conversions to and from internal locale and application locale when the input is empty.

[sreichel]

@massa-man the PR targets main branch and has to be backported. I'm okay with it, but i remember that the v19.x branch is abandoned.

If you use composer, you can patch this file until the next zf1 release (that hopefully comes within next days)

However, +1 for the PR.

[sreichel]

@massa-man The PR has been merged. With composer you can use dev-master until next release.

edit: updating zf1 is safe!