openforis / fra-platform Goto Github PK

• Add route to power bi (/statisticalFactsheets) that includes in an iframe the PowerBI report
• Update header with right links (See attached mockups
• Translations for 'Statistical factsheets'
  es: Fichas estadísticas
  fr: Fiches statistiques
  ru: Статистические бюллетени

In appView do not dispatch fetchCountryInitialData, but in each individual Section fetch related data

• Create api and repository to get statistical factsheets data
• Api must return data from last version schema
• Create PowerBi as per mockup
• Make PowerBi publicly available

StatisticalFactsheets.pdf

Reset password functionality seems to be broken.
To be fixed in master branch

• Refactor webapp folder structure as per doc

In validators state numbers difference with tolerance is repeated several times.
e.g.

const tolerance = -1
const difference = NumberUtils.sub(forest, value)
return NumberUtils.greaterThan(difference, tolerance)

Add a method to NumberUtils that takes care of the logic.

It's used in

• otherLandWithTreeCoverValidatorState
• assessmentStateValidator
• extentOfForestValidatorState
• forestCharacteristicsValidatorState, growingStockValidatorState,

When a user has role collaborator with restricted access to table, when navigating to view which he doesn't have access, system show error 503

• User should be able to see the data without getting errors

To Test:

• Landing -> Manage collaborators -> add a user with role collaborator and set Table access 1a, 1b, 1c
• Log in with that user, and go to section 1d. System gives error 403 on getLatestAuditLogTimestamp api call

• Refactor Comments components to functional
• Refactor Comments using state objects
• Refactor webapp/components/description/* using state objects
• All tables National Data and Analysis and processing of national data hide validation

• Hide download questionnaire
• Hide file upload
• Hide Review panel

• Fix PanEuropeanView in public view

• redux state
• webapp folder structure

• Use /admin for admin routes
• Add route to basePaths
• Update link using basePaths in webapp/app/components/header/components/userInfo.js

• Hide all table data validations

In webapp/app/components/navigation/navigation.js component, line 25, do not iterate anymore on the deprecated assessments object,
but instead use FRA common/assessment/fra.js and update navigation assessment section

Best candidates are:

font-family: 'Inter', sans-serif;
font-family: 'Libre Franklin', sans-serif;

• Do not store data in redux state. Use state component local state
• When fetching data, do not show error
• Move webapp/app/assessment/components/description/DescriptionEditor.js under webapp/app/components and call it RichTextEditor
• The folder webapp/app/assessment/components/description should be moved under webapp/app/assessment/components/section/components/descriptions and renamed to components
• Remove all modules related to redux store

(use useGetRequest as : https://github.com/openforis/arena/blob/master/webapp/commonComponents/hooks/useAsyncGetRequest.js)

const { data = null, loading, dispatch: fetchData } = useGetRequest(`/api/country/descriptions/${countryIso}/${section}/${descriptionType}`)

useEffect(fetchData, [])

Descriptions tooltip always show tooltip error event when text is entered

• Do not show error when description is filled
  

Paste values must be implemented in

• Implement it for dataTables
• Implement cell Sanitizer
• Implement update mirror value for 1c
• Implement paste for ODP tables
• Implement update 2a avg/total

Add prettier to project to setup auto formatting of the code
https://prettier.io/docs/en/install.html

• add prettier configuration to .prettierrc file https://prettier.io/docs/en/configuration.html
• add configuration settings to prettier file https://prettier.io/docs/en/options.html
• add pre-commit hook (lint-staged or pretty-quick or bash script?) https://prettier.io/docs/en/precommit.html
• format all code (to do when no-one else is working on the code)

• show user image instead of name
• show admin link in the popover user menu
• remove show / hide sidebar text

CountryRepository.getCountry requires schema by VersionService.getDatabaseSchema
(see panEuropean/api.js for example)

• Refactor TableWithOdp into smaller and functional components
• Merge GenerateValues into TableWithOdp
• Hide validations in public view

• Define apis in common/apiRoutes.js
• Wrap all axios calls in webapp/main/api.js
• Replace all client side api requests
• Replace all server side api request

// ====== common/apiRoutes.js
const tableData = (countryIso, tableName) => `/traditionalTable/${countryIso}/${tableName}`

module.exports = {
    tableData,
}

// ====== webapp/main/api.js
import axios from 'axios'

const instance = axios.create({
  baseURL: '/api/',
  timeout: 1000,
})

export const { get } = instance

// ====== actions.js
import * as ApiRoutes from '@common/apiRoutes'
import * as Api from '@webapp/main/api'

export const fetchData = () => dispatch => {
    const { data } = await Api.get(ApiRoutes.tableData('countryIso', 'tableName')))
}