opendataservices / dokkusd-client

DokkuSD client - Dokku Super Deployer

See docs directory or https://dokkusd-client.readthedocs.io/en/latest/

dokkusd-client's Issues

Can we add a command option?

See fce6423

This would just let app.json define any dokku command to run.

For security, I said $APP_NAME had to be in the command.

But I realised the security of making sure $APP_NAME is there is probably not enough.

You can run

dokku apps:list $APP_NAME 

Which becomes

dokku apps:list whateveryouwant

And you'll still get a full list of apps on the servers.

So there may be other holes where people can do destructive actions on other apps on the server.

User/password options only add new users, they don't change existing users

If you change the password for an existing user it won't work

Check App Names

App name must begin with lowercase alphanumeric character, and cannot include uppercase characters, colons, or underscores

Enforce this is the deployer, so if invalid app name clean it up. This is better than just not running, I think.

Set NGINX max body size from Env var or command line

(eg not app.json), so we can keep value of this secret

Need to be able to do ps:scale commands

Otherwise have to set in app.json
https://dokku.com/docs/processes/process-management/#manually-managing-process-scaling

And then you can't change it later.

---

We also don't want situation where any deploy changes a value that might have been tweaked on the server. For now, this is a useful feature on dev server but don't use on live.

Need to be able to set dokku nginx:set node-js-app proxy-read-timeout

Afterwards must call proxy:build-config

https://dokku.com/docs/networking/proxies/nginx/#specifying-a-read-timeout

Docs error

https://dokkusd-client.readthedocs.io/en/latest/reference/app-resources.html#nginx

"You can clear a value and use the default with:"

Same code, what is that meant to be?

Env vars with new lines in

Might make this error:

xargs: unmatched single quote; by default quotes are special to xargs unless you use the -0 option
 !     At least one env pair must be given

Look into.

Also, in this case there was a trailing new line that was not wanted - should we just strip values?

What is this?

This looks interesting, but I'm at a loss as to what it is.

Please could the README and/or repo description and/or the docs be updated to describe what this is, what it does, and when someone might want to use it?

If people put slashes in branch names, make sure it works

When branch names are passed direct to tool in GitHub Actions