openbytedev / burnt-sushi

Spotify AdBlocker for Windows

burnt-sushi's Issues

injecting blocker results in error after update

running burnt-sushi as an executable path in elevated Command Prompt gives verbose errors.
everything up to injecting the actual dll is fine, and then the program terminates.

---full console log file below (note: user-dependent paths have been substituted with their appropriate environment variables)---

C:\Windows\System32>"%HOMEPATH%\Downloads\BurntSushi.exe"

C:\Windows\System32>[DEBUG] Attached to console
[INFO] BurntSushi v0.2.0
[INFO] Looking for Spotify...
[INFO] Found Spotify (PID=26072)
[INFO] Loading filter config...
[DEBUG] Looking for filter config according to cli args...
[DEBUG] Looking for filter config next to executable...
[DEBUG] Looking for filter config at '%HOMEPATH%\Downloads\filter.toml'
[DEBUG] Loading default filter config...
[INFO] Preparing blocker...
[DEBUG] Looking for blocker according to cli args...
[DEBUG] Looking for blocker next to executable...
[DEBUG] Looking for blocker at '%HOMEPATH%\Downloads\BurntSushiBlocker_x86.dll'
[DEBUG] Looking for existing blocker in temporary directory...
[DEBUG] Looking for blocker at '%APPDATA%\Local\OpenByteDev\BurntSushi v0.2.0\BurntSushiBlocker_x86.dll'
[DEBUG] Found blocker at '%APPDATA%\Local\OpenByteDev\BurntSushi v0.2.0\BurntSushiBlocker_x86.dll'
[INFO] Injecting blocker...
thread 'main' panicked at 'called Result::unwrap() on an Err value: RemoteIo(Os { code: 193, kind: Uncategorized, message: "%1 is not a valid Win32 application." })', src\blocker.rs:129:52
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

EOF

Automaticly closes after opening spotify, (v.0.3.0)

Runned it as admin, installed it with the .msi installer, and also with the exe. One time it just said Injecting in spotify....... and never injected, i waited a solid 15mins. And now nothing shows in console

Closes immediately after startup (v0.3.1)

So I run the app from PowerShell and the output is:

PS C:\Program Files\OpenByte\BurntSushi> .\BurntSushi.exe
PS C:\Program Files\OpenByte\BurntSushi> [DEBUG] Attached to console
[INFO] BurntSushi v0.3.1
[INFO] Looking for Spotify...
thread 'main' panicked at src\blocker.rs:52:17:
internal error: entered unreachable code: Spotify scanner should never stop on its own
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

The content of the log file is:

2024-03-27 20:42:47 [INFO] BurntSushi v0.3.1
2024-03-27 20:42:47 [INFO] Looking for Spotify...
2024-03-27 20:42:47 [INFO] No new release found

The solution is:

Just run the app with administrator privileges and it works fine. Human-readable feedback from the app would be appreciated, e.g.: "Administrator privileges required." Maybe a note in the readme file will suffice.

Please provide a technical overview

I would like to replace EZBlocker 3 with BurntSushi as it seems to be the next successor. But before that, it would be great to know how it is working technically, like your documentation on EZBlocker 3.

Another related question, can it be detected by Spotify?

Optionally self terminate when Spotify exits

I like that the Rust version of this app opens in tray icon. Nice UX improvement.
But when I exit Spotify, this app's tray icon is left running.
Personally, I usually have around 20 tray icons running.
To reduce the icon clutter, I'm hoping that when we call the .exe, we can use a switch to make this process self terminate when spotify exits.

Relationship to developer `BurntSushi`?

Does this project have any relationship to Andrew Gallant, the well known developer of, e.g., ripgrep?

Name of detour crate changed

Hi, I'm the maintainer of the detour fork!

I just renamed the repo/crate, so it's going to break your project, I'm really sorry about that.
But it's now on crates.io now here, so you can add it to your Cargo.toml!

retour = "0.1.0"

Figured I send out issues to the repos using it to avoid any confusion/frustration. Again, sorry about that, but this makes things a lot easier going forward.

Happy hacking! 😄

Instructions on how to build this

Hi. Can you provide an instruction on how to build this application? (preferably from the perspective of after installing Rust for the first time)
Full disclosure, I don't know much about Rust, so I could be doing something wrong.
I tried to run "cargo build" inside the burnt-sushi folder and I got some errors.
I tried to resolve the errors one by one, like installing capnp and using "cargo +nightly build" instead. And there's still more build error.
Can you let us know what command you used to build this app? And is there any special configurations involved?

version 0.2.0 crashing from time to time

After few days of using new version i've noticed burntsushi to be crashing 1-4 times a day over few hours of using. I'm noticing it by return of spotify advertisements. Is there a way to run bruntsushi with redirecting console messages to some log file?

Closing after spotify is open. Happens after 28th July 2023 Update.

Impossible to start Burnt Sushi if Spotify is closed.

According to the console output, it seems that if Spotify exists or isn't started, the app won't start. This prevents me from making it automatically start with the OS.

Example when restarting Spotify to fix connectivity issue with my phone.

[...]
[INFO] Unhooking Spotify...
[TRACE] Stopping RPC...
[TRACE] Stopped RPC
[INFO] Ejecting blocker...
[INFO] Ejected blocker
[INFO] Looking for Spotify...
[INFO] Shutting down...
[INFO] Exiting...

Example when Spotify isn't started.

[INFO] BurntSushi v0.1.0
[INFO] Looking for Spotify...
[INFO] Shutting down...
[INFO] Exiting...

I quickly checked and there's no option to keep the application running in --help and for more confusion, I see someone created issue #2 which mentions that the app stays running, but I don't know how it can be.

Is non-functional as of 3/10/2024

when used with current spotify version, visual ads still appear.

It does not work.

I have tried it many times. Open Spotify, open Burnt Sushi. The icon works, in the taskbar, says Hello! and everything.
The ads keep on coming. And after a while, Burnt Sushi closes itself anyways without me doing anything. It used to work fine not too long ago.

Do I need to run it once or every time I open Spotify?

Kinda stupid question, but how to use it? This isn't mentioned in the readme, isn't it?