Coder Social home page Coder Social logo

Comments (5)

bradbishop avatar bradbishop commented on June 27, 2024 1

The good part is that the C++ code does not have to call the system units one-by-one

If we have scripts calling other scripts I wonder if that could be simplified or reduced down to a single script?

Are there any other benefits besides the one above to using systemd over a more conventional implementation for launching scripts/programs, such as this one:
https://github.com/openbmc/jsnbd/blob/master/nbd-proxy.c#L379

from phosphor-bmc-code-mgmt.

leiyu-bytedance avatar leiyu-bytedance commented on June 27, 2024

Is it possible to add some Wants/Before/After configs in the unit files to solve the issue?
The good part is that the C++ code does not have to call the system units one-by-one anymore, instead, it calls one systemd unit, and the unit will start other systemd units by sequence.

from phosphor-bmc-code-mgmt.

anoo1 avatar anoo1 commented on June 27, 2024

Is it possible to add some Wants/Before/After configs in the unit files to solve the issue?

Partially. The remaining issue is that we want the function to return until the script (run by a service file) is complete. For example a Delete or Set Priority call would not return to the caller until the operations finished.

Are there any other benefits besides the one above to using system over a more conventional implementation for launching scripts/programs

Hadn't thought of that. That could be an option, instead of executing the script via a service file.

from phosphor-bmc-code-mgmt.

anoo1 avatar anoo1 commented on June 27, 2024

Adding function for running commands in child process:
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-bmc-code-mgmt/+/39844

from phosphor-bmc-code-mgmt.

anoo1 avatar anoo1 commented on June 27, 2024

Closing. First function (factory reset) migrated to exec instead of using systemd service files.

from phosphor-bmc-code-mgmt.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.