Incorrect/Spurious BMC firmware functional state about phosphor-bmc-code-mgmt

[gkeishin]

@anoo1 @gtmills @geissonator This i noticed today with master

[gtmills]

Hit this as well.

Hit on 2.9.0-dev-182-g794e2e55b .

{
  "data": {
    "/xyz/openbmc_project/software/00f13caf": {
      "Activation": "xyz.openbmc_project.Software.Activation.Activations.Active",
      "Associations": [
        [
          "inventory",
          "activation",
          "/xyz/openbmc_project/inventory/system/chassis/motherboard/boxelder/bmc"
        ]
      ],
      "Path": "",
      "Priority": 1,
      "Purpose": "xyz.openbmc_project.Software.Version.VersionPurpose.BMC",
      "RequestedActivation": "xyz.openbmc_project.Software.Activation.RequestedActivations.None",
      "Version": "2.9.0-dev-182-g794e2e55b"
    },
    "/xyz/openbmc_project/software/00f13caf/inventory": {
      "endpoints": [
        "/xyz/openbmc_project/inventory/system/chassis/motherboard/boxelder/bmc"
      ]
    },
    "/xyz/openbmc_project/software/00f13caf/software_version": {
      "endpoints": [
        "/xyz/openbmc_project/software"
      ]
    },
    "/xyz/openbmc_project/software/125b4873": {
      "Activation": "xyz.openbmc_project.Software.Activation.Activations.Active",
      "Associations": [
        [
          "inventory",
          "activation",
          "/xyz/openbmc_project/inventory/system/chassis/motherboard/boxelder/bmc"
        ]
      ],
      "Path": "",
      "Priority": 0,
      "Purpose": "xyz.openbmc_project.Software.Version.VersionPurpose.BMC",
      "RequestedActivation": "xyz.openbmc_project.Software.Activation.RequestedActivations.None",
      "Version": "2.9.0-dev-182-g794e2e55b"
    },
    "/xyz/openbmc_project/software/125b4873/inventory": {
      "endpoints": [
        "/xyz/openbmc_project/inventory/system/chassis/motherboard/boxelder/bmc"
      ]
    },
    "/xyz/openbmc_project/software/125b4873/software_version": {
      "endpoints": [
        "/xyz/openbmc_project/software"
      ]
    },
    "/xyz/openbmc_project/software/224cd310": {
      "Activation": "xyz.openbmc_project.Software.Activation.Activations.Active",
      "Associations": [
        [
          "inventory",
          "activation",
          "/xyz/openbmc_project/inventory/system/chassis"
        ]
      ],
      "ExtendedVersion": "op-build-v2.0.16-2-gb9a4410,buildroot-2018.11.3-12-g222837a,skiboot-v6.0.20,hostboot-8591ded-p85fa19f,occ-8fa3854,linux-4.19.57-openpower1-p56e1d80,petitboot-v1.7.5-p45b698d,machine-xml-2d9c9f0,hostboot-binaries-hw072719a.op920,capp-ucode-p9-dd2-v4,sbe-b6ee17b,hcode-hw072719a.op920",
      "Path": "",
      "Priority": 0,
      "Purpose": "xyz.openbmc_project.Software.Version.VersionPurpose.Host",
      "RequestedActivation": "xyz.openbmc_project.Software.Activation.RequestedActivations.None",
      "Version": "IBM-witherspoon-OP9-v2.0.15-2.9"
    },
    "/xyz/openbmc_project/software/224cd310/inventory": {
      "endpoints": [
        "/xyz/openbmc_project/inventory/system/chassis"
      ]
    },
    "/xyz/openbmc_project/software/224cd310/software_version": {
      "endpoints": [
        "/xyz/openbmc_project/software"
      ]
    },
    "/xyz/openbmc_project/software/active": {
      "endpoints": [
        "/xyz/openbmc_project/software/224cd310",
        "/xyz/openbmc_project/software/125b4873",
        "/xyz/openbmc_project/software/00f13caf"
      ]
    },
    "/xyz/openbmc_project/software/apply_time": {
      "RequestedApplyTime": "xyz.openbmc_project.Software.ApplyTime.RequestedApplyTimes.OnReset"
    },
    "/xyz/openbmc_project/software/functional": {
      "endpoints": [
        "/xyz/openbmc_project/software/224cd310",
        "/xyz/openbmc_project/software/125b4873",
        "/xyz/openbmc_project/software/00f13caf"
      ]
    },
    "/xyz/openbmc_project/software/updateable": {
      "endpoints": [
        "/xyz/openbmc_project/software/125b4873",
        "/xyz/openbmc_project/software/00f13caf"
      ]
    }
  },
  "message": "200 OK",
  "status": "ok"
}

[gkeishin]

Fix from @anoo1

https://gerrit.openbmc-project.xyz/#/c/openbmc/meta-phosphor/+/31995/