X-Ray Remote Sampler does not poll for new rules about opentelemetry-java-contrib

[anuraaga]

The relevant code is here which does reschedule.

https://github.com/open-telemetry/opentelemetry-java-contrib/blob/main/aws-xray/src/main/java/io/opentelemetry/contrib/awsxray/AwsXrayRemoteSampler.java#L147

I know @wangzlei saw some behavior that indicated this may not be happening but just wondering if you were able to confirm the repro steps? During initial testing I could confirm dynamic update of the rules and code hasn't changed since so wondering if it's a corner case

[willarmiros]

I have not confirmed the repro steps, and I wasn't looking at that code which does look good. Maybe @wangzlei can either provide a repro or enable FINE level logs to see if some weird exception is occurring?

[felixscheinost]

I think this issue is still open. I set some breakpoints. The problem is that scheduleSamplerUpdate throws an exception in the following line

    long delay = pollingIntervalNanos + RANDOM.nextInt(jitterNanos);

The reason is that in my case jitterNanos = -1294967296, so negative, which isn't allowed.

Why is it negative? In my case polling interval nanos is the default of 300 s = 3 * 10^11 ns. 3 * 10^11 / 100 = 3 * 10^9 which is bigger than Integer.MAX_VALUE.