Coder Social home page Coder Social logo

Comments (12)

XN137 avatar XN137 commented on August 17, 2024 1

always seen afaict

from opentelemetry-java-contrib.

cyrille-leclerc avatar cyrille-leclerc commented on August 17, 2024

Can you please indicate which version of Maven you are your using?

from opentelemetry-java-contrib.

XN137 avatar XN137 commented on August 17, 2024

we are using 3.9.6 via maven wrapper

from opentelemetry-java-contrib.

cyrille-leclerc avatar cyrille-leclerc commented on August 17, 2024

Thanks, is it a regression or a problem you have always seen?

from opentelemetry-java-contrib.

cyrille-leclerc avatar cyrille-leclerc commented on August 17, 2024

Problem was introduced when the OTel Java SDK AutoConfigure changed the default of otel.metrics.exporter from none to otlp.

Problem is here:

// Change default of "otel.traces.exporter" from "otlp" to "none"
// The impacts are
// * If no otel exporter settings are passed, then the Maven extension will not export
// rather than exporting on OTLP GRPC to http://localhost:4317
// * If OTEL_EXPORTER_OTLP_ENDPOINT is defined but OTEL_TRACES_EXPORTER is not, then don't
// export
Map<String, String> properties = Collections.singletonMap("otel.traces.exporter", "none");

I'll propose a fix asap

from opentelemetry-java-contrib.

cyrille-leclerc avatar cyrille-leclerc commented on August 17, 2024

@XN137 the OTel Maven extension doesn't produce OpnTelemetry metrics or logs. Could you have used the OTel Maven extension in conjunction with adding the Otel Java Agent through the Maven JVM startup parameters?

Note that a fix is in progress on:

from opentelemetry-java-contrib.

XN137 avatar XN137 commented on August 17, 2024

@cyrille-leclerc i dont think our build uses any other plugin or extension directly related to otel, so the answer is most likely no.

our product code generally uses otel and one of the product jars gets loaded through through exec-maven-plugin as part of the build, but not intentionally doing anything with otel.

wondering: were you not able to reproduce these warnings or why does it matter what our build does in terms of merging your changes?

thanks!

from opentelemetry-java-contrib.

cyrille-leclerc avatar cyrille-leclerc commented on August 17, 2024

Sorry for the delay.

I cannot reproduce on my SpringBoot test app but #1276 is definitely a change we have to roll out and it's likely to fix your problem.

Can you please enable an otel collector and list the metrics that are generated to help us understand the cause of the problem?

from opentelemetry-java-contrib.

XN137 avatar XN137 commented on August 17, 2024

can you provide details on how to get that list?

from opentelemetry-java-contrib.

cyrille-leclerc avatar cyrille-leclerc commented on August 17, 2024

A solution to list the produced OTel metrics is to connect the Maven build to a local OTel Collector that uses a metrics pipeline with a "Prometheus Exporter".

After your Maven build has run, you can list all the produced metrics looking at the Prometheus page http://localhost:8889/metrics

  prometheus:
    endpoint: 127.0.0.1:8889
    resource_to_telemetry_conversion:
      enabled: true

from opentelemetry-java-contrib.

XN137 avatar XN137 commented on August 17, 2024

after upgrading opentelemetry-maven-extension to 1.36.0-alpha in our .mvn/extensions.xml local builds seem to no longer log the mentioned warnings

@cyrille-leclerc thanks for the update, we can most likely close this ticket now?

from opentelemetry-java-contrib.

cyrille-leclerc avatar cyrille-leclerc commented on August 17, 2024

Thanks I'm closing

from opentelemetry-java-contrib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.