open-mss / fs_filepicker Goto Github PK

A problem blocks building a docker container for automated tests.

It can be tried by a manual build of the container from the dockerfile
https://github.com/Open-MSS/fsfp-dockertesting

:~/PycharmProjects/fs_filepicker$ docker run -it --mount src=`pwd`,target=`pwd`,type=bind -e FSDIR=`pwd` fsfp:latest
(base) root@c685c24c890a:/# conda activate fsfp--env
(base) root@c685c24c890a:/# cd $FSDIR
(base) root@c685c24c890a:/PycharmProjects/fs_filepicker$ pytest

mostly it shows onle a "Segmentation fault"

once I got
QBasicTimer::start: QBasicTimer can only be used with threads started with QThread Segmentation fault

This is rather one of the last steps before 1.0

The ui elements needs changes to get resized on changing the size of the widget.

Instead of one master function for all kind of dialogs we should seperate those in functions.
similar to QFileDialog.

• getOpenFileName
• getSaveFileName
• getExistingDirectory

replacement of this QFileDialog becomes easier

This makes it also easier in other libraries to write tests by mock too

There are more third party modules available to be used by the filepicker

https://www.pyfilesystem.org/page/index-of-filesystems/

The meta.yaml should be extended by those available as anaconda or conda-forge package
https://conda-forge.org/feedstock-outputs/

optional interesting packages can be added to conda-forge
https://conda-forge.org/#contribute

Description

We pinned pyqt >=5, <5.13 and qt >=5.10, <5.13 because of #32

Changes

We want to release the pinning. This will either need a refactoring on our site or we found a problem on QT itselfs and have to report it there.

How to test

install the newest pyqt version and run the tests

we need further navigations to selected pathes. currently only the recent path is listed in the directory list pull down menu.

This needs to become extended to an amout of 10? used. Navigation elements have to become added.

System Windows 10:
Filepicker lists hidden (system) folders/links on C: or D:. Accessing files/junction like "Dokumente and Einstellungen" cannot be accessed and leads to a crash:

Solution: only show norman/non-hidden files that the user also can see in the Fileexplorer of the system.

we have to identify linked items, e.g. files which are links.

system: windows 10

when I access Folders in the main directory C: the back botton does not bring be back to the main directory C: when different folders were accessed:

seems the example for getSaveFileName is not able to add the directories to the file names

while fs urls internally can use user:password@url we should not show this detail in the file list table

Description

on first click on a file only the cell is marked not the whole line.

only seen yet on main dirs

on pypi there are some more packages. We maybe should maintain the fs.proxy on conda-forge.

and there are others listed too.

https://pypi.org/project/fs.proxy/

Currently only name and file/directory symbols are shown on a list view
This could be enhanced to show also date and size.

currently some modules because of encoding are used in Py2, e.g. unicode
Review for py3 needed.

if we have a fs_url we should end with a seperating slash, e.g.
os.path.join(fs_url, '')

Description

we have to replace in the black workflow
uses: rickstaa/action-black@v1

by the official PSF version https://black.readthedocs.io/en/stable/integrations/github_actions.html

this may be helpful
https://github.com/psf/black/blob/main/.github/workflows/

The picker should have an option to select a bunch of items.

Currently, fs_filepicker only supports the conda package manager, but the pip package manager is widely used. Also the addition of setup docs for local environment setup.

What do you think @ReimarBauer, can I start working on this issue also I have many more suggestions for fs_filepicker

the pyqt table widget has a sort feature. the method has to become added

We need a feature to escape to an other filesystem level, e.g. to a root or home dir.
Currently we have only access to the initial fs_url and not siblings of that url.

instead of a long list of subdirs of an fs_url we may want to show this by a tree.

the file_filter required for QtWidgets.QFileDialog.getOpenFileName is in the format that involves separating filters with ';;' (https://doc.qt.io/archives/qt-4.8/qfiledialog.html#getOpenFileName), but fs.file_picker takes file_filter as a list, that is why the new file_filter is a list of filters.

Open-MSS/MSS#718 (comment)

https://blog.readthedocs.com/migrate-configuration-v2

Description

pytest shows a lot FAILED conftest.py::flake-8::FLAKE8 - AttributeError: 'Application' object has no attribute 'parse_preliminary_op.

How to reproduce

pytest

Screenshots

If applicable, add screenshots to help explain your problem.

Versions

• Operating System : linux, mambaforge

          found a bug, when selecting an item on the files site the selection jumps to an other file

Originally posted by @ReimarBauer in #57 (comment)

sorting should always keep sorted directories on top