open-ibc / ibc-app-solidity-template Goto Github PK

• Start tagging releases and add more granular vibc-core-smart-contracts dependency management.
• Add compatibliity matrix in README

Right now, a lot of the just commands take a flag for universal channel or not.

This could be avoided if adding a flag to the config and separating out config files for different sets of contracts in one repo.

Expected outcomes:

• will make commands even more easy
• will reduce user input error
• should provide automated check to see if contracts set match with the isUniversal flag

The switch-client.js script now flips the config values first before updating the vibc addresses (dispatcher or universal channel handler). So it does reverse flipping the config when an error occurs on the update scripts

This can lead to errors requiring the user to update manually and/or do multiple switches

I've noticed there's potentially some hard to debug situations when for some reason the dApp developer's contracts are pointing to a different dispatcher address and uc handler than in their env variables

In a future with proxy contracts likely this will minimize but still it makes sense to do add some just recipe that queries the involved contracts and checks if the addresses match the env variables

Note: this is meant to happen post deployment, but prior to creating channels / sending packets

https://discord.com/channels/839903468750635039/1213267408370794506/1215270257405468692

Hello, edit:

scripts/create-channel-config.js

Change:

const { getDispatcher } = require('./_get-vibc-sc.js');

to

const { getDispatcher } = require('./_vibc-helpers.js');

polymer-testnet

Dependent on some improvements to ibc-explorer being added to production

I'm seeing a lot of the packet lifecycle events on the termnial come out of order (or dropped altogether).

TODO: check if the calls need to be delayed some to log

url：https://docs.polymerlabs.org/docs/quickstart/start/#-install-dependencies

This should be just do-it.

Right now, the deployment scripts only take in the dispatcher address or the universal channel handler

In realistic situations, there will be extra constructor arguments. We should enable passing in the arguments from the just command to deploy.

With PR #73 we are moving towards adding most of the config into Hardhat (and later Foundry) config file. So we need to move the config path there as well, so that .env remains only for private info

The original config file did not have the isUniversal flag and in the events filtercondition it is looking for either custom or universal packets which can have spillover.

Action: improve correctness of filtering

I've got an error "Cannot find module './_get-vibc-sc.js' " . I've use v18.19.1. After trying to install package by using "npm install", but it's not working. so, I figured out the error has occurred because there is no _get-vibc-sc.js file available on "scripts" folder.

Currently, the event listener on dispatcher / ucHandler listens for all IBC events. Obviously we only need to filter those relevant to the user's app

Until timeouts are fully supported, set the default timeout higher than 10 hours. Order of 100 days or so

I get the following error while cloning on Windows:

I believe it might be because of the colon in the file name (chains/eip155:11155420.json)

First update:
sudo apt update

Install nodejs 20_x with this command:
curl -fsSL https://deb.nodesource.com/setup_20.x | sudo -E bash - &&
sudo apt-get install -y nodejs

ceck node version:
node -v

First you need to instal Snap
sudo apt install snapd

And then instal Just by rum this command
sudo snap install --edge just --classic

After some of the refactors, the sanity check command is broken (def for universal channels, check for custom)

Some follow-up work from #72

Another change we could add is an extra just recipe, just deploy-verify SOURCE DESTINATION which is similar to deploy recipe but uses the verify script automatically after deployment to verify both contracts being deployed. I'll leave up to you if you want to implement this or if we should pick this up in a separate PR...

Originally posted by @tmsdkeys in #72 (review)

When I develop well in the future, should I apply for ETF?

add just command that allows to verify contracts when blockscout api keys are in the .env file

just verify-contract CHAIN CONTRACT_ADDRESS

Can be either hardhat or foundry

Add a just set-contracts command to the Justfile that sets the contracts to be deployed in the config.json.

Motivation: the developer right now could ignore the config file for every step but updating the config for which contracts to be deployed... it would make sense to also abstract it away for that step

implementation:
just set-contracts CHAIN CONTRACT: sets the contract type in the config.deploy field for the designated chain

Right now, the arguments.js file enables devs to define constructor args arrays. It assumes that the application will alwyas either inherit UniversalChanIbcApp.sol or CustomChanIbcApp.sol and have dispatcher / middleware as their first contructor arg.

It lets devs define additonal args in arguments.js, while constructing a concatenated array with the dispatcher/mw when deploying, but arguably this is confusing.

Could look into different ways of ensuring constructor args are correctly added...

For node Js issues

First use

sudo apt-get update

sudo apt-get install build-essential checkinstall libssl-dev

curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.32.1/install.sh | bash

sudo npm cache clean -f
sudo npm install -g n
sudo n stable

Use this command for Ubuntu

This need to be added for node js