Coder Social home page Coder Social logo

Comments (4)

bkhelifi avatar bkhelifi commented on May 26, 2024

Hello,
I think that they might not for two reasons
1/ the software functioning and accuracy should not depend on the bins scheme or strategy. It is very dangerous
2/ When making a spectrum, the used binning can change strongly between a weak source and a strong one. So, the integration of the migration matrix should be done very accurately over the user binning, based on a fine binning of the migration matrix. The area, in contrary, vary smoothly and interpolations are easy to make without strong computing errors.
So, I can easily conceived that at the end, after computing the software inaccuracies, the binning of the migration matrix could be much finer that the area one.

from gamma-astro-data-formats.

cdeil avatar cdeil commented on May 26, 2024

Hi @TarekHC, just to confirm what @bkhelifi wrote.

Must the energy binning of (for instance) the effective area be identical to the migration matrix by definition?

Short answer: No.

Are they assumed/checked to be identical within ctools/gammapy?

Short answer: No. (not 100% sure for ctools)


So basically the "IRF grids" are independent of the "analysis grids", i.e. for analysis users can choose energy, offset, skymap, ... binnings they like, and the science tool software interpolates and / or integrates onto that analysis grid. Usually IRF grids are chosen to sample the IRF dependencies well when using linear interpolation, and for science analysis the grids can be finer or coarser, depending on the goal of the analysis.

There are some caveats to that: e.g. in HESS we sometimes do event reconstruction or train gamma-hadron in energy bands, which then leads to steps in the IRFs at the energy band edges.
In these cases one can get artefacts at the energy edges when blindly interpolating IRFs onto new grids. At the moment this could maybe still be used by doing tricks like having two very small bins at the edges of these energy bands, but in the (far) future we might want to add more complicated declarative schemes for such things to the IRF format, that e.g. say to the science tools: "you really should be using this energy grid for analysis with these IRFs". Hopefully we will be able to go with a simple scheme and not need such complexities though all the way.


@TarekHC - Close the issue?

If you had this question, probably others will too.
Do you think it's worth / do you have time to add a paragraph explaining this to the spec?

Maybe start a section and bullet list of such general explanations for IRFs here?
http://gamma-astro-data-formats.readthedocs.io/en/latest/irfs/index.html
Or start a new subpage with "IRF notes" at the end of the IRF section?
http://gamma-astro-data-formats.readthedocs.io/en/latest/general/index.html

from gamma-astro-data-formats.

TarekHC avatar TarekHC commented on May 26, 2024

Hi @cdeil ,

There are some caveats to that: e.g. in HESS we sometimes do event reconstruction or train gamma-hadron in energy bands, which then leads to steps in the IRFs at the energy band edges.

This worries me slightly. The cuts we apply to CTA MC data to maximize sensitivity are not smooth at all. That would mean that interpolating some IRFs vs E would lead to very weird features. Although probably in the future we will have smoother outputs.

@TarekHC - Close the issue?

Yes, the answer is clear.

Do you think it's worth / do you have time to add a paragraph explaining this to the spec?

Next week I'll read them again, and see if a note should be added.

from gamma-astro-data-formats.

jknodlseder avatar jknodlseder commented on May 26, 2024

from gamma-astro-data-formats.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.