Coder Social home page Coder Social logo

Comments (7)

TarekHC avatar TarekHC commented on June 20, 2024

Hi @maxnoe

This is essentially #30.

The thing is that it is hard to be consistent, given that ENERGY within the IRFs refers to the true energy, while within the event lists it refers to the estimated one...

Using TRUE_* might be more consistent with what the IACT community has been using until now, although I think using MC_* would be way more obvious, so no one makes a mistake. What do you (and others) think?

We would also need some metadata to store the usual MC-related parameters... Although that is probably something not so high level...

from gamma-astro-data-formats.

jknodlseder avatar jknodlseder commented on June 20, 2024

from gamma-astro-data-formats.

maxnoe avatar maxnoe commented on June 20, 2024

The same as for the other definitions, to have a common data format for easy exchange and processing of such data.

Right now, one of the use cases would be to compare output of MARS, EventDisplay and ctapipe and to calculate the IRFs from such inputs.

from gamma-astro-data-formats.

TarekHC avatar TarekHC commented on June 20, 2024

@maxnoe I think calculating IRFs needs DL2, not DL3. So @jknodlseder is right that it might be slightly out of scope regarding that specific science case.

But there are probably other tests and use cases that could benefit from such a definition. You could, for instance, compare a full simulation of any source with the high-level simulation of e.g. ctaobssim.

from gamma-astro-data-formats.

maxnoe avatar maxnoe commented on June 20, 2024

As the only difference between DL2 and DL3 is the added IRFs, this does not matter for the event list format, it would be the same for DL2 and DL3, right?

from gamma-astro-data-formats.

TarekHC avatar TarekHC commented on June 20, 2024

As the only difference between DL2 and DL3 is the added IRFs, this does not matter for the event list format, it would be the same for DL2 and DL3, right?

Mmmm... I kind of disagree. Even if technically they may be extremely similar, DL3 contain only gamma-like events and DL2 doesn't (so it would mean a change of paradigm, no?). In addition, DL2 would need to contain all the metadata/provenance from the simulations, which again might be slightly out of scope for this repo.

It is of course a matter of what we want to do, but DL2 is something probably more internal to ctapipe, so perhaps this is not the place for its definition (or perhaps it is?). Anyway, I still agree that it could eventually be useful to have a definition of true quantities, in case we ever need them.

from gamma-astro-data-formats.

adonath avatar adonath commented on June 20, 2024

In Gammapy we introduced "true" (energy / ra / dec) columns for simulated DL3 events lists, but this was only meant to be used internally for debugging / testing and is un-documented. During the implementation of the event sampling having access to the "true" information was useful, now that it's implemented not so much anymore. In general I agree it might be useful to have e.g. for technical studies.

I think the DL3 event list format is still rather simple and I wouldn't see any problem adding "true" columns as optional columns (https://gamma-astro-data-formats.readthedocs.io/en/latest/events/events.html#optional-columns). But I would rather see it as a preliminary solution, because I also agree with @TarekHC, that the technical requirements are different for DL2/DL3. Before cuts the DL2 event files can be orders of magnitude larger, different meta data is required and in terms of performance I'm not sure either whether FITS is the best suited format for DL2 event lists.

from gamma-astro-data-formats.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.