Comments (2)
@jknodlseder - A few questions:
- What are current high-energy missions (Fermi, Chandra, XMM, ...) using?
Integer or string forOBS_ID
? - In tools like Gammalib and Gammapy, would we have to support both integer and string for
OBS_ID
for a while or forever? - For FITS header keywords, there's no difference, right? If the value can be parsed as an int, tools like
astropy.io.fits
return it as an int. So we're only talking about table column dtypes for EVENTS and OBS_INDEX or other tables that haveOBS_ID
as a column?
Just to give the counter-argument why we might want to keep int
:
- This is a breaking change. Current files use
int
and science tools only supportint
:
https://github.com/gammapy/gammapy/search?utf8=%E2%9C%93&q=OBS_ID
https://github.com/gammalib/gammalib/search?utf8=%E2%9C%93&q=OBS_ID - The quote you cite says that int would be nicer, and this is only allowed as string because older missions had string.
- One use case I could think of for int
OBS_ID
that I've used myself is to merge events from multiple observations (all for HESS 1) into one event list and then join that with event lists from other recos and cuts to study event reconstruction differences and cut differences. Of course it can be done differently.
My impression is that int is simpler and more convenient and is in place, so I don't see the advantage of doing the change.
@jknodlseder - if you're available I'll put this on the agenda for next Tuesday's IACT DL3 telcon:
https://github.com/open-gamma-ray-astro/2016-04_IACT_DL3_Meeting/blob/master/notes/2016-09-06-IACT_DL3_Telcon.md
from gamma-astro-data-formats.
@jknodlseder - Do you still think CTA / IACT DL3 data should change OBS_ID to be a string instead of an int?
It would be quite a big breaking change, at least in Gammapy we work with OBS_ID
as integer in several places, and presumably in ctools you do as well?
@kosack - Is there a plan for this in CTA already? Should discussions continue here on the DL3 spec, or is there a different spec / process now in CTA?
from gamma-astro-data-formats.
Related Issues (20)
- Event lists for simulated events HOT 7
- Recommended EXTNAME only given for few of the HDUs
- Required axis order and make clear how axis order is defined HOT 2
- Generalize to wide-field ground array instruments HOT 9
- Error in python time example
- Invited contribution in the "Universe" journal on data formats for gamma-ray astronomy HOT 7
- PSF Table documentation HOT 3
- Organisation / maintaining GDAF HOT 5
- Mailing list down HOT 6
- Order of axes in Edisp IRF HOT 20
- Standardise EXTNAMEs for HDUs HOT 8
- Add systematic errors in the error columns of the SED specifications HOT 2
- CALDB and IRF keywords in IRFs HOT 21
- Presentation of the initiative at the DPG spring meeting HOT 14
- Trigger automatic build of readthedocs HOT 10
- RADECSYS and co are deprecated in FITS standard 4.0
- What to do if OGIP conventions and the FITS standard are in conflict? HOT 2
- Make a final release before handing over to VODF? HOT 10
- Documentation not updated to version 0.3 HOT 1
- Presentation at the Astroparticle-Physics Symposium 2022 HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gamma-astro-data-formats.