Coder Social home page Coder Social logo

Comments (3)

cdeil avatar cdeil commented on June 5, 2024

The units of the PSF table should be sr^-1 which is the SI unit of a solid angle (see e.g. https://en.wikipedia.org/wiki/Steradian). Square degrees is a non-SI unit

We're using deg in many other places, so I don't see how using deg^-2 could be bad.
@jknodlseder - Is deg also not an SI unit and you want to get rid of it?

But gtpsf uses sr^-1, so for consistency, I'm 👍 to change the psf_table spec to use sr^-1.
I can do the change in the spec.

@lmohrmann or @dltiziani Can you make the change in the HAP exporter?

from gamma-astro-data-formats.

cdeil avatar cdeil commented on June 5, 2024

@dltiziani - Another thing to fix in the HESS exporter is this:

In [1]: from astropy.table import Table

In [2]: t = Table.read('datasets/hess-crab4-hd-hap-prod2/run023400-023599/run023523/hess_psf_table_023523.fits.gz')
WARNING: UnitsWarning: '1/(deg^2)' did not parse as fits unit: Numeric factor not supported by FITS [astropy.units.core]

We had this issue before ... the problem is the "1/" in the string ... the solution is to write "sr^-1", i.e. don't have a "1/" in the unit string.

from gamma-astro-data-formats.

cdeil avatar cdeil commented on June 5, 2024

I've implemented this change in #55. Closing this issue now.

from gamma-astro-data-formats.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.