onionshare / onionshare-ios

iOS version of OnionShare (under development)

OnionShare

OnionShare is an open source tool that lets you securely and anonymously share files, host websites, and chat with friends using the Tor network.

Installing OnionShare

You can download OnionShare for Windows and macOS from the OnionShare website.

For macOS you can also use Homebrew:

brew install --cask onionshare

See these instructions to install OnionShare in Linux as a Flatpak or Snap package.

Documentation

To learn how OnionShare works, what its security properties are, how to use it, and how to contribute to the project, check out https://docs.onionshare.org.

onionshare-ios's Issues

Sharing Empty State Illustration

Current:
iOS empty state illustration is inconsistent with the Android app.

Expected:
Update with the assets found here: https://keybase.pub/glennsorrentino/onionshare/ios/illustrations/

File List Metadata & Visual Design

Current

• There's minimal metadata displayed in the file list. This can decrease usability when ambiguous files are present. Can lead to questions like "Is that the 100MB untitled.txt file, or the 1KB version?"

Expected

• Added file metadata, and overall list metadata
• Background color #FFF
• UI elements share left alignment

OnionShare iOS

I am curious how well does the OnionShare application work on iOS? I am asking this question because when I downloaded the Tor browser application for iOS; I had connection issues. The Tor browser application worked 50% of the time. Hopefully, this won’t be the case with the OnionShare application…..

Branded UI Color Update

Current:

• iOS uses default colors for buttons and text.
• Inconsistent with colors the Android app is using.

Expected:

• For light mode, use #4E064F
• For dark mode, use #9A61B7

Remove Host Functionality

Current Functionality: Both Host and Share functions are present. iOS is unique in this featureset.

Expected:

• Only Share functionality
• Heading should be updated to display name of app

Sheet UI - excessive margin under button

Current
The margin under the primary button adds excessive negative space to the UI.

Expected
Margin should be ~1rem/16px.

Update disabled button color while OnionShare is starting

Current UI: After the user taps "Start Sharing" the button changes to a dark grey color of #545454.

Expected UI: The default color should be changed to 50% opacity to communicate the disabled state.

Timeline for receive files, host a website, chat anonymously features

Hello, do you know when the OnionShare iOS application; will have the following features available: receive files, host a website, chat anonymously? At the very least the capability to receive files is paramount for me. If there is an issue implementing these features on iOS I totally sympathize.

More Prominent Progress Bar

Current UI: Progress bar looks like it's ~3px.

Expected: 2x the original width.

Unable to Download Videos

Device: iPhone XR, iOS 15.3.1
Onion Share Version: 0.1.0 (7)

Steps followed:
1.-I opened the app
2.-Went to the "Share" section
3.-Selected a video to share
4.-Copied the link when it was ready
5.-Open the link on Tor Browser for Android
6.-Tap on "Download Files"
7.-The video opened on the browser but did not download.
*I was able to download images and folders with images and videos in them, but not single videos.

File List UX - Add Folder Drill-In

Current
User cannot drill in to a folder.

Expected

• Allow drill-in, even if there are no contents within the folder.
• Displaying a chevron.right icon to indicate functionality.

Sheet UI - Sharing State

Current

• Sheet heading needs greater hierarchy
• UI text should have consistent emphasis on key words.
• Share button gets lost in the UI
• The box-shadow is pretty strong.
• The button should sized consistently with the primary CTA in the ready-state.
• The styles appear as:
  sheet { box-shadow: 0px 0px 8px rgba(0, 0, 0, 0.9); } h1 { font-size: 17pt; } button { width: fit-content; }

Expected

• Add padding and background color to sharing buttons to add emphasis.
• Full-width button
• Bold the important words in the UI text.
• uniform alignment of UI elements
• Styles adjusted to:
  sheet { box-shadow: 0px 0px 24px rgba(0, 0, 0, 0.14); } h1 { font-size: 22pt; font-weight: bold; } button { width: 100%; font-weight: normal; }

Action Priority & Clarity

Current

• Configuring a bridge is the first option in the UI, but is it the most important thing to users?
• Does the bridge icon communicate what it is?
• Should the user use the actions in the header or in the body?

Expected

• Use an overflow to group secondary and tertiary actions together.
• I'm considering adding photos/files in the header secondary in the contexts of the empty state and after files are initially added. The user has the actions with greater clarity and emphasis in the primary area of the screen, so using an overflow isn't hiding any functionality. After a file is added, those actions become more secondary and don't need to be always-present in the interface.

Socket support

How long it will take for this project release and does it support socket connection as i am planning to create peer to peer chat via tor?

Sheet UI - Ready State

Current
-Sheet heading needs greater hierarchy.
-Share button gets lost in the UI.
-Start Sharing button is the primary action, but the button's footprint doesn't reflect its priority.
-The box-shadow is pretty strong.
-The styles appear as:
sheet { box-shadow: 0px 0px 8px rgba(0, 0, 0, 0.9); } h1 { font-size: 17pt; } button { width: fit-content; }

Expected
-Add padding and background color to sharing buttons to add emphasis.
-Make primary button full-width of the sheet.
-Uniform alignment of UI elements.
-Styles adjusted to:
sheet { box-shadow: 0px 0px 24px rgba(0, 0, 0, 0.14); } h1 { font-size: 22pt; font-weight: bold; } button { width: 100%; font-weight: normal; }

Progress Indicator Styling

Current
The progress indicator is a percent-based number.

Expected
A progress bar to provide visual feedback.

Issues accessing files when sharing as "website"

Added some files to share in "Share" view and "Website" view, but couldn't access the files when shared as website.

See the video!

OnionShareiOSbug-website-file-share.mov

Prepare release

To finally get this out the door, we're going to need the following:

• Somebody with permission to fill the App Store details (Micah?)
• Decision which which version number we start? 0.1.0? 1.0.0? Something else?
• All necessary App Store metadata in (at least) English.

I'll commit empty Fastlane metadata files, so we have a better idea what we need and where we can work collaboratively on.
You will find them here: https://github.com/onionshare/onionshare-ios/tree/main/fastlane

Here is some description of the files and potential values: https://docs.fastlane.tools/actions/deliver/#tips

Here screenshots of App Store Connect so you can see where it's going to go:

Tab Labels

Current
Tab labels use different conventions for naming - one is a verb, the other a noun

Expected
Use verbs for both tabs.

Bug - Poor UX - Folder Selection

Device: iPhone 13 Pro
iOS version: 15.4.1
OnionShare version: 0.1.0 (7)

Current

• There are two calls to action for files and folders.
• Tapping "Add a Folder", then selecting a folder doesn't add that folder - it instead tells the app to choose the folders inside of that folder.

Steps to Reproduce

1. Tap "Add folder" from the Share empty state screen.
2. Select the folder to add.
3. Wait a few seconds to see if there's latency.
4. Nothing is added ☹️.

Expected UX

• One call-to-action for adding Files and Folders.
  • Selecting a folder adds files and folders inside.
  • Selecting a files adds that file.

cant-add-folder.mp4

App store release assets

add webhook for weblate

Weblate is prepared to receive information when a repository has been updated, with a notification webhook.
This will prevent the problems with merges etc.

The webhook URL is simply https://hosted.weblate.org/hooks/github/

Here the instructions: https://docs.weblate.org/en/weblate-4.14.1/admin/continuous.html#github-setup

There is also a Weblate app for github but I have no idea what that is. The webhook works very well to prevent merge conflicts!

Update background color

Current UI: After the user selects files to share, the background becomes grey, creating issues with grouping, contrast, and consistency.

Expected UI: all backgrounds are white.

Reduce Half-Sheet Drop Shadow

Current UI: The drop shadow is a little heavy, maybe #000 ~25%?

Expected: The shadow should be lighter, around 15%, and if possible an outline (outer border) of rgba(0,0,0,0.15) for better edge contrast.

add support for "share extension"

Reduce Margin Above Half Sheet Toggles

Current UI: Excessive margin above half-sheet toggles.

Expected UI: Reduced to 25% its original height, from 88px, to 22px.

add support for direct onion downloads

• for sharing, add manifest at well-known endpoint
• if present use that to download files
• save to "Files"
• add in app download monitor / tab

Create PR for OnionShare main landing page to extend for mobile builds

Sheet UX - button functionality

Current
There's no way to cancel the startup process.

Expected
Improve error-recovery UX by adding the ability to cancel at any time.

screen flashes off/on while sharing

I see black flash a few times in a row, then the screen stays on.

related to keeping the device awake?

Review & Quote A11y Lab Findings

Science & Design is a new fiscal sponsor of OnionShare. We recently engaged with A11y Lab, via OTF's SUA Lab, to have OnionShare's suite of apps audited. There are a few findings for the iOS application. Could you please have a look and provide a time estimate and quote for addressing the issues?

The full report is here: https://github.com/scidsg/Project-Info/blob/main/OnionShare/Audits/Accessibility/WCAG%202.1%20OnionShare.iOS.docx

To see accessibility findings across platforms: https://github.com/scidsg/Project-Info/tree/main/OnionShare/Audits/Accessibility

in website sharing, allow adding of whole site via select folder

1. use an iOS app to make a local website
2. store in local iOS "files" app filesystem
3. use onionshare to share a website
4. select folder to add the whole website (instead of individual files)

Empty State Position

Current
The empty state for both Sharing and Website modes are positioned at the top of the viewport, creating excessive negative space in the UI

Expected
Centered in the viewport, with 2rem padding bottom to bring the action closer to the center of the screen.

File List UI - visual design

Current

• The icons in the file list are inconsistent with native patterns.
• The background color is creating excessive contrast in the UI.

Expected

• Native icons and thumbnails @ 48x48px
• White background color.

for website sharing, allow user to add a folder

They may have a locally created website folder, and want to add the entire thing.

This is fits with the OnionShare desktop "host a website" concept.