ongr-archive / monitoringbundle Goto Github PK

https://github.com/ongr-io/MonitoringBundle/blame/master/Resources/doc/setup.rst#L30
Here by removing dots in between bundles copy-pasting will be a lot easier :)

After reading documentation i found out following things.

Bundle provides a way to define and collect metrics, it comes with document count metric and other types of metrics must be defined by user.

It has command logging with some events thought its unclear how this works and whats the purpose of listed events.

There should at least some information what this bundle does, why and when should I use it?

After trying to create metric i get Metric with name 'date_metric' was not found.

Here is my class.

namespace ONGR\DemoBundle\Metrics;

use ONGR\MonitoringBundle\Metric\MetricInterface;

/**
 * Class DateMetric.
 */
class DateMetric implements MetricInterface
{
    /**
     * {@inheritdoc}
     */
    public function getValue()
    {
        return new \DateTime();
    }

    /**
     * {@inheritdoc}
     */
    public function getName()
    {
        return 'date_metric';
    }
}

This is my configs.

ongr_monitoring:
    es_manager: monitoring
    commands:
        commands:
            - ongr:monitoring:metrics:collect
    metric_collector:
        metrics:
            document_count:
                - { name: foo, document: es.manager.default.product }
            date_metric:
                - { name: date_metric, document: es.manager.default.product }

services:
    ongr_demo.metric.date:
        class: ONGR\DemoBundle\Metrics\DateMetric
        tags:
            - { name: ongr_monitoring.metric, metric: date_metric }

There is no information on how metrics are stored (aside the fact that they are put into ES) and how to view them.

In doc blocks repository is defined as string but is used as actual repository.

Also service definition example does not match actual class. Some constructor arguments are missing in service.

Enable Travis configuration. Configuration file exists, but travis is not running.