Coder Social home page Coder Social logo

Comments (7)

bluesign avatar bluesign commented on July 30, 2024

Hey @justjoolz,

This is very good idea, few suggestions:

  • I feel there is a need for Ticker Symbol

  • tokenID and tickerSymbol ( if added ) should be guaranteed to be globally unique. ( I think this is the most tricky part, squatting symbol etc ) I think we will end up 2 level here: ISSUER.TOKEN (ex: CIRCLE.USDC etc )

  • Maybe linking with existing Fungible Token standard can be a better choice. ( I mean adding ticker symbol and token ID there somehow ) More like FungibleTokenV2 instead of FungibleTokens ( I think it is also possible to update old Tokens to support new standard )

  • In general I like separating by Type more than separating by ID. But in this case, I think it can be a valid exception. But also I am a bit scared there maybe some misuse cases. ( System actors can force people to use their own ISSUER for some benefits )

from flow-ft.

justjoolz avatar justjoolz commented on July 30, 2024

I was thinking Ticker Symbol and issuer could be defined as MetadataViews but not a requirement of the interface?
Issuer in this case would be similar to Contract level metadata for an NFT collection

Here tokenID is used in same way as ID in NFT standard, ie not unique across implementations.

Not sure if there is a good way (semantically) to have singular and plural token issuing in the same contract, unless we had optional parameters (ie. don't need to pass tokenID: nil to a Vault issued from a singleton contract)

from flow-ft.

bluesign avatar bluesign commented on July 30, 2024

Ah I just got the tokenId, this is good point.

I think having 2 standards (when multiple already covers single use case with tokenId=1) can be confusing for adaptation.

Also as metadata is a standard now, forcing new standard to use existing standard can be beneficial.

Maybe something like NFT minting, you can mint a new type of FT. ( so people can query which subtype of FTs contract has also they can have separate totalSupply etc when minted )

from flow-ft.

joshuahannan avatar joshuahannan commented on July 30, 2024

This is definitely needed, but @dete has a more fundamental update in mind for the fungible token standard to be able to support multiple definitions by basically using resource interfaces defined in a contract instead of contract interfaces. He has written a proposal that he is going to share with the community soon.

from flow-ft.

justjoolz avatar justjoolz commented on July 30, 2024

@bluesign the design does work like Minting new FTs (and storing in a shared collection), totalSupplyByID is intended to be used exactly as you described.

@joshuahannan that sounds interesting, look forward to seeing the proposal...

I tried to keep this as simple as possible and as a blend of the existing FT and NFT standards without introducing any new patterns/concepts.

from flow-ft.

joshuahannan avatar joshuahannan commented on July 30, 2024

@justjoolz Have you seen the proposal yet? We posted it last week: https://forum.onflow.org/t/streamlined-token-standards-proposal/3075/13

from flow-ft.

joshuahannan avatar joshuahannan commented on July 30, 2024

This is handled in the v2 standard, so I am going to close this issue

from flow-ft.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.