Comments (21)
Release as 4.0.0
from rascal.
Currently available on the promise-support branch. I'll publish once I've done some more testing and had it reviewed.
from rascal.
Good spot. It's a weakness in the rascal API that you can't safely go async between calling subscribe
and registering the on message handler.
Couple of things I might be able to do...
- Accept an optional event handler as part of the
subscribe
function. - Not start consuming messages until an on message event listener was added using the newListener event
from rascal.
I think the API will be better if the user can subscribe to events before starting to consume messages from rabbit, so I'm still giving it some thought. I have a lot of other stuff on at the moment though so it won't be soon though.
from rascal.
@BorePlusPlus just came up with a nice idea. Instead of consuming messages immediately, if rascal could wait for an on('message')
handler to be registered. Will investigate
from rascal.
Thanks for the nudge @mixecan. I'll bump it up my list.
from rascal.
No. It would increase the complexity of the code base and testing overhead.
from rascal.
Could you expose classes via module.exports
(for example, Broker) so that I can use bluebird.promisifyAll
to provide a promise-style API?
from rascal.
I'll create a branch and do it there. You happy to test / feedback?
from rascal.
Thanks! It won't be better!
I will use it in our experimental environment :P
from rascal.
Try
{
"dependencies": {
"rascal": "git://github.com/guidesmiths/rascal.git#promises"
}
}
Promise.promisifyAll(require('rascal').classes)
from rascal.
Thanks for your effort. However it doesn't fully work at least for broker (I haven't tried other classes yet) because:
-
Broker does not expose its base class https://github.com/guidesmiths/rascal/blob/promises/lib/amqp/Broker.js#L17
In this way, broker instance methods such asbroker.publish
won't be promisified. -
Broker
does not use prototype to define its methods thusbluebird.promisifyAll(Object.getPrototypeOf(someBrokerInstance));
will not work either.
promisify(someBrokerInstance)
works but it is not ideal because it is not a one-time setup.
I would try to make some changes and will send you PRs whose implementations are friendly to promisify.
from rascal.
Thanks. I'm happy to accept a PR.
from rascal.
I made first attempt to make Broker promisify friendly:
Simple example rewritten in Promise way and ES 2017:
import bluebird from 'bluebird'
import Rascal from 'rascal'
bluebird.promisifyAll(Rascal.Broker)
bluebird.promisifyAll(Rascal.Broker.prototype)
(async () => {
const broker = await Rascal.Broker.createAsync(Rascal.withDefaultConfig(config))
broker.on('error', console.error)
const subscription = await broker.subscribeAsync('demo_sub')
subscription
.on('message', function(message, content, ackOrNack) {
console.log(content)
ackOrNack()
})
.on('error', console.error)
setInterval(async () => {
await publication = broker.publishAsync('demo_pub', new Date().toISOString() + ': hello world')
publication.on('error', console.error)
}, 1000)
}())
from rascal.
I am going to test the new broker these days to see if there are any problems :P I will make PR later
from rascal.
Looks good to me. Thanks. After submitting the PR how do you feel about maintaining a 'rascal-as-promised' module?
from rascal.
Thanks, I might not be a good person to maintain that since most of the time I am not working with something related to AMQP :P I prefer to making rascal friendly to promisify tools so that users who want to use a promise style API can easily achieve that while rascal needn't care much about the promise API.
from rascal.
Ok seems that the promise way may lose message..caused by await broker.subscribeAsync('demo_sub')
..
from rascal.
Not as easy as I'd hoped.
- Would need to take multiple event handlers ('message', 'invalid_message', 'error', 'redeliveries_exceeded')
- Breaks the subscrition.cancel behaviour.
from rascal.
Agree with you. BTW Promise is at least a microtask so that changing API is unavoidable to support Promise. This functionality is more difficult than I thought :P
from rascal.
@BorePlusPlus just came up with a nice idea. Instead of consuming messages immediately, if rascal could wait for an
on('message')
handler to be registered. Will investigate
Any change we can see this on the master branch?
from rascal.
Related Issues (20)
- How to update subscriptions after use Broker.create(config) HOT 1
- MaxListenersExceededWarning HOT 4
- Config with only subscribers HOT 11
- Customize consumer tag HOT 2
- Failed to assert vhost: Timeout of 1000ms exceeded HOT 3
- How can I do multi-ack? HOT 6
- Potential messages multiply? HOT 21
- Rascal fatal error - Timed out waiting for broker to confirm publication HOT 3
- withDefaultConfig does not work properly with url connection strings HOT 3
- FEATURE: Consumer prefetch update? HOT 7
- Messages multiply in queues (part II) HOT 13
- No channels left to allocate HOT 3
- No channels left to allocate HOT 5
- Rascal connects to RabbitMQ stop receiving messages under high load HOT 13
- BUG: no way to use passwords in connection url that would make the url invalid HOT 3
- Rascal doesn't reconnect when connection with the broker is dropped HOT 6
- FEATURE: Add support for updatable authentication secrets
- FEATURE: Upgrade dependency superagent to v9.0.0+ to include vulnerability fix HOT 2
- FEATURE: Add NodeJS Streams support to subscriptions HOT 2
- FEATURE: Improve the republish strategy with immediateNack and dead-letter queue HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rascal.