Comments (6)
I've updated v16.2.0 so you can do
ackOrNack(null, { all: true })
or
ackOrNack(err, { strategy: 'nack', all: true })
I looked at acknowledging all messages up to the current one, but because rascal keeps track of how many outstanding messages there are so that it can gracefully shutdown, this would have been a more significant change so I decided to leave it.
from rascal.
Hi @mortiy,
It's not currently possible with Rascal. I'm not against adding it. Currently ackOrNack
takes no arguments when you want to acknowledge, or an error object plus optional recovery config if you want to handle a problem, e.g. ackOrNack(err, { strategy: 'requeue' })
. Changing the API to accept a boolean in place of the error object to signify multiple acknowledgments, i.e. ackOrNack(true)
would be a potential, but dangerous solution as current versions of Rascal only check with the error parameter is truthy, and I suspect will nack the message if passed true. This would mean that any existing client code which passed a truthy, non-error value, would start acknowledging messages instead of nacking them.
A safer alternative would be to pass null or undefined for the error argument, and a config object as an optional second parameter. e.g. ackOrNack(null, { multiple: true })
. Providing I catered for the optional callback, I think this would work well.
I'm happy to spend some time on it, or accept a tested PR (I can provide guidance), but before going further, would like to understand why you are interested in this feature. I've never found any use for multiple acknowledgements, which is why they have been overlooked until now.
from rascal.
Hi @cressie176,
why you are interested in this feature.
I'm implementing AMQP messages batching for my task.
So I'm pre-fetching, for example, 1000 messages (without ack), collect them into single batch and process in a whole.
When I'm done (with successful result), I need acknowledge all of them.
Right now, I have to keep all 1000 ackOrNack
function references to do that, but with multi-ack I could keep only the last one.
from rascal.
OK, that makes sense. Thank you
from rascal.
@mortiy OK to close?
from rascal.
Yes, thank you.
from rascal.
Related Issues (20)
- How to update subscriptions after use Broker.create(config) HOT 1
- MaxListenersExceededWarning HOT 4
- Config with only subscribers HOT 11
- Customize consumer tag HOT 2
- Failed to assert vhost: Timeout of 1000ms exceeded HOT 3
- Potential messages multiply? HOT 21
- Rascal fatal error - Timed out waiting for broker to confirm publication HOT 3
- withDefaultConfig does not work properly with url connection strings HOT 3
- FEATURE: Consumer prefetch update? HOT 7
- Messages multiply in queues (part II) HOT 13
- No channels left to allocate HOT 3
- No channels left to allocate HOT 5
- Rascal connects to RabbitMQ stop receiving messages under high load HOT 13
- BUG: no way to use passwords in connection url that would make the url invalid HOT 3
- Rascal doesn't reconnect when connection with the broker is dropped HOT 6
- FEATURE: Add support for updatable authentication secrets
- FEATURE: Upgrade dependency superagent to v9.0.0+ to include vulnerability fix HOT 2
- FEATURE: Add NodeJS Streams support to subscriptions HOT 2
- FEATURE: Improve the republish strategy with immediateNack and dead-letter queue HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rascal.